899063 - [Dialer] Unable to input any keypad number during a call

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[:gerard-majax]

When in a call, we cannot anymore tap on the keypad's number. This is breaking, for example, voicemail usage.

Reproduced with gecko-18 @ 109818a and gaia master @ ea233c3 on Inari device

Comment 1

[:gerard-majax]

I'm not reproducing this one on uptodate v1-train.

Comment 2

[:gerard-majax]

Reverting bug 892880 fixes the issue. I'm investigating whether with Gecko master the issue is also present.

Comment 3

[:gerard-majax]

I can confirm that the issue is present with up to date gecko master too.

Comment 4

[:gerard-majax]

FYI, logcat shows:

E/GeckoConsole( 1310): [JavaScript Error: "TypeError: this.dialerMessageText is null" {file: "app://communications.gaiamobile.org/dialer/gaia_build_defer_oncall.js" line: 86}]

Comment 5

[:gerard-majax]

Clearly, either the code should ensure that this.dialerMessageText does returns something useful, or we need to add the element in the oncall.html file. I'm not sure which one is the correct fix, I'll leave it to you guys. FYI, the second one worksaround the issue for me.

Comment 6

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/gaia/pull/11227

Please find attached a link to Gitub pull request #11227 https://github.com/mozilla-b2g/gaia/pull/11227 that fixes the issue by checking the existence of the dialerMessageText element before using it. This fix makes more sense to me than adding a fake element inside oncall.html. From my current testing, it fixes the issue.

Comment 7

[Anthony Ricaud (:rik)]

In bug 899186, I'm proposing to review this text entirely. So maybe the fix for this is removing code. :)

I think the fix is fine, I just have one comment in the PR.

Comment 8

[bhavana bajaj [:bajaj]]

I have added to confirm qawanted to confirm this issue on the latest Build.

Alexandre, Also bug 892880 is koi+ and does not seem to have landed on 1.1, so why is this need on on 1.1. Confused :|

Comment 9

[Andrew Overholt [:overholt]]

(In reply to Alexandre LISSY :gerard-majax from comment #1)
> I'm not reproducing this one on uptodate v1-train.

Setting leo+ only happens for regressions that occur in what will become v1.1 and not on master.

Comment 10

[:gerard-majax]

(In reply to bhavana bajaj [:bajaj] from comment #8)
> I have added to confirm qawanted to confirm this issue on the latest Build.
> 
> Alexandre, Also bug 892880 is koi+ and does not seem to have landed on 1.1,
> so why is this need on on 1.1. Confused :|

Because at first I thought it was on gecko-18 thus v1.1, and after I got dragged in somehting else, and forgot to switch back. My apologies :(

Comment 12

[Jason Smith [:jsmith]]

Adding smoketest keyword - this is breaking daily smoke tests. Can we finish off this patch here and get this landed?

Comment 13

[Anthony Ricaud (:rik)]

I have a patch in bug 899186 that removes the faulty code so this will get fixed when it lands.

Comment 14

[Anthony Ricaud (:rik)]

Closing as bug 899186 landed.

Comment 15

[J Zimbrick]

Issue no longer seems to be occurring on an Unagi device running the latest 1.2 mozril build:

Environmental  Variables:
Build ID: 20130802070203
Gecko: http://hg.mozilla.org/mozilla-central/rev/c489af94ada5
Gaia: 4b347e4e39b1716b68463dccc63c1b3eb49158b3
Platform Version: 25.0a1

This issue is no longer breaking our smoketests. Removing keywords.

Comment 16

[Jason Smith [:jsmith]]

(In reply to J Zimbrick from comment #15)
> Issue no longer seems to be occurring on an Unagi device running the latest
> 1.2 mozril build:
> 
> Environmental  Variables:
> Build ID: 20130802070203
> Gecko: http://hg.mozilla.org/mozilla-central/rev/c489af94ada5
> Gaia: 4b347e4e39b1716b68463dccc63c1b3eb49158b3
> Platform Version: 25.0a1
> 
> This issue is no longer breaking our smoketests. Removing keywords.

That means you've verified the bug is fixed then, which mean this gets marked verified.