899627 - backport upstream bug 856736 to bmo/4.2 for filtering on dependency bugmail

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[David Lawrence [:dkl]]

Ok so I found the place where we fixed this in the code and therefore changed your email headers to be different than before.

http://bzr.mozilla.org/bmo/4.2/revision/8687

It was not related to the header change we did recently and was instead a bug fix where it was causing our logs to fill up with warnings. 

The header "X-Bugzilla-Changed-Fields:" was there before our upgrade on 3/5 to Bugzilla 4.2 but was blank unintentionally for dependency emails. We were not populating the field description values properly. After the fix on 3/25 the "Status Resolution" values are now being displayed properly. 

The fact that you were filtering on the original empty X-Bugzilla-Changed-Fields: header was unfortunate but not our intention.

Instead what I propose is we issue a proper header for dependency changes so you will have something better and more stable to filter on. 

Currently we have:

X-Bugzilla-Type: changed 

for both normal bug change notifications and dependency notifications. I propose we change the X-Bugzilla-Type header to show dep_changed when it is a dependency notification like the one you pasted in comment 0:

X-Bugzilla-Type: dep_changed

We should push this upstream as well if possible.

glob, opinion?

dkl

Comment 1

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified Bugzilla/BugMail.pm
modified template/en/default/email/bugmail-header.txt.tmpl
Committed revision 8909.