900855 - [Buri][WIFI]It is abnormal when turn on WIFI

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.171
 Firefox os  v1.1
 Mozilla build ID:20130722070207
 
 DEFECT DESCRIPTION:
 It is abnormal when turn on WIFI
 
 REPRODUCING PROCEDURES:
 1)switch on wifi->select and connect a valid AP->exit the wifi screen;
 2)enter into Internet sharing->turn on wifi hotspot->wait about 1min->the wifi
 hotspot switch off automatically;-->KO1
 3)back to and open wifi->the screen will show "Searching" always and can't
 search anyone AP-->KO2
 Notes：
 the phone can't search anyone AP unless you restart the phone;
 REPRODUCING RATE:  5/5
 
 
 For FT PR, Please list reference mobile's behavior:

Comment 1

[Ray REN]

Hi, We find the reason maybe this: When we are unloading driver, via user's  operation, we need to load driver. On this time, the issue also happens.

Comment 2

[sync-1]

Hi,
 
 How to avoid this issue? Do you have solution to fix it？
 
 I think when you need to load driver, it should detect whether unload driver completed.

Comment 3

[Alex Keybl [:akeybl]]

Not being able to connect to wifi is an awful user experience. leo+ for now.

Comment 4

[Vincent Chang[:vchang][changyihsin]]

I followed STR in comment 1, but I can't reproduce the problem. 

Gaia commit 271fb7204c3d8c2a52d69e1c0e6aa4d7414b9fa8
Gecko commit 8878e8a4636c58227856ee2b76fc7d95a4cc9709
./config.sh hamachi

Please let me know your Gaia and Gecko commit information.

Comment 5

[Vincent Chang[:vchang][changyihsin]]

(In reply to Ray REN from comment #1)
> Hi, We find the reason maybe this: When we are unloading driver, via user's 
> operation, we need to load driver. On this time, the issue also happens.

The unload wifi driver is controlled by ro.moz.wifi.unloaddriver. The default value should be "0" which means not unload drive even if user turns off wifi.

Comment 6

[Ray REN]

(In reply to Vincent Chang[:vchang] from comment #4)
> 
> Please let me know your Gaia and Gecko commit information.

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.179
Firefox os  v1.1
Mozilla build ID:20130730070228

Comment 7

[Ray REN]

(In reply to Vincent Chang[:vchang] from comment #5)
> The unload wifi driver is controlled by ro.moz.wifi.unloaddriver. The
> default value should be "0" which means not unload drive even if user turns
> off wifi.

In our side the ro.moz.wifi.unloaddriver is "1". Please tell me how and where can we change this values?

Comment 8

[Vincent Chang[:vchang][changyihsin]]

(In reply to Ray REN from comment #7)
> (In reply to Vincent Chang[:vchang] from comment #5)
> > The unload wifi driver is controlled by ro.moz.wifi.unloaddriver. The
> > default value should be "0" which means not unload drive even if user turns
> > off wifi.
> 
> In our side the ro.moz.wifi.unloaddriver is "1". Please tell me how and
> where can we change this values?
It should be in init.*.rc file of Kernel's Ramfs file system. But I don't think this property is set right now. 

The wifi module read this property in WifiWorker.js.  
http://mxr.mozilla.org/mozilla-central/source/dom/wifi/WifiWorker.js#90

Comment 9

[Ray REN]

Hi Vincent,

In our side, this issue is easy to reproduce. And I fo"ro.moz.wifi.unloaddriver" is "1", it means we need to unloader driver if wifi-off. So could you fixed in gecko? For example  when you need to load driver, it should detect whether unload driver completed.

Comment 11

[Vincent Chang[:vchang][changyihsin]]

(In reply to Ray REN from comment #9)
> Hi Vincent,
> 
> In our side, this issue is easy to reproduce. And I
> fo"ro.moz.wifi.unloaddriver" is "1", it means we need to unloader driver if
> wifi-off. So could you fixed in gecko? For example  when you need to load
> driver, it should detect whether unload driver completed.
We'll try to turn on ro.moz.wifi.unloaddriver and reproduce the problem again. 
Any reason that you need to unloader driver ?

Comment 12

[Ray REN]

(In reply to Vincent Chang[:vchang] from comment #11)
> We'll try to turn on ro.moz.wifi.unloaddriver and reproduce the problem
> again. 
> Any reason that you need to unloader driver ?

Qualcomm's engineer thought that unloading process is needed for the standard ath6kl release  and they strongly recommend us to unloader driver.

Comment 13

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: Log of STR

For step 2, error message in log:

06-08 02:04:39.669 I/Gecko   (  498): -*- WifiWorker component: Enable Wifi tethering result: netd command error
06-08 02:04:39.679 I/Gecko   (  498): -*- WifiWorker component: 'tethering.wifi.enabled' is now false
06-08 02:04:39.779 I/Gecko   (  498): -*- WifiWorker component: Disable Wifi tethering result: netd command error
06-08 02:04:39.789 I/Gecko   (  498): ########### WifiWorker.js:controlMessage(), command: {"cmd":"unload_driver","id":165}
06-08 02:04:39.799 I/Gecko   (  498): -*- WifiWorker component: 'tethering.wifi.enabled' is now false
06-08 02:04:39.799 I/Gecko   (  498): -*- WifiWorker component: No changes for SETTINGS_WIFI_TETHERING_ENABLED flag. Nothing to do.
06-08 02:04:39.999 I/Gecko   (  498): -*- WifiWorker component: WIFI: unload_driver returned: -1
06-08 02:04:39.999 I/Gecko   (  498): ########## WifiWorker.js:controlWorker.onmessage(), id: 165, data: {"id":165,"status":-1}
06-08 02:04:39.999 I/Gecko   (  498): -*- WifiWorker component: Fail to unload wifi driver

For step 3, error message in log:

06-08 02:05:09.429 I/Gecko   (  498): -*- WifiWorker component: WIFI: start_supplicant returned: -1
06-08 02:05:09.429 I/Gecko   (  498): ########## WifiWorker.js:controlWorker.onmessage(), id: 172, data: {"id":172,"status":-1}
06-08 02:05:09.429 I/Gecko   (  498): ########### WifiWorker.js:controlMessage(), command: {"cmd":"unload_driver","id":173}
06-08 02:05:09.629 I/Gecko   (  498): -*- WifiWorker component: WIFI: unload_driver returned: -1
06-08 02:05:09.629 I/Gecko   (  498): ########## WifiWorker.js:controlWorker.onmessage(), id: 173, data: {"id":173,"status":-1}

Comment 14

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Wait driver load and unload complete before proceed next request.patch

Comment 15

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 789452 [details] [diff] [review]
0001. Wait driver load and unload complete before proceed next request.patch

This is fine for now, but we should really be able to get notified when the driver is fully unloaded. We might have to refactor things a bit, but IMO it'd be worth the effort.

Comment 16

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: (mozilla-central) Wait driver load and unload complete before proceed next request.

Comment 17

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: (mozilla-central) Wait driver load and unload complete before proceed next request.

Add reviewer.

Comment 18

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try : https://tbpl.mozilla.org/?tree=Try&rev=7dc6f2d1b31e

Comment 19

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: (b2g18) Wait driver load and unload complete before proceed next request.

Patch for b2g18

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/ad6260c6e131

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad6260c6e131

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/bd303a2e976e

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/bd303a2e976e

Comment 24

[sbogati]

Issue no longer occurs on Leo device 
 Build ID: 20130827041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/328b3b8158ee
Gaia: 4b2f1a103d046c92d201e8fcfb1ae224f59e7cf1
Platform Version: 18.1
WiFi connecting as expected.No glitches when turning on WIFI