[Buri][WIFI]It is abnormal when turn on WIFI

RESOLVED FIXED in Firefox 26, Firefox OS v1.1hd

Status

Firefox OS
Wifi
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sync-1, Assigned: chucklee)

Tracking

unspecified
1.1 QE5

Firefox Tracking Flags

(blocking-b2g:leo+, firefox24 wontfix, firefox25 wontfix, firefox26 fixed, b2g18 verified, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.171
 Firefox os  v1.1
 Mozilla build ID:20130722070207
 
 DEFECT DESCRIPTION:
 It is abnormal when turn on WIFI
 
 REPRODUCING PROCEDURES:
 1)switch on wifi->select and connect a valid AP->exit the wifi screen;
 2)enter into Internet sharing->turn on wifi hotspot->wait about 1min->the wifi
 hotspot switch off automatically;-->KO1
 3)back to and open wifi->the screen will show "Searching" always and can't
 search anyone AP-->KO2
 Notes:
 the phone can't search anyone AP unless you restart the phone;
 REPRODUCING RATE:  5/5
 
 
 For FT PR, Please list reference mobile's behavior:

Updated

5 years ago
blocking-b2g: --- → leo?

Comment 1

5 years ago
Hi, We find the reason maybe this: When we are unloading driver, via user's  operation, we need to load driver. On this time, the issue also happens.
(Reporter)

Comment 2

5 years ago
Hi,
 
 How to avoid this issue? Do you have solution to fix it?
 
 I think when you need to load driver, it should detect whether unload driver completed.

Comment 3

5 years ago
Not being able to connect to wifi is an awful user experience. leo+ for now.
Assignee: nobody → vchang
blocking-b2g: leo? → leo+
I followed STR in comment 1, but I can't reproduce the problem. 

Gaia commit 271fb7204c3d8c2a52d69e1c0e6aa4d7414b9fa8
Gecko commit 8878e8a4636c58227856ee2b76fc7d95a4cc9709
./config.sh hamachi

Please let me know your Gaia and Gecko commit information.
(In reply to Ray REN from comment #1)
> Hi, We find the reason maybe this: When we are unloading driver, via user's 
> operation, we need to load driver. On this time, the issue also happens.

The unload wifi driver is controlled by ro.moz.wifi.unloaddriver. The default value should be "0" which means not unload drive even if user turns off wifi.

Comment 6

5 years ago
(In reply to Vincent Chang[:vchang] from comment #4)
> 
> Please let me know your Gaia and Gecko commit information.

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.179
Firefox os  v1.1
Mozilla build ID:20130730070228

Comment 7

5 years ago
(In reply to Vincent Chang[:vchang] from comment #5)
> The unload wifi driver is controlled by ro.moz.wifi.unloaddriver. The
> default value should be "0" which means not unload drive even if user turns
> off wifi.

In our side the ro.moz.wifi.unloaddriver is "1". Please tell me how and where can we change this values?

Updated

5 years ago
Flags: needinfo?(vchang)
(In reply to Ray REN from comment #7)
> (In reply to Vincent Chang[:vchang] from comment #5)
> > The unload wifi driver is controlled by ro.moz.wifi.unloaddriver. The
> > default value should be "0" which means not unload drive even if user turns
> > off wifi.
> 
> In our side the ro.moz.wifi.unloaddriver is "1". Please tell me how and
> where can we change this values?
It should be in init.*.rc file of Kernel's Ramfs file system. But I don't think this property is set right now. 

The wifi module read this property in WifiWorker.js.  
http://mxr.mozilla.org/mozilla-central/source/dom/wifi/WifiWorker.js#90
Flags: needinfo?(vchang)

Comment 9

5 years ago
Hi Vincent,

In our side, this issue is easy to reproduce. And I fo"ro.moz.wifi.unloaddriver" is "1", it means we need to unloader driver if wifi-off. So could you fixed in gecko? For example  when you need to load driver, it should detect whether unload driver completed.
(In reply to Ray REN from comment #9)
> Hi Vincent,
> 
> In our side, this issue is easy to reproduce. And I
> fo"ro.moz.wifi.unloaddriver" is "1", it means we need to unloader driver if
> wifi-off. So could you fixed in gecko? For example  when you need to load
> driver, it should detect whether unload driver completed.
We'll try to turn on ro.moz.wifi.unloaddriver and reproduce the problem again. 
Any reason that you need to unloader driver ?

Comment 12

5 years ago
(In reply to Vincent Chang[:vchang] from comment #11)
> We'll try to turn on ro.moz.wifi.unloaddriver and reproduce the problem
> again. 
> Any reason that you need to unloader driver ?

Qualcomm's engineer thought that unloading process is needed for the standard ath6kl release  and they strongly recommend us to unloader driver.
Created attachment 788048 [details]
Log of STR

For step 2, error message in log:

06-08 02:04:39.669 I/Gecko   (  498): -*- WifiWorker component: Enable Wifi tethering result: netd command error
06-08 02:04:39.679 I/Gecko   (  498): -*- WifiWorker component: 'tethering.wifi.enabled' is now false
06-08 02:04:39.779 I/Gecko   (  498): -*- WifiWorker component: Disable Wifi tethering result: netd command error
06-08 02:04:39.789 I/Gecko   (  498): ########### WifiWorker.js:controlMessage(), command: {"cmd":"unload_driver","id":165}
06-08 02:04:39.799 I/Gecko   (  498): -*- WifiWorker component: 'tethering.wifi.enabled' is now false
06-08 02:04:39.799 I/Gecko   (  498): -*- WifiWorker component: No changes for SETTINGS_WIFI_TETHERING_ENABLED flag. Nothing to do.
06-08 02:04:39.999 I/Gecko   (  498): -*- WifiWorker component: WIFI: unload_driver returned: -1
06-08 02:04:39.999 I/Gecko   (  498): ########## WifiWorker.js:controlWorker.onmessage(), id: 165, data: {"id":165,"status":-1}
06-08 02:04:39.999 I/Gecko   (  498): -*- WifiWorker component: Fail to unload wifi driver

For step 3, error message in log:

06-08 02:05:09.429 I/Gecko   (  498): -*- WifiWorker component: WIFI: start_supplicant returned: -1
06-08 02:05:09.429 I/Gecko   (  498): ########## WifiWorker.js:controlWorker.onmessage(), id: 172, data: {"id":172,"status":-1}
06-08 02:05:09.429 I/Gecko   (  498): ########### WifiWorker.js:controlMessage(), command: {"cmd":"unload_driver","id":173}
06-08 02:05:09.629 I/Gecko   (  498): -*- WifiWorker component: WIFI: unload_driver returned: -1
06-08 02:05:09.629 I/Gecko   (  498): ########## WifiWorker.js:controlWorker.onmessage(), id: 173, data: {"id":173,"status":-1}
Assignee: vchang → chulee
Created attachment 789452 [details] [diff] [review]
0001. Wait driver load and unload complete before proceed next request.patch
Attachment #789452 - Flags: feedback?(vchang)
Attachment #789452 - Flags: feedback?(mrbkap)
Comment on attachment 789452 [details] [diff] [review]
0001. Wait driver load and unload complete before proceed next request.patch

This is fine for now, but we should really be able to get notified when the driver is fully unloaded. We might have to refactor things a bit, but IMO it'd be worth the effort.
Attachment #789452 - Flags: feedback?(mrbkap) → feedback+
Created attachment 789997 [details] [diff] [review]
(mozilla-central) Wait driver load and unload complete before proceed next request.
Attachment #789452 - Attachment is obsolete: true
Attachment #789452 - Flags: feedback?(vchang)
Attachment #789997 - Flags: review?(mrbkap)
Attachment #789997 - Attachment description: Wait driver load and unload complete before proceed next request. (for mozilla-central) → (mozilla-central) Wait driver load and unload complete before proceed next request.

Updated

5 years ago
Attachment #789997 - Flags: review?(mrbkap) → review+
Created attachment 790603 [details] [diff] [review]
(mozilla-central) Wait driver load and unload complete before proceed next request.

Add reviewer.
Attachment #789997 - Attachment is obsolete: true
Created attachment 790607 [details] [diff] [review]
(b2g18) Wait driver load and unload complete before proceed next request.

Patch for b2g18
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ad6260c6e131
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-b2g18/rev/bd303a2e976e
status-b2g18: --- → fixed
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → wontfix
status-b2g-v1.1hd: --- → affected
status-firefox24: --- → wontfix
status-firefox25: --- → wontfix
status-firefox26: --- → fixed
Target Milestone: --- → 1.1 QE5

Comment 24

5 years ago
Issue no longer occurs on Leo device 
 Build ID: 20130827041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/328b3b8158ee
Gaia: 4b2f1a103d046c92d201e8fcfb1ae224f59e7cf1
Platform Version: 18.1
WiFi connecting as expected.No glitches when turning on WIFI
status-b2g18: fixed → verified
You need to log in before you can comment on or make changes to this bug.