Closed Bug 901014 Opened 11 years ago Closed 7 years ago

Context menu not appearing on monocle

Categories

(Firefox for Metro Graveyard :: Input, defect, P4)

x86
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: jbecerra, Unassigned)

References

Details

(Whiteboard: [defect] p=0)

Attachments

(1 file)

Tested on 2013-08-02 on latest nightly. While testing bug 863676, I, again, noticed that the context menu doesn't come up when I long tap on a monocle that's been placed inside a text field. The problem could be seen either as not being able to place a plain caret (cursor) or not being able to summon the context menu when there is a monocle.

Steps:
1. Open Firefox Metro
2. Go here https://bug863676.bugzilla.mozilla.org/attachment.cgi?id=785048
3. Tap on any of the text fields and select something with the monocles.
4. Long tap to bring up the context menu, and then tap on Copy
5. Tap elsewhere in the text field
- Notice you get a monocle, and not a plain caret cursor.
6. Long tap on the monocle

Expected: I should see a context menu that allows me to Paste

Actual: Nothing happens on long tap.

If I keep tapping here and there I eventually get a plan caret (without the monocle) and if I long-tap on it, I do get a context menu.

From earlier conversations I think tapping should always place a monocle, so long-tapping should bring up a context menu if I have selected something.
Whiteboard: DUPEME → DUPEME feature=defect c=tbd u=tbd p=0
I noticed that if you long-tap elsewhere, not on the monocle itself, you do get a context menu, but the paste happens at the monocle insertion point.
OS: Mac OS X → Windows 8 Metro
Whiteboard: DUPEME feature=defect c=tbd u=tbd p=0 → [selection] DUPEME feature=defect c=tbd u=tbd p=0
(In reply to juan becerra [:juanb] from comment #0)
> Steps:
> 1. Open Firefox Metro
> 2. Go here https://bug863676.bugzilla.mozilla.org/attachment.cgi?id=785048
> 3. Tap on any of the text fields and select something with the monocles.
> 4. Long tap to bring up the context menu, and then tap on Copy
> 5. Tap elsewhere in the text field
> - Notice you get a monocle, and not a plain caret cursor.

Up to this point, you're seeing correct behavior. The caret monocle should always come up.

> 6. Long tap on the monocle
> 
> Expected: I should see a context menu that allows me to Paste
> 
> Actual: Nothing happens on long tap.

I can reproduce this. The caret image is over in chrome, so it's getting in the way of the long-tap context-menu event generation, which happens down in content. One way of fixing this might be to put a context-menu listener on the monocle images.
Whiteboard: [selection] DUPEME feature=defect c=tbd u=tbd p=0 → [selection][shovel-ready] feature=defect c=tbd u=tbd p=0
Priority: -- → P1
Blocks: caret-sel
Whiteboard: [selection][shovel-ready] feature=defect c=tbd u=tbd p=0 → [selection][shovel-ready] feature=defect u=metro_firefox_user c=content_features p=0
Whiteboard: [selection][shovel-ready] feature=defect u=metro_firefox_user c=content_features p=0 → [preview-triage] [selection] [shovel-ready] feature=defect u=metro_firefox_user c=content_features p=0
Whiteboard: [preview-triage] [selection] [shovel-ready] feature=defect u=metro_firefox_user c=content_features p=0 → [preview] [selection] [shovel-ready] feature=defect u=metro_firefox_user c=content_features p=0
Summary: defect - context menu not appearing on monocle → [MP] Defect - context menu not appearing on monocle
Blocks: metrov1backlog
No longer blocks: metrov1defect&change
Assignee: nobody → jmathies
Whiteboard: [preview] [selection] [shovel-ready] feature=defect u=metro_firefox_user c=content_features p=0 → [preview] [selection] [shovel-ready] feature=defect u=metro_firefox_user c=content_features p=1
Blocks: metrov1it13
No longer blocks: metrov1backlog
Status: NEW → ASSIGNED
QA Contact: jbecerra
Component: General → Input
So it turns out that this is default metro app behavior. If you have the soft keyboard up and a monocle displayed in a text input, and you long tap in the area of the caret focus, winrt doesn't generate right tapped event.

I tested in Mail and in IE, and I see the same behavior.

What IE does is bring up the paste context menu if you tap once to display the monocle, then tap again on the monocle. This behavior is pretty wonky and hard to control, so I think we need to come up with our own interaction.

I like the idea of a context app bar for cut/copy/paste/select.
Assignee: jmathies → nobody
No longer blocks: metrov1it13, MetroPreviewRelease
Whiteboard: [preview] [selection] [shovel-ready] feature=defect u=metro_firefox_user c=content_features p=1 → [preview-triage]feature=defect u=metro_firefox_user c=content_features p=1
Summary: [MP] Defect - context menu not appearing on monocle → Defect - context menu not appearing on monocle
Whiteboard: [preview-triage]feature=defect u=metro_firefox_user c=content_features p=1 → [preview-triage]feature=defect u=metro_firefox_user c=content_features p=0
Attached file testing patch
Status: ASSIGNED → NEW
QA Contact: jbecerra
Blocks: metrov2defect&change
No longer blocks: metrov1backlog
Fixing this requires revisiting how users interact with content and how we provide cut/copy/paste support.
Whiteboard: [preview-triage]feature=defect u=metro_firefox_user c=content_features p=0 → [fx27-triage]
No longer blocks: metrov2defect&change
Summary: Defect - context menu not appearing on monocle → Context menu not appearing on monocle
Whiteboard: [fx27-triage] → [defect] p=0
Whiteboard: [defect] p=0 → [defect] p=0 [selection]
Blocks: 957244
No longer blocks: caret-sel
OS: Windows 8 Metro → Windows 8.1
Whiteboard: [defect] p=0 [selection] → [defect][needs-ux] p=0
per comment 4, this needs feedback from ux.
Priority: P1 → --
Priority: -- → P2
Hi Michael, please see comment 4 if any design work will be required beforehand.
Flags: needinfo?(mmaslaney)
Marco, design work will be required.
Flags: needinfo?(mmaslaney)
Depends on: 966274
Whiteboard: [defect][needs-ux] p=0 → [defect] p=0
Priority: P2 → P4
Mass close of bugs in obsolete product https://bugzilla.mozilla.org/show_bug.cgi?id=1350354
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: