901071 - [8.1] D2D rendering always being disabled for Windows 8.1 on Intel hardware

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Brian R. Bondy [:bbondy]]

I recently upgraded to Windows 8.1 and noticed a problem.
I noticed that D2D i always being disabled on my machine.

I noticed that the reason D2D is getting disabled is not to a specific blocked driver,
but because the version number on the dll vs the driver is different.
( See http://dxr.mozilla.org/mozilla-central/source/widget/windows/GfxInfo.cpp#l502 )
Driver version: "9.18.10.3200" DLL version:9.17.10.3200

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1

- With intel hardware, a standard win8 installation upgraded to win8.1 always get blacklisted due to the check which is modified in this patch.
- I think the past 2 crashes were with version 18.* versions of the hardware. I'm not certain that 19.* is safe in every version but it seem fine on my machine. And we can watch crash data to see if anything shows up after this change. 
- I know the 2 if statements can be combined but I think it's more readable this way.

Comment 2

[Brian R. Bondy [:bbondy]]

- 8.* versions of the hardware
_ 8.* versions of the DLL and driver

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 785148 [details] [diff] [review]
Patch v1

Review of attachment 785148 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/GfxInfo.cpp
@@ +505,5 @@
> +      // above comment about crashes with old mismatches. If the GetDllVersion
> +      // call fails, then they return 0, so that will be considered a mismatch.
> +      if (driverNumericVersion < knownSafeMismatchVersion ||
> +          (dllNumericVersion < knownSafeMismatchVersion &&
> +           dllNumericVersion2 < dllNumericVersion2)) {

There seems to be a typo here: dllNumericVersion2 < dllNumericVersion2   (always false).

Also consider simplifying this into an condition of the form:

  max(a, b) < c

?

Comment 4

[Brian R. Bondy [:bbondy]]

Attachment: Patch v2.

Comment 5

[reekotubbs]

Was the patch successful?

Comment 6

[Brian R. Bondy [:bbondy]]

It enables d2d after this patch ya, which is the same effect as the old force d2d option that we set.

Comment 7

[reekotubbs]

can i do it manually or how to apply the patch without rebuild?

Comment 8

[Brian R. Bondy [:bbondy]]

it should land soon after review, and then you can get a nightly build.  A couple days. Otherwise you'd have to build yourself after applying the patch. For that, see:
https://wiki.mozilla.org/Firefox/Windows_8_Integration

Comment 9

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/94c38c3b3b17

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/94c38c3b3b17