Closed Bug 9029 Opened 27 years ago Closed 27 years ago

[DOGFOOD] DOM events with anonymous nodes as targets should not bubble up to non-anonymous nodes

Categories

(Core :: XUL, defect, P3)

x86
Other
defect

Tracking

()

VERIFIED INVALID

People

(Reporter: hyatt, Assigned: waterson)

References

Details

(Whiteboard: [PDT+])

We need to add checks in our DOM to prevent events on anonymous nodes from bubbling out into the parent document. This is going to be tricky, since in some cases we want the nearest enclosing non-anonymous node to receive the event and in other cases we don't. I'm not sure how to solve this problem.
Status: NEW → ASSIGNED
Target Milestone: M9
Target Milestone: M9 → M10
*** Bug 10135 has been marked as a duplicate of this bug. ***
Blocks: 11091
adding myself to cc: list. ckritzer - when this is fixed, can you remind me so I can verify the mail specific case cited in the duplicate bug? Thanks. (adding the dependency that the duplicate bug had)
This is already implemented for all my anonymoums nodes. They will not bubble any events up past a parent who is not an anonymous node. I created an interface called nsIAnonymousContent that any anonymous content should implement so it can be determined if it is anonymous or not.
Hmm. So you're using QueryInterface() to detect if content is anonymous? This seems bad. Requires you to create a new static type for each kind of anonymous content. IMO nsIAnonymousContent should have "SetAnonymous()" and "IsAnonymous()" methods. This allows the content creator to decide when the content is anonymous (and would, for example, allow us to re-use existing implementation instead of one-offing each). Also, Hyatt: didn't you say you wanted twisty clicks to bubble in the tree control?
YEah. I want the freedom to mark and unmark something as anonymous
its easy enough to add a boolean accessor to see if a node is anonymous if thats the right approach.
Target Milestone: M10 → M11
moving to m11
My hands have deteriorated to the point where I can no longer type. I need help. If you think you can fix this bug on your own, please take it away from me. If you'd like to volunteer to be my hands for a specific bug, then I'll be happy to come up to your cube and sit with you and fix the bug (assuming you have the patience for that).
*** Bug 13456 has been marked as a duplicate of this bug. ***
Summary: DOM events with anonymous nodes as targets should not bubble up to non-anonymous nodes → [DOGFOOD] DOM events with anonymous nodes as targets should not bubble up to non-anonymous nodes
Target Milestone: M11 → M10
This is seriously important. Pulling in.
Target Milestone: M10 → M11
after talking with hyatt moved back to m11. let me know if this changes.
Whiteboard: [PDT+]
Putting on [PDT+]
Assignee: hyatt → waterson
Status: ASSIGNED → NEW
reassigning to waterson per hyatt
Status: NEW → ASSIGNED
Target Milestone: M11 → M12
is this still seriously important? what is breaking because of it?
My duplicate bug says that "Moving the scroll bar in the Folder sidebar clears out the thread pane" (mail) happens. However, that is a fairly old reported bug. I'll check in the more recent builds and let you know.
The mail scenario I reported in the duplicate bug 10135 is working in 1999-11-05-09 build on Win32.
so lchiang, is this bug bogus? hyatt? anyone?
waterson, I don't know about the bug as originally reported by hyatt. I know that my bug which was marked a duplicate of this one is fixed. I don't know how this bug manifests itself in any other way besides the mail case I stated. Perhaps you should mark this bug fixed and let the QA contact, ckritzer, do the verification.
Status: ASSIGNED → RESOLVED
Closed: 27 years ago
Resolution: --- → INVALID
Marking INVALID. If anyone disagrees, reopen and tell me what I need to do.
Status: RESOLVED → VERIFIED
Marking VERIFIED INVALID. There's no testcase associated with this, and lchiang has noted her dup bug is working.
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL. XUL component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: ckritzer → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.