903637 - CTP icon disappears on mouse hover on retina displays

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[:Felipe Gomes (needinfo for replies!)]

STR
 - open a page with Flash
 - hover over CTP blue icon in the urlbar

Result: icon disappears while mouse is over it

Comment 1

[:Felipe Gomes (needinfo for replies!)]

If this is not an obvious dupe I'd bet it only affects Firefox running on a Mac retina screen

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: mouse-over-plugin-icon.png

Comment 3

[Georg Fritzsche [:gfritzsche]]

(In reply to :Felipe Gomes from comment #1)
> If this is not an obvious dupe I'd bet it only affects Firefox running on a
> Mac retina screen

It's fine for me on a non-retina screen, so it's possible.

Comment 4

[Georg Fritzsche [:gfritzsche]]

Attachment: testcase

I have no idea what could be causing this, a regression window would be great.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Last good nightly: 2013-07-19
First bad nightly: 2013-07-20

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=af4e3ce8c487&tochange=bf73e10f5e54

Comment 6

[Georg Fritzsche [:gfritzsche]]

Thanks :)

Candidates: bug 888292, bug 889788, bug 888908.
Likely suspect: bug 888292, which touched the style and icons for @2x themes.

Comment 7

[Georg Fritzsche [:gfritzsche]]

Attachment: testcase

With layout.css.devPixelsPerPx;2 i can reproduce this for the non-hidden plugin case.
For non-"hidden" plugins, it ends up using the old blue plugin icon instead of the new, grey and flat, plugin icon.

Comment 8

[Georg Fritzsche [:gfritzsche]]

Attachment: Remove outdated 2dppx icon style

Looks like this is just being overwritten by a left-over & outdated 2dppx section.

Comment 9

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 789002 [details] [diff] [review]
Remove outdated 2dppx icon style

Jaws, can you review this?

What happened here is that bug 888292 added a 2dppx list-style-image for #plugins-notification-icon at [1] but left an old one that overrides it at. This just removes the second, outdated, occurence.

[1] http://hg.mozilla.org/mozilla-central/annotate/9ab28833eda0/browser/themes/osx/browser.css#l3198
[2] http://hg.mozilla.org/mozilla-central/annotate/9ab28833eda0/browser/themes/osx/browser.css#l3259

Comment 10

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0525bc05b74

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c0525bc05b74

Comment 12

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 789002 [details] [diff] [review]
Remove outdated 2dppx icon style

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Plugin-doorhanger redesign.
User impact if declined: Visual only, plugin notification icon vanishing on mouse-over.
Testing completed (on m-c, etc.): on m-c for a while without incidents
Risk to taking this patch (and alternatives if risky): Very low, visual only removal of duplicate definition
String or IDL/UUID changes made by this patch: None.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/161391951245

Comment 14

[u279076]

Matt, can you please verify this is fixed?

Comment 16

[Matt Wobensmith [:mwobensmith][:matt:]]

Confirmed broken on FF25 2013-08-01.
Verfied fixed on FF25, FF26 2013-09-23.