Closed Bug 905051 Opened 11 years ago Closed 11 years ago

[Buri][TOR][Keyboard]missing hungarian SMS characters: ö, ő, ü, ű

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Type:
defect

Tracking

(blocking-b2g:leo+, b2g18 verified)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- verified

People

(Reporter: sync-1, Assigned: kami911)

References

Details

(Whiteboard: NO_UPLIFT)

Attachments

(2 files)

Adding őŐűŰ to the English keyboard
453 bytes, patch
Details | Diff | Splinter Review
pull-request.html
466 bytes, text/html
rudyl
: review+
Details 
AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.184
 Firefox os  v1.1
 Mozilla build ID:20130806071254
 
 
 DEFECT DESCRIPTION:
  missing hungarian SMS characters: ö, ő, ü, ű
  REPRODUCING PROCEDURES:
  missing hungarian SMS characters: ö, ő, ü, ű
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
  Mid
  REPRODUCING RATE:
  5/5
  For FT PR, Please list reference mobile's behavior:
blocking-b2g: --- → leo?
Tim - we think we have to block here to support these languages - can you assign?
Assignee: nobody → timdream
blocking-b2g: leo? → leo+
Summary: [Buri][Keyboard]missing hungarian SMS characters: ö, ő, ü, ű → [Buri][TOR][Keyboard]missing hungarian SMS characters: ö, ő, ü, ű
(In reply to comment #1)
 > Comment from Mozilla:Tim - we think we have to block here to support these
 > languages - can you assign?
 > 
 
 Hi,
 
 what is latest status on this today?
 
 Thanks in advance
 Best regards
 Daygina
(In reply to lsblakk@mozilla.com [:lsblakk] from comment #1)
> Tim - we think we have to block here to support these languages - can you
> assign?

Please use needinfo instead of assignee.

Rudy, could you re-assign?
Assignee: timdream → nobody
Flags: needinfo?(rlu)
Whiteboard: [good first bug][mentor=timdream][mentor=rudyl]
This is a good first bug because it's probably a two line patch once you figured out where layout.js is and tested it.
I don't think we have enough info to start working on this.
 1. What language are we talking about here, Hungarian?
    AFAIK, we don't have a Hungarian keyboard layout.

 2. If we want to add Hungarian layout, we might need some Hungarian l10n expert to suggest all the diacritics we need for Hungarian.
Flags: needinfo?(rlu) → needinfo?(lsblakk)
:lsblakk,

Do you know who should I talk to to get the questions in Comment 5 clear?
Thanks.
In that case let's loop in L10n folks, but I'm not the one who can get that information.  If we're shipping Hungarian in v1.1 (hence the blocking) then there must be a keyboard layout for this to apply to.  If not then this bug is not a blocker.  Adding in Product team to confirm.
Flags: needinfo?(lsblakk)
Flags: needinfo?(l10n)
Flags: needinfo?(ffos-product)
Flags: needinfo?(community)
We intend to ship Hungarian in 1.1.

Kami, do you happen to know someone that could help with a keyboard layout? Also, what keyboard are you guys using on the dogfood devices right now?
Flags: needinfo?(l10n)
Flags: needinfo?(kami911)
Flags: needinfo?(community)
Looking further into this on the latest Leo v1.1 Com RIL
Gaia   849cee8a3ee5a2a6f4e39183549d36c3acc05f2f
BuildID 20130820041204
Version 18.1

It seems like there are also some missing characters in other v1.1 shipping locales: special Czech characters are missing, in Greek it's missing one of the Υ ('ΎΫ), in Croatian (đ), and in Romanian there are 2 missing (ț and ș)

Strange that this has not been identified sooner. Should we file another bug for the above? Let me know if you need any specific testing around this.

Shipping locales for v1.1 can be found here BTW: https://l10n.mozilla.org/shipping/dashboard?tree=gaia
Hi, this story based on 1.1hd (20130814) running on Peak:
1) Disabling all layouts in Settings - Keyboard
I can enter üÜöÖ (this is good) but I cannot enter őŐűŰ (this is bad). This is a bug. I am attaching a patch for this here. Please validate it.

2) Enable English keyboard in Settings- Keyboard
Same happen as in 1)

3) When I enable (Other Latin scripts) Más latin írások then the first language will be the Česká which does not contain to much special character. I think the report cover this case. The one can select keyboard language via "globe" symbol of keyboard.

4) When I enable English AND Other Latin scripts the English will be the first so this case is same as 1).

Conclusion: we should enforce to always use English first or even better to assign default keyboard to Hungarian language.
Flags: needinfo?(kami911)
Attaching a trivial patch to add missing chars to the English keyboard. Not tested at all.
Blocks: 907597
QA Contact: kami911
No longer blocks: 907597
Created bug 907597 and attaching proposed Hungarian keyboard layout. (I am removing blocking status of 907597, that was a mistake :o) )
If we want to add a separate Hungarian keyboard layout, we also need to add a new string for the setting entry to enable/disable Hungarian layout.

However, I think we already get string freeze for v1.1?
(In reply to Rudy Lu [:rudyl] from comment #13)
> However, I think we already get string freeze for v1.1?

I think we're way past that.

I'm wondering if it makes sense to extend the en-US keyboard with those characters (see comment 9) for v1-train and fix it completely with a true keyboard layout on master.
Ah, I forgot that we have a setting entry, "Other Latin scripts", which will enable multiple keyboard layouts at once.

If we make Hungarian layout be included in "Other Latin scripts", then I guess we can add this new layout without introducing new strings.
(In reply to delphine from comment #9)
> Looking further into this on the latest Leo v1.1 Com RIL
> Gaia   849cee8a3ee5a2a6f4e39183549d36c3acc05f2f
> BuildID 20130820041204
> Version 18.1
> 
> It seems like there are also some missing characters in other v1.1 shipping
> locales: special Czech characters are missing, in Greek it's missing one of
> the Υ ('ΎΫ), in Croatian (đ), and in Romanian there are 2 missing (ț and ș)
> 
> Strange that this has not been identified sooner. Should we file another bug
> for the above? Let me know if you need any specific testing around this.
>

Please do file the bugs for what we need to support in v1.1.
As far as I know, we don't have Croatian, Romanian (only on master) in v1.1.
  
> Shipping locales for v1.1 can be found here BTW:
> https://l10n.mozilla.org/shipping/dashboard?tree=gaia

I created the following document back in May 2013 to track this part and pinged someone about which keyboard layouts to support,
https://intranet.mozilla.org/B2GKeyboardLayout-v1

Do you know who should be tracking this part?
(In reply to Rudy Lu [:rudyl] from comment #16)
> (In reply to delphine from comment #9)
> 
> 
> Please do file the bugs for what we need to support in v1.1.
> As far as I know, we don't have Croatian, Romanian (only on master) in v1.1.
>   

Again, we need to support all locales listed on https://l10n.mozilla.org/shipping/dashboard?tree=gaia
for v1.1. Let me know if you need a bug on file for that

We have had multiple discussions about shipping locales for v1.1 so I am quite sure that we need to provide support for these ;)
thanks!
Opened Bug 907763 in order to get keyboard characters for all v1.1 locales
(In reply to Rudy Lu [:rudyl] from comment #16)
> (In reply to delphine from comment #9)
> I created the following document back in May 2013 to track this part and
> pinged someone about which keyboard layouts to support,
> https://intranet.mozilla.org/B2GKeyboardLayout-v1
> 
> Do you know who should be tracking this part?

Sorry, I have no idea.

However please note that we are going to move away from https://intranet.mozilla.org/Program_Management/Firefox_OS/Localization as a point of reference for l10n coverage (I see it's cited at the top of https://intranet.mozilla.org/B2GKeyboardLayout-v1 . It actually contained incorrect information there until recently, and was not maintained correctly.
Sorry, I can not reach intranet documents, however I attached patch for English keyboard, maybe we can add more chars such way to English layout too. Hungarian keyboard is here: 907597
Should I test it somehow (building a new Gaia based on 1.1)?
(In reply to delphine from comment #9)
> Looking further into this on the latest Leo v1.1 Com RIL
> Gaia   849cee8a3ee5a2a6f4e39183549d36c3acc05f2f
> BuildID 20130820041204
> Version 18.1
> 
> It seems like there are also some missing characters in other v1.1 shipping
> locales: special Czech characters are missing, in Greek it's missing one of
> the Υ ('ΎΫ), in Croatian (đ), and in Romanian there are 2 missing (ț and ș)
> 
> Strange that this has not been identified sooner. Should we file another bug
> for the above? Let me know if you need any specific testing around this.
> 

The Romanian characters have been added by the patch for bug 886628 in a new keyboard layout. However, due to the difference between the current keyboard layouts logic on master (each language has its own keyboard layout) and the one on v1-train (a bunch of keyboards grouped in otherLatins), I'm not sure that can be uplifted (if leo relevant) without some restructuring (i.e. including it in otherLatins).

Delphine, feel free to request leo on bug 886628 and I can take care of making the respective patch v1-train compatible.
Awesome, thanks Mihai!
Whiteboard: [good first bug][mentor=timdream][mentor=rudyl]
Pull request is here: https://github.com/mozilla-b2g/gaia/pull/11713
Hi, in order to incorporate this change and add more keyboard layouts for v1.1, I have incorporate this change to Gaia master first.

Pushed to Gaia master,
a64fdfaffce59a04dc11e1c97a8fe13fcfde0d4b

--
Please don't uplift this change, since it definitely will cause conflict.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: NO_UPLIFT
Attached file pull-request.html — 
No longer depends on: 908286

    
    

    
  
Comment on attachment 794625 [details]
pull-request.html

This patch will be uplifted to v1-train with the patch in Bug 907763.
Thanks.

        Attachment #794625 -
        Flags: review+

    
    

    
  
(In reply to Rudy Lu [:rudyl] from comment #28)
> The patch for Bug 907763 has landed to v1-train: 
> https://github.com/mozilla-b2g/gaia/commit/
> c39e93105bbeb593e392705ed16ef040769698e8

Hi, which mozilla Build ID will contain this patch for v1.1? Thanks!

    
    

    
  
Issue no longer reproduces on Leo device.
Build ID: 20130828041203
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/c3b4683d136
Gaia: 518178ca234c98eb1ca0c0997b9d59faea640a85
Platform Version: 18.1
RIL Version: 01.01.00.019.205
Showing Hungarian SMS characters: ö, ő, ü, ű

          status-b2g18:
          fixed → verified
Flags: needinfo?(ffos-product)

    
  
Assignee: nobody → kami911

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: