905072 - non-public application returned by the export API

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P1)

Description

[nati]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.95 Safari/537.36

Steps to reproduce:

Download the latest prod app dump from:
https://marketplace.cdn.mozilla.net/dumped-apps/tarballs/2013-08-13.tgz


Actual results:

found /apps/420/420476.json ('youzeek-free-music-streaming') in the dump, which is a non-public application:
https://marketplace.firefox.com/api/v1/apps/app/420476/?format=JSON


Expected results:

1. This app should be public
OR
2. This app shouldn't been exported
OR
3. The Export documentation should be amended

Comment 1

[David Bialer [:dbialer]]

This is important to fix as it allows people to access things that they should not be allowed to.

Comment 2

[Allen Short [:ashort]]

We were not deleting old exported apps when constructing a new tarball. Thus, apps that were once public remain in later exports even if made non-public later.

https://github.com/mozilla/zamboni/commit/433c5f2d

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Nati, can you verify this in the latest dump?

Comment 6

[Mathieu Pillard [:mat]]

Please wait for tomorrow's dump to test - the one for 2013-10-29 was generated before the push containing the fix.

Comment 7

[nati]

(In reply to Ran Ben Aharon (Everything.me) from comment #5)
> Nati, can you verify this in the latest dump?

The latest dumps seem OK, no broken or private apps.
Thanks!