905558 - [Bluetooth] HFP PTS test cases TC_AG_TWC_BV_03_I & TC_AG_TWC_BV_05_I fails (test cases for CHLD=2 and CHLD=1)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

HFP PTS test case TC_AG_TWC_BV_03_I examines "CHLD=2" command that puts current active call on hold and held call active. During test gecko bluetooth sends command to gaia dialer but doesn't get expected call state changes. Require Gaia dialer app revise the call holding/answering flow.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/11544

`holdAndAnswer` should handle only the case of there exists a connected call and an incoming call. In the other case we should use `toggleCalls`.

Etienne, could you help review the change? Thanks!

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 790682 [details]
link to https://github.com/mozilla-b2g/gaia/pull/11544

`endAndAnswer` is also affected. This bug was regressed by bug 895226. The patch of bug 895226 assumes that the active call is the last one but which is wrong.

Cancel the review at first.

Comment 3

[Ben Tian (inactive)]

Rename bug title. Both test cases TC_AG_TWC_BV_03_I and TC_AG_TWC_BV_05_I are affected by bug 895226.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Nominate for leo+ as it fails the BT certification test cases.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 790682 [details]
link to https://github.com/mozilla-b2g/gaia/pull/11544

The patch respects to the telephony.active if exists. If telephony.active is null, it fallbacks to a proper call object. In the case of `holdAndAnswer`, it answers the last call. And in the case of `endAndAnswer`, it hangs up the previous call. Etienne, could you help review the patch? Thanks!

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 790682 [details]
link to https://github.com/mozilla-b2g/gaia/pull/11544

The change makes sense, r- for the failing tests.
Some nits on github.

|calls_handler.js|'s unit-test coverage is now descent. Which means that you can update and add tests for your change (yay!).

I've also CC'ed you on bug 902994, I think it would greatly help with BT certification.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 790682 [details]
link to https://github.com/mozilla-b2g/gaia/pull/11544

Etienne, thanks for reviewing! I've added the test cases and addressed the comments. Could you help take a look at it again?

Comment 8

[Ben Tian (inactive)]

Arthur, the following lists commands from gecko bluetooth to dial app:

--
ATA
  Answer call.
CHUP
  Hang-up call.
BLDN
  Call the last phone number dialed. BLDN stands for Bluetooth Last Dial Number.
ATD>nnn...
  Call the n-th last phone number dialed. n=1 is the same as BLDN.
ATDdd...dd
  Call phone number dd...dd.
VTS=<DTMF>
  Generate DTMF sound of <DTMF>.
CHLD=0
  Release all held calls or sets user determined user busy (DDUB) for a waiting call.
CHLD=1 (CHUP+ATA in b2g18)
  Release all active calls (if any exist) and accept the other (held or waiting) call.
CHLD=2 (CHLD+ATA in b2g18)
  Place all active calls (if any exist) on hold and accept the other (held or waiting) call.

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 790682 [details]
link to https://github.com/mozilla-b2g/gaia/pull/11544

Almost there! Comments on github, all test-related.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 790682 [details]
link to https://github.com/mozilla-b2g/gaia/pull/11544

Comments addressed. Thanks!

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 790682 [details]
link to https://github.com/mozilla-b2g/gaia/pull/11544

All good, thanks you for the clean work!

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks Etienne!

master: https://github.com/mozilla-b2g/gaia/commit/18fbbb23111ca4e7c43816ebeef729e6444a1457

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1-train: https://github.com/mozilla-b2g/gaia/commit/3bd5c3b4ac36be37b0127e1dd6293fbf2890072d

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 3bd5c3b4ac36be37b0127e1dd6293fbf2890072d

Comment 15

[Hubert Lu[:hlu] <[e-mail]>]

This issue was verified in below vesion of Unagi, and the result is passed.

Gaia:     9fb5802df60a9081846d704def01df814ed8fbd4
  B-D     2013-09-01 02:12:02
Gecko:    7f9a1195fb6f3b51ad9200ac995d4ff8eb7a4939
BuildID   20130902060051
Version   26.0a1