906884 - Update Fennec's ContentProvider meta-data for next-gen Sync

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Nick Alexander :nalexander [he/him]]

New Sync should expose check-boxes in the Android Settings app for the four MVP datatypes: Bookmarks, Passwords, History, and Tabs.

This could be a little awkward, since I think the check-boxes are per backing ContentProvider, and we have one BrowserProvider exposing both bookmarks and history.  We could add dummy {Bookmarks|History}Providers, or add just one dummy provider; or overload FormHistoryProvider to mean "history" as a whole".  (There is no restriction on accessing data in just the checked providers.)

In any case, we should set the android:label and android:icon appropriately for the relevant CPs.

Comment 1

[Richard Newman [:rnewman]]

There's an impedance mismatch here f'sho. I think perhaps we should revisit whether matching granularity in Android Settings is worth the difficulty, especially given that service selection will complicate this anyway.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Set Fennec ContentProvider android:label meta-data for next-gen Sync.

These titles show up in the list of things to Sync in Android Settings
> Accounts and Sync > [account].

I'd like to pursue the multiple Sync Adapter direction; I expect that
it will be the best way to get the system notifications and resulting
responsiveness we want for New Sync.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 793116 [details] [diff] [review]
Set Fennec ContentProvider android:label meta-data for next-gen Sync.

Review of attachment 793116 [details] [diff] [review]:
-----------------------------------------------------------------

Got a screenshot?

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Sync settings screen shot

Comment 5

[Richard Newman [:rnewman]]

As we discussed this afternoon: this has some impact on the user experience for the current Sync account type. There are ways to mitigate that, so please spend some time to do so.

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 793116 [details] [diff] [review]
Set Fennec ContentProvider android:label meta-data for next-gen Sync.

Review of attachment 793116 [details] [diff] [review]:
-----------------------------------------------------------------

Please file a bug, blocking appropriate user story, needinfo for UI to determine what we call these in the final cut…

Comment 7

[Richard Newman [:rnewman]]

See also: Bug 915295.

Comment 8

[Nick Alexander :nalexander [he/him]]

(In reply to Richard Newman [:rnewman] from comment #6)
> Comment on attachment 793116 [details] [diff] [review]
> Set Fennec ContentProvider android:label meta-data for next-gen Sync.
> 
> Review of attachment 793116 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please file a bug, blocking appropriate user story, needinfo for UI to
> determine what we call these in the final cut…

Filed Bug 916290.

Comment 9

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/projects/elm/rev/ee798af61816

Comment 10

[James Bonacci [:jbonacci]]

Same comment here: Let me know when you have something you want me to look at.

Comment 11

[Richard Newman [:rnewman]]

IIRC we're now resolving bugs that hit elm. Nick?

Comment 12

[Nick Alexander :nalexander [he/him]]

(In reply to Richard Newman [:rnewman] from comment #11)
> IIRC we're now resolving bugs that hit elm. Nick?

I have been marking [fixed in elm] but not RESO ASSIGNED or FIXED. I think we should continue to follow {fx-team,m-i,...} standard and only resolve on merge.

Comment 13

[Richard Newman [:rnewman]]

(In reply to Nick Alexander :nalexander from comment #12)

> I have been marking [fixed in elm] but not RESO ASSIGNED or FIXED. I think
> we should continue to follow {fx-team,m-i,...} standard and only resolve on
> merge.

cf Bug 913199 and friends…

Comment 14

[James Bonacci [:jbonacci]]

OK. I can review an ELM build on Android.

Comment 15

[Nick Alexander :nalexander [he/him]]

To QA this, we'll need to be able to add an "FxAccount" Android account.  I think you can create a dummy account (always called [e-mail] or similar), and I think you'll see 4 checkboxes in the Android Sync & Accounts page for this account.  They should read Bookmarks, History, Passwords, and Tabs.  This ticket is landing those strings.

Testing this is low value.

Comment 16

[James Bonacci [:jbonacci]]

Got it. Thanks. Will wait for a more fully defined Android client to mess with...

Comment 17

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/ee798af61816

Comment 18

[James Bonacci [:jbonacci]]

Cleaning up Resolved/Fixed bugs from December's first release.
Verified that we now have a working first-release of FxA to Desktop/Android Nightly.
Re-open as needed.