Closed Bug 906884 Opened 7 years ago Closed 7 years ago

Update Fennec's ContentProvider meta-data for next-gen Sync

Categories

(Firefox for Android :: Android Sync, defect)

All
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

(Whiteboard: [qa+][fixed in elm])

Attachments

(2 files)

New Sync should expose check-boxes in the Android Settings app for the four MVP datatypes: Bookmarks, Passwords, History, and Tabs.

This could be a little awkward, since I think the check-boxes are per backing ContentProvider, and we have one BrowserProvider exposing both bookmarks and history.  We could add dummy {Bookmarks|History}Providers, or add just one dummy provider; or overload FormHistoryProvider to mean "history" as a whole".  (There is no restriction on accessing data in just the checked providers.)

In any case, we should set the android:label and android:icon appropriately for the relevant CPs.
Whiteboard: [qa+]
There's an impedance mismatch here f'sho. I think perhaps we should revisit whether matching granularity in Android Settings is worth the difficulty, especially given that service selection will complicate this anyway.
These titles show up in the list of things to Sync in Android Settings
> Accounts and Sync > [account].

I'd like to pursue the multiple Sync Adapter direction; I expect that
it will be the best way to get the system notifications and resulting
responsiveness we want for New Sync.
Attachment #793116 - Flags: review?(rnewman)
Comment on attachment 793116 [details] [diff] [review]
Set Fennec ContentProvider android:label meta-data for next-gen Sync.

Review of attachment 793116 [details] [diff] [review]:
-----------------------------------------------------------------

Got a screenshot?
As we discussed this afternoon: this has some impact on the user experience for the current Sync account type. There are ways to mitigate that, so please spend some time to do so.
Comment on attachment 793116 [details] [diff] [review]
Set Fennec ContentProvider android:label meta-data for next-gen Sync.

Review of attachment 793116 [details] [diff] [review]:
-----------------------------------------------------------------

Please file a bug, blocking appropriate user story, needinfo for UI to determine what we call these in the final cut…
Attachment #793116 - Flags: review?(rnewman) → review+
(In reply to Richard Newman [:rnewman] from comment #6)
> Comment on attachment 793116 [details] [diff] [review]
> Set Fennec ContentProvider android:label meta-data for next-gen Sync.
> 
> Review of attachment 793116 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please file a bug, blocking appropriate user story, needinfo for UI to
> determine what we call these in the final cut…

Filed Bug 916290.
See Also: → 916290, 915295
https://hg.mozilla.org/projects/elm/rev/ee798af61816
Status: NEW → ASSIGNED
Whiteboard: [qa+] → [qa+][fixed in elm]
Same comment here: Let me know when you have something you want me to look at.
IIRC we're now resolving bugs that hit elm. Nick?
(In reply to Richard Newman [:rnewman] from comment #11)
> IIRC we're now resolving bugs that hit elm. Nick?

I have been marking [fixed in elm] but not RESO ASSIGNED or FIXED. I think we should continue to follow {fx-team,m-i,...} standard and only resolve on merge.
(In reply to Nick Alexander :nalexander from comment #12)

> I have been marking [fixed in elm] but not RESO ASSIGNED or FIXED. I think
> we should continue to follow {fx-team,m-i,...} standard and only resolve on
> merge.

cf Bug 913199 and friends…
OK. I can review an ELM build on Android.
To QA this, we'll need to be able to add an "FxAccount" Android account.  I think you can create a dummy account (always called test@test.com or similar), and I think you'll see 4 checkboxes in the Android Sync & Accounts page for this account.  They should read Bookmarks, History, Passwords, and Tabs.  This ticket is landing those strings.

Testing this is low value.
Got it. Thanks. Will wait for a more fully defined Android client to mess with...
https://hg.mozilla.org/mozilla-central/rev/ee798af61816
Assignee: nobody → nalexander
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Cleaning up Resolved/Fixed bugs from December's first release.
Verified that we now have a working first-release of FxA to Desktop/Android Nightly.
Re-open as needed.
Status: RESOLVED → VERIFIED
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.