915295 - Split BrowserProvider into History and Bookmarks

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[Richard Newman [:rnewman]]

This is a distinction we probably want for Sync.next; it would allow for accurate change notifications and correct checkbox names in Settings (see Bug 808813).

For the current codebase I'd split, keep one (history) named "Browser", and keep only that one registered for syncing with the 1.1 SyncAdapter. In Elm we can rename and register both.

First step in this bug is to assess how painful this split would be. The alternative is to have a fake provider.

Comment 1

[:Margaret Leibovic]

How would things like our combined view work in this case? We will probably always need some way to join the bookmarks and history data for awesomescren/top sites kinds of queries.

However, I would love to take this opportunity to clean up the mess that is BrowserProvider, because currently these queries can cause us performance grief.

Comment 2

[Richard Newman [:rnewman]]

(In reply to :Margaret Leibovic from comment #1)
> How would things like our combined view work in this case? We will probably
> always need some way to join the bookmarks and history data for
> awesomescren/top sites kinds of queries.

I imagine they'll still be backed by the same DB, so the combined view would just live in one of the two providers.

> However, I would love to take this opportunity to clean up the mess that is
> BrowserProvider, because currently these queries can cause us performance
> grief.

Yeah, I just wish it wasn't such an intimidating undertaking :D

Comment 3

[Richard Newman [:rnewman]]

16:25:41 < margaret> i'm noticing some things that are basically the same in BrowserProvider/TabsProvider that could be moved into some shared spot

Comment 4

[:Margaret Leibovic]

(In reply to Richard Newman [:rnewman] from comment #3)
> 16:25:41 < margaret> i'm noticing some things that are basically the same in
> BrowserProvider/TabsProvider that could be moved into some shared spot

I filed bug 941357 about this.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.