907070 - [PTS][BT][HFP] PTS verification process will be terminated after 2 test run. (TC_AG_COD_BV_02_I)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Hubert Lu[:hlu] <[e-mail]>]

Attachment: Sniffer log (TC_AG_COD_BV_02_I)

[Version Info]
    Gaia:     0f1f1ab0ab31a1df8a780baa048b5e7b2854205d
      B-D     2013-08-15 06:32:03
    Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/692d3414bb12
    BuildID   20130815041201
    Version   18.0

Test case : TC_SERVER_OPH_BV_18_I started
- SDP Service record: 'Client Service Record' successfully registered
- ProtocolDescriptorList: OPP Server RFCOMM channel retrieved successfully
- OBEX: OPP channel established by IUT
- OBEX: OPP connected by tester
- MTC: OPP channel connected successfully
- MTC: PTS put response indicates success when the response code should have indicated an error
- MTC: Current test status is FAIL or INCONClusive, results confirmation is being skipped.
- OBEX: Successfully sent a disconnect request
- OBEX: OPP successfully disconnected by tester
- OBEX: OBEX component exiting- MTC: Test case ended
Final Verdict : FAIL

Comment 1

[Ben Tian (inactive)]

We had fix for this test case in bug 828837 and bug 870304. I'll check whether the fix is missed during code refactoring.

BTW, Hubert, you paste the sniffer log of wrong test case.

Comment 2

[Ben Tian (inactive)]

Attachment: Patch 1: v1: (b2g18) Ensure icon for audio service devices

Comment 3

[Ben Tian (inactive)]

(In reply to Ben Tian [:btian] from comment #2)
> Created attachment 794422 [details] [diff] [review]
> Patch 1: v1: Ensure icon for audio service devices

This is patch for b2g18. I'm checking whether m-c requires the patch to pass the test case.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 794422 [details] [diff] [review]
Patch 1: v1: (b2g18) Ensure icon for audio service devices

Review of attachment 794422 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed.

::: dom/bluetooth/linux/BluetoothDBusService.cpp
@@ +210,2 @@
>  {
>    // Check property 'Paired' and only paired device will be returned

nit: this line shouldn't be here. Please assist with removing this or moving it to another place.

@@ +1037,5 @@
>    }
>    return false;
>  }
>  
> +void

Please make it static and move the function over functions which use it, then no extra function declaration would be needed.

@@ +1049,5 @@
> +  /**
> +   * Property "Icon" may be missed due to CoD of major class is TOY. But
> +   * we need to assign Icon as audio-card if service class is "Audio".
> +   * This is for PTS test TC_AG_COD_BV_02_I. As HFP specification
> +   * defines that service class is "Audio" can be considered as HFP AG.

Actually, a device with the 'Audio' bit set in 'service class' field should be considered as HF, not AG.

Comment 5

[Ben Tian (inactive)]

Attachment: [final] Patch 1: (b2g18 only) Ensure icon for audio service devices, r=echou

Revise patch and remove some unused functions.

Comment 6

[Ben Tian (inactive)]

Set leo? since the bug on v1.1 fails the BT certification test case (TC_AG_COD_BV_02_I).

Comment 7

[Preeti Raghunath(:Preeti)]

leo+ for Cert issue

Comment 8

[Ben Tian (inactive)]

Please land the fix in comment 5 onto b2g18.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/0c3c48cc121d

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/0c3c48cc121d

Comment 11

[Hubert Lu[:hlu] <[e-mail]>]

This issue was verified in below vesion of Unagi, and the result is passed.

Gaia:     9fb5802df60a9081846d704def01df814ed8fbd4
  B-D     2013-09-01 02:12:02
Gecko:   
BuildID   20130902060051
Version   26.0a1