Closed Bug 908004 Opened 11 years ago Closed 6 years ago

[Dialer] When SIM card state is "unknown", can't make emergency call

Categories

(Firefox OS Graveyard :: Vendcom, defect)

ARM
Gonk (Firefox OS)
defect
Not set
major

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: leo.bugzilla.gaia, Unassigned, NeedInfo)

References

Details

(Whiteboard: burirun1)

Attachments

(1 file)

1. Title : When SIM card state is "unknown", can't make a emergency call
2. Precondition : Airplane mode >> reboot device
3. Tester's Action : make a emergency call
4. Detailed Symptom : can't make a emergency call
5. Expected : can make a emergency call
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Personal email id : promise09th@gmail.com
Flags: needinfo?(etienne)
The current assumption is that the gaia dialer calls |telephony.dialEmergency| only when |conn.voice.emergencyCallsOnly| is true.

If we want to do it differently we need to know exactly in which other cases we want to call dialEmergency and what impact will this have on error handling.

Cc'ing platform people.
Flags: needinfo?(etienne)
David,

Please assign.
Assignee: nobody → dscravaglieri
Leo , is this a regression from 1.0.1 or a cert blocker ?

Wayne, do you know if making an emergency call while in airplane mode is a hard-core requirement to help with the details in comment # 1 ?
Keywords: qawanted
Can't assign yet, we need input from platform first
Assignee: dscravaglieri → nobody
QA Contact: nkot
Attached file logcat
I've tested it on Unagi, v1.1 and v1.0.1

v1.0.1 - bug reproduces, unable to make a call, should disable Airplane mode
v1.1   - does NOT reproduce, after entered in 911 and tapped the Dial button observing the following behavior: 
 - there is a short pause (notification unable to make a call might appear for a sec) 
>> in the status bar i can see that it starts searching for a network 
>> once found the network, the dialing screen appears, dialing tones can be heard, call gets connected
 - Airplane mode now is disabled and user is able to make any regular calls as well (this sounds like a bug!)
         
Unagi        
Build ID: 20130829041204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/0c3c48cc121d
Gaia: 23eadfd88057dc524f4452e48813503627f77fbe
Platform Version: 18.1
Needinfo :wayne to help with comment #3
Flags: needinfo?(wchang)
(In reply to Etienne Segonzac (:etienne) from comment #1)
> The current assumption is that the gaia dialer calls
> |telephony.dialEmergency| only when |conn.voice.emergencyCallsOnly| is true.
> 
> If we want to do it differently we need to know exactly in which other cases
> we want to call dialEmergency and what impact will this have on error
> handling.
> 
> Cc'ing platform people.

Can we please needinfo these platform people if they have not got back.Its not clear form the cc list who could help here.Thanks :)
Edgar, please help to check this bug.
Flags: needinfo?(wchang) → needinfo?(echen)
(In reply to nkot from comment #5)
> Created attachment 797335 [details]
> logcat
> 
> I've tested it on Unagi, v1.1 and v1.0.1
> 
> v1.0.1 - bug reproduces, unable to make a call, should disable Airplane mode
> v1.1   - does NOT reproduce, after entered in 911 and tapped the Dial button
> observing the following behavior: 
>  - there is a short pause (notification unable to make a call might appear
> for a sec) 
> >> in the status bar i can see that it starts searching for a network 
> >> once found the network, the dialing screen appears, dialing tones can be heard, call gets connected
>  - Airplane mode now is disabled and user is able to make any regular calls
> as well (this sounds like a bug!)
>          
> Unagi        
> Build ID: 20130829041204
> Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/0c3c48cc121d
> Gaia: 23eadfd88057dc524f4452e48813503627f77fbe
> Platform Version: 18.1

In leo device, when we set airplane mode and reboot, card state become "unknown" state. In this case, we cannot make a emergency call
(In reply to Etienne Segonzac (:etienne) from comment #1)
> The current assumption is that the gaia dialer calls
> |telephony.dialEmergency| only when |conn.voice.emergencyCallsOnly| is true.
> 

I think checking |conn.voice.emergencyCallsOnly| is enough to distinguish dial() and dialEmergency(). We don't need to have extra check for cardstate.

So I would suggest removing cardstate checking in [1].
[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/telephony_helper.js#L30

> If we want to do it differently we need to know exactly in which other cases
> we want to call dialEmergency and what impact will this have on error
> handling.
> 
> Cc'ing platform people.
:hsinyi has provided the useful information in comment #10. Clear needinfo request.
Flags: needinfo?(echen)
QA Contact: nkot
> In leo device, when we set airplane mode and reboot, card state become
> "unknown" state. In this case, we cannot make a emergency call

have tested on Leo, the issue reproduces only with COM_RIL!
1) attempt to make a call to any regular number
  ==> no airplane mode notification is displayed to the user, nothing happens when tap the dialer button (see bug 888419)
2) attempt to make an Emergency call
  ==> unable to make a call, nothing happens when tap the dialer button

for the MOZ_RIL, observing the same behavior as in comment 5 

Leo: D300f10a
Build ID: 20130903041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/9da3739ce7d7
Gaia: 8dc90703f4151d6f2a0decede0ee702f425a3a38
Platform Version: 18.1
RIL Version: 01.01.00.019.211
Keywords: qawanted
Mike,

Can you please check if this bug falls within your team? Seems to be in comRIL.
Flags: needinfo?(mvines)
Flags: needinfo?(mvines)
Reported please file an SR.
Assignee: nobody → anshulj
Repro's on:

Environmental Variables
Device: Buri 1.2.0
Build ID: 20130906040204
Gecko: http://hg.mozilla.org/mozilla-central/rev/ab5f29823236
Gaia: 94e5f269874b02ac0ea796b64ab995fce9efa4b3
Platform Version: 26.0a1
Blocks: 890825
Leo,

This issue seems to be an issue that QC needs to fix. Please open a bug in their SR and move this ahead.
Flags: needinfo?(leo.bugzilla.gaia)
(In reply to gbennett from comment #15)
> Repro's on:
> 
> Environmental Variables
> Device: Buri 1.2.0
> Build ID: 20130906040204
> Gecko: http://hg.mozilla.org/mozilla-central/rev/ab5f29823236
> Gaia: 94e5f269874b02ac0ea796b64ab995fce9efa4b3
> Platform Version: 26.0a1

This is likely going to be comRIL related, so you'll need to retest this against a buri device that has the Com RIL build installed.  mozRIL is not affected.
(In reply to Tony Chung [:tchung] from comment #17)
> (In reply to gbennett from comment #15)
> > Repro's on:
> > 
> > Environmental Variables
> > Device: Buri 1.2.0
> > Build ID: 20130906040204
> > Gecko: http://hg.mozilla.org/mozilla-central/rev/ab5f29823236
> > Gaia: 94e5f269874b02ac0ea796b64ab995fce9efa4b3
> > Platform Version: 26.0a1
> 
> This is likely going to be comRIL related, so you'll need to retest this
> against a buri device that has the Com RIL build installed.  mozRIL is not
> affected.

The above repro was for mozRIL. Can the bug repro against mozRIL and not be affected? I was able to repro the issue on the latest comRIL below:

Environmental Variables
Device: Buri 1.2 comRIL
Build ID: 20130911040201
Gecko: http://hg.mozilla.org/mozilla-central/rev/f9e8e8ce552c
Gaia: ebbb325958c66c3e68e1f190472d5f6e9076d83a
Platform Version: 26.0a1

Let me know if you need any more information. :)
Whiteboard: burirun1
(In reply to gbennett from comment #18)
> (In reply to Tony Chung [:tchung] from comment #17)
> > (In reply to gbennett from comment #15)
> > > Repro's on:
> > > 
> > > Environmental Variables
> > > Device: Buri 1.2.0
> > > Build ID: 20130906040204
> > > Gecko: http://hg.mozilla.org/mozilla-central/rev/ab5f29823236
> > > Gaia: 94e5f269874b02ac0ea796b64ab995fce9efa4b3
> > > Platform Version: 26.0a1
> > 
> > This is likely going to be comRIL related, so you'll need to retest this
> > against a buri device that has the Com RIL build installed.  mozRIL is not
> > affected.
> 
> The above repro was for mozRIL. Can the bug repro against mozRIL and not be
> affected? I was able to repro the issue on the latest comRIL below:
> 
Since it is also reproducible with Moz RIL I am leaning towards this to be a telephony_helper.js issue.

> Environmental Variables
> Device: Buri 1.2 comRIL
> Build ID: 20130911040201
> Gecko: http://hg.mozilla.org/mozilla-central/rev/f9e8e8ce552c
> Gaia: ebbb325958c66c3e68e1f190472d5f6e9076d83a
> Platform Version: 26.0a1
> 
> Let me know if you need any more information. :)
Assignee: anshulj → nobody
I just tried to reproduce this on a Leo device with the latest RIL available, and I don't reproduce. Please note that we also landed fixes related to emergency call in telephony_helper yesterday, that could fix this.

If it does not get fixed, we will need more precise STR, especially on how to put the SIM in unknown state.
QA Wanted - Can we retest this on Comm RIL & Moz RIL on a 1.1 Leo device? comment 20 seems to question if this is still reproducible.
Keywords: qawanted
QA Contact: sparsons
have retested on both COM-RIL and MOZ-RIL Leo 1.1 builds - the issue does not reproduce, the user is able to make Emerg calls while device is in Airplane mode

Build ID: 20130917041200
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/b459ac3ebe24
Gaia: 862b5761825e010e3cc5968c096377e1ea54bbf2

for the COM-RIL:
RIL Version: 01.01.00.019.212
Keywords: qawanted
closing as worksforme with comment 22.  Leo, please retest this on a recent build with Com RIL as things may have changed since the original bug report a month ago.  If you can reproduce, please list your test environment and repro steps in details.
Status: NEW → RESOLVED
blocking-b2g: leo? → ---
Closed: 11 years ago
Resolution: --- → WORKSFORME
So sorry about that, but I have to reopen this bug :(

The information provided in comment 22 is incorrect (I've checked the build I used for test and find out that the RIL folder is missing there, so results are valid only for MOZ-RIL)

I retested it again
 - downloaded a few builds from https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2g_ril/
 - and did confirmed(!) the actual RIL information on tested device in "system/b2g/distribution/bundles" after installing a build (or its absence when tested MOZ-RIL)

The issue still consistently Reproduces on Leo COM-RIL and does NOT reproduce on MOZ-RIL

Speaking of Buri and above comments of reproducing the issue on Buri 1.2 MOZ-RIL, it would be better to track this in separate bug, because the behavior is different on Buri (issue doesn't reproduce on Buri 1.1 COM-RIL).
I'll do more testing on Buri and will file another bug with all the information and details. 

STR (same as in comment 0):
1. Airplane mode >> reboot device
2. Make an Emergency call
==> can't make an Emergency call, tapping green dial button does nothing

Tested on builds:
Build ID: 20130917041200
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/b459ac3ebe24
Gaia: 862b5761825e010e3cc5968c096377e1ea54bbf2
Platform Version: 18.1
//for the COM-RIL
RIL Version: 01.01.00.019.226 

Build ID: 20130927041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/9e45dd3f5428
Gaia: f3b30b19d80240c9cc2aa2002398c902fd1d6375
Platform Version: 18.1
//for the COM-RIL
RIL Version: 01.01.00.019.236
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
This sounds like a vendor-specific issue.
Component: Gaia::Dialer → Vendcom
Blocks: 921979
(In reply to nkot from comment #26)
> So sorry about that, but I have to reopen this bug :(
> 
> The information provided in comment 22 is incorrect (I've checked the build
> I used for test and find out that the RIL folder is missing there, so
> results are valid only for MOZ-RIL)
> 
> I retested it again
>  - downloaded a few builds from
> https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2g_ril/
>  - and did confirmed(!) the actual RIL information on tested device in
> "system/b2g/distribution/bundles" after installing a build (or its absence
> when tested MOZ-RIL)
> 
> The issue still consistently Reproduces on Leo COM-RIL and does NOT
> reproduce on MOZ-RIL
> 
> Speaking of Buri and above comments of reproducing the issue on Buri 1.2
> MOZ-RIL, it would be better to track this in separate bug, because the
> behavior is different on Buri (issue doesn't reproduce on Buri 1.1 COM-RIL).
> I'll do more testing on Buri and will file another bug with all the
> information and details. 
> 
> STR (same as in comment 0):
> 1. Airplane mode >> reboot device
> 2. Make an Emergency call
> ==> can't make an Emergency call, tapping green dial button does nothing
> 
> Tested on builds:
> Build ID: 20130917041200
> Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/b459ac3ebe24
> Gaia: 862b5761825e010e3cc5968c096377e1ea54bbf2
> Platform Version: 18.1
> //for the COM-RIL
> RIL Version: 01.01.00.019.226 
> 
> Build ID: 20130927041201
> Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/9e45dd3f5428
> Gaia: f3b30b19d80240c9cc2aa2002398c902fd1d6375
> Platform Version: 18.1
> //for the COM-RIL
> RIL Version: 01.01.00.019.236

Reporter, please file an SR for us to look at the issue.
I used these STR:

1. longpress power button 
2. turn on airplane mode
3. longpress power button again
4. Restart
5. open Dialer once powered on after rebooting 
6. enter Emergency number (911)
7. tap green Dialer button

Actual result: 
 - tapping Dialer button does nothing

Expected:
 - tapping Dialer button will initiate an Emergency call
    

Leo v1.1
Gaia   680f3b86b1e4ff1411ece6ba397b8b0e56b4b31c
SourceStamp cb2a1a27a94c
BuildID 20131014041201
Version 18.0
RIL version: 01.01.00.019.251

Leo aurora
Gaia   d562c8f6eaed158bf5afa556f10c2f2e8ae8137f
SourceStamp 690f28662ace
BuildID 20131014004003
Version 26.0a2
RIL version: 01.02.00.019.071
Firefox OS is not being worked on
Status: REOPENED → RESOLVED
Closed: 11 years ago6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: