90824 - Symbols in menus: diamond=minimized, bullet=unsaved changes, checkmark=current window

Status: NEW

(Core :: XUL, defect)

Description

[Adam Masri]

Platform: PowerBook G3/300/192Mb/25Gb, MacOS X 10.0.4
Fizzilla Build: 2001071305

From "Aqua Human Interface Guidelines"

http://developer.apple.com/techpubs/macosx/SystemOverview/AquaHIGuidelines/AquaHIGuidelines.pdf

pp. 58, "Using Symbols in Menus," Apple discusses symbols that should be used in
menus to denote active, unsaved, and collapsed (to the dock) windows. Specifically:

o  A checkmark appears next to the active document's name. So, in the Tasks
menu, there should be a checkmark next to the frontmost window.

o  Use a bullet next to a document with unsaved changes.

o  Use a diamond for a document a user has minimized to the dock.

- Adam

Comment 1

[Mike Pinkerton (not reading bugmail)]

ok

Comment 2

[Greg K.]

Regarding item 1, this WorksForMe using FizzillaCFM/2002080508, except that
spawning a new window breaks it.

Comment 3

[Greg K.]

Per comment 2, filed bug 161383.

Comment 4

[Guillaume Déflache]

I guess the implementations of this and bug 347191 may share common code to track down pages with unsaved changes: perhaps somelink can link them together?

Comment 5

[Guillaume Déflache]

Also see bug 197720:
* yet another symbol may indicate the current tab in each window
* diamond on a tab *could* indicate it's not visible directly in the bar (is in the drop-down list) but as it would depend on the window current size I am not sure it's such a good idea...

Comment 6

[timeless]

http://stackoverflow.com/questions/3426374/how-do-you-specify-to-display-a-diamond-in-a-nsmenuitem-minimized-window-indica

NSImage* _NSGetThemeImage(int num);

[menuitem setState:NSOnState];
[menuitem setOnStateImage:_NSGetThemeImage(155)];

The code would have to go near:
123 nsresult nsMenuItemX::SetChecked(bool aIsChecked)
http://mxr.mozilla.org/mozilla-central/source/widget/cocoa/nsMenuItemX.mm#123

Then nsWindowDataSource would probably have to grow knowledge of minimized state,
and then some glue would need to be added to:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/macWindowMenu.inc