909227 - [lg] Test failure "The text on the page has been highlighted - '' should equal 'community'" in /testFindInPage/testFindInPage.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Andrei Eftimie]

Module:    testFindInPage
Test:      /testFindInPage/testFindInPage.js    
Failure:   The text on the page has been highlighted - '' should equal 'community'
Branches:  mozilla-beta
Platforms: OSX

Possibly a localization problem: fails on the lg locale.
http://mozmill-release.blargon7.com/#/functional/report/6d53b7d749a60e65551b4b1d19227443

Comment 1

[Andrei Eftimie]

This is reproducible.

However locally the fail message I see is:
> Timeout exceeded for waitForElement Lookup: /id(\"main-window\")/id(\"tab-view-deck\")/[0]/id(\"browser\")/id(\"appcontent\")/id(\"content\")/anon({\"anonid\":\"tabbox\"})/anon({\"anonid\":\"panelcontainer\"})/{\"id\":\"panel1377872377015\"}/anon({\"class\":\"browserSidebarContainer\"})/anon({\"class\":\"browserContainer\"})/[0]/anon({\"anonid\":\"findbar-container\"})/anon({\"anonid\":\"findbar-textbox-wrapper\"})"

Not sure why the dashboard-reported error is different.

All branches are affected (except nightly: no builds for 'lg'), does look like a localization issue.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

On mozilla-central we do no l10n work anymore. So nothing can be seen with that branch.

Comment 3

[mario garbi]

The "findbar-container" element is being generated when we call it with Ctrl/Cmd + F which on 'lg' locale isn't working. This is because on 'lg' locale the findOnCmd.commandkey is set to 'n' which opens a new window (tested this manually). 

http://mxr.mozilla.org/l10n-mozilla-aurora/source/lg/browser/chrome/browser/browser.dtd#589

Comment 4

[Andrei Eftimie]

Please open a bug against the localisation to get this conflict fixed.

Comment 5

[u279076]

Is it possible to disable this test for this locale until bug 913396 is resolved?

Comment 6

[mario garbi]

Attachment: skip_1109.patch

Skip patch for 'lg' locale only. The test hasn't been skipped in manifest since we want to run it with the regular locales.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to mario garbi from comment #6)
> Skip patch for 'lg' locale only. The test hasn't been skipped in manifest
> since we want to run it with the regular locales.

This is not how its going to work, Mario! We can't leave out the manifest file for that. We will have Mozmill 2 soon and it would run this test. We can only skip completely or not, as long as we cannot disable tests via the locale in manifests.

Comment 8

[mario garbi]

Attachment: skip_1109.patch

Updated the manifest to disable the test.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 802834 [details] [diff] [review]
skip_1109.patch

Review of attachment 802834 [details] [diff] [review]:
-----------------------------------------------------------------

As said, we have to skip it completely or not at all. This approach will not work. Also I would like to see this discussed first.

Comment 10

[mario garbi]

Attachment: skip_1109.patch

Full skip for the test as requested.

Comment 11

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 802842 [details] [diff] [review]
skip_1109.patch

Review of attachment 802842 [details] [diff] [review]:
-----------------------------------------------------------------

Disabled on all affected branches (nightly is not since there's no 'lg' locale there):

http://hg.mozilla.org/qa/mozmill-tests/rev/923455683131 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/d57dd6a76c94 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/fcbb32f082b0 (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/8a19fbfac7a4 (esr17)
http://hg.mozilla.org/qa/mozmill-tests/rev/488e77d6b86a (esr24)

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It's bad to see that we had to skip this given that only a single locale is affected. Lets get the dependencies filed and fixed so we can really skip by locale and application version.

Comment 13

[Andreea Matei [:AndreeaMatei]]

According to Francesco on bug 913396 comment 4, this will remain unfixed until new volunteers offer to help on that locale. 

Lets try to get the specific locale skip work done so we can unskip this test from all the others locales that are not affected.

Comment 14

[Andreea Matei [:AndreeaMatei]]

Hm, I wanted to check this locale and I couldn't seem to find it. Francesco helped me with bug 958703 where this has been removed, so we should be able to unskip this test if it's not affected by other failure as I knew before. Checking this.

Comment 15

[Andreea Matei [:AndreeaMatei]]

Actually this was unskipped by another bug, only esr24 remained, which fails due to bug 835739. We said that we won't want the fix in esr24, so we will wait for the new esr. 
In regards of this bug's failure, it is fixed.