910176 - [CONTACTS] Favourite contacts hasn't checkbox to select them in export to sim contacts screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[b.paloma]

Attachment: 2013-08-28 (2).png

Repro:
1. Go to Contacts -> Settings -> Export contacts
2. Tap on 'SIM card' option
3. Once the list of contacts is shown, select the favorite contact (ER1)
4. Tap on 'Export'

Expected:

ER1. The favorite contact shows as selected.

Actual:

ER1. There isn't a check box for the favorite contact. Only we know the favorite contact was selected for export because the 'Deselect all' button is enabled.

Notes:
This bug has been checked on:
branch: master
Gaia:43cf923
Gecko:7dc9265

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Just FYI, my work-in-progress for bug 902873 already fixes this problem.  I hope to have something for review by the end of the week.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Ben you rock :)

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

this should not block a release but please land this when a fix is available. master is open now

Comment 4

[rafael.marquez]

We have the same problem in the "export to vCard". We maintain this bug for two screens, but if necessary we can open a new bug.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

(In reply to rafael.marquez from comment #4)
> We have the same problem in the "export to vCard". We maintain this bug for
> two screens, but if necessary we can open a new bug.

Yep, one bug is adequate.  Its common code and should be fixed for all selection uses at the same time.

Adding dependency to bug 902873 so its easier to how the bugs relate.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Since bug 902873 has already landed, this is fixed now.

Thanks!

Comment 7

[isabelrios]

Verified on 10/21 build:
Gecko-6412d0e
Gaia-1fd3153