911007 - [B2G][Helix][Setting][Battery][shijinde]the power save mode will turn off when restart the phone

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[lecky]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; aff-kingsoft-ciba; .NET4.0C; .NET4.0E; Zune 4.7; Tablet PC 2.0)

Steps to reproduce:

1、go to setting->battery, turn on the power save mode
2、restart the phone


Actual results:

1、go to setting->battery, the power save mode turn off


Expected results:

1、go to setting->battery, the power save mode turn on

Comment 1

[lecky]

this question happened everytimes

Comment 3

[Wayne Chang [:wchang]]

I dont see how this is a dupe to bug 911054.

Hi Mihai, do you know if the power saver status is preserved over power cycles?

Thanks.

Comment 4

[Wayne Chang [:wchang]]

> Hi Mihai, do you know if the power saver status is preserved over power
> cycles?
> 
> Thanks.

Alive, maybe you can confirm this?

Comment 5

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

(In reply to Wayne Chang [:wchang] from comment #3)
> I dont see how this is a dupe to bug 911054.
> 
> Hi Mihai, do you know if the power saver status is preserved over power
> cycles?
> 
> Thanks.

Hi Wayne, sorry for the delay.

From what I know, the power saving mode is kept in a mozSetting, "powersave.enabled", that should persist upon reboot. However, if a threshold other than "never" is selected for the "automatically enable power saving mode" option then the power saving mode gets disabled automatically when the battery level passes the threshold.

The problem highlighted in this bug might be already fixed by the patch for bug 911001.

Comment 6

[Evelyn Hung]

On my helix device with partner build 10/15, the toggle will be turned off after a few minutes, I'm investigating.

Comment 7

[Evelyn Hung]

Apply the patch in bug 911001 seems fix the bug.

Comment 8

[Evelyn Hung]

(In reply to Evelyn Hung [:evelyn] from comment #7)
> Apply the patch in bug 911001 seems fix the bug.

correct myself: in case the "automatically enable power saving mode" is "15%" or others (except "never"), reboot device will turn power save mode off. The code segment below is suspicious: https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/system/js/battery_manager.js#L263

SettingsListener.observe('powersave.threshold', 0,
  function getThreshold(value) {
    ... 
  
    if (battery.level > value && _powerSaveEnabled) {
      setMozSettings({'powersave.enabled' : false});
      return;
    }
});

Why we always set powersave.enabled to false if battery level is greater than powersave threshold? Is it a mistake from bug 894263 (https://github.com/mozilla-b2g/gaia/commit/e8944204b9faf388666685852e97b5e8f5bc92c9)?

Comment 9

[Evelyn Hung]

Discussed with Alive offline, he said it's UX intention to turn off power saving mode when battery is enough.
However, I believe it confuses users if power saving mode is a setting and the user intend to enable it no matter how much better left. ni UX for a proper behavior.

Comment 10

[Evelyn Hung]

and it's not a critical bug since user can always turn it on after reboot. flag to 1.3?

Comment 11

[Neo Hsieh [:neo]]

Hi Evelyn, The power safe mode toggle is used to enable or disable function.
So, If that toggle is disable, please hide other options and description. If power save mode is enabled, please show the options and description.   Thank you.

Comment 12

[Bruce Huang [:bhuang] (inactive)]

Moving to backlog as it's not critical but needs to be tracked.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

There are cases users would like to enable power save mode when the battery level is still high. For example, users expect to use the phone with a couple days without charging. The design in comment 11 seem not be able to support this use case.

Comment 14

[Neo Hsieh [:neo]]

Sorry, I don't understand. User still can turn on the toggle and system will show other options.

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Currently we only have options for enabling power save mode when 5%, 15%, 25% battery left and never, which means users are not able to enable power save mode when the battery level is over 25%.

Comment 16

[Neo Hsieh [:neo]]

OK....

First, we need an icon in status bar. Let user knows the "power save mode" status. (Maybe just add blue battery icon?)
 
And we add 50%, 75% options add one rule : If the power save mode toggle is on, we hide the Automatically options, else, we show the automatic options . This rule can make them exclusive. 

If user connect charger and battery capacity climb to more than trigger setting, system will turn off power save mode. 
Means the status battery icon will auto change to normal color. 

Toggle on : Manual turn on the power save mode. 
Toggle off: Enter automatic mode

What do you think ?

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

Sounds good to me except for the 50%, 75% options. It is weird to me that users would like the power save mode to be enabled automatically when the battery level drops under 50% or 75%. If they want to preserve the battery life in advance, they may choose enable the power save mode manually.

Comment 18

[Neo Hsieh [:neo]]

Yes, maybe, But I think we still need to cover more options for user in this case.  :)

Comment 19

[yifan [:yifan][:yliao]]

Hi Arthur,

Do we have a conclusion for the power save mode interface?

Comment 20

[Arthur Chen [:arthurcc][inactive after 6/30]]

Flagging Jenny for the final decision.

The debate was about is it required to turn off power save mode for users when the battery level exceeds the threshold (comment 9). Neo gave a draft in the following comments but it may be outdated. Jenny, could you help on this? Thanks!

Comment 21

[Jenny Lee]

Hi Arthur, 

I think we should turn off power save mode when battery level exceeds the threshold.
I'd like to add one thing though, whenever the device is in power save mode, can we display power save mode icon on status bar?  
Thanks!

Comment 22

[BMO Automation]

Firefox OS is not being worked on