911129 - [Keyboard][V1.2] After switching the keyboard layout, the cursor doesn't focus on text field

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[William Hsu [:whsu]]

* Description:
  This problem happens on v1.2 branch.
  After you switches the keyboard layout via the menu of keyboard layout, the cursor will disappear and not focus on text field.

* Precondition:
  Enable more than one keyboard layout

* Reproduction steps:
  1. Launch the contact app
  2. Tap "+" to add a new contact.
  3. Tap the "Name" field
  4. Long press the Global key
  5. Select another keyboard layout
  6. Input "AAA"

* Expected result:
  The name field displays the "AAA"

* Actual result:
  The cursor disappears and cannot input any character.
  Need to tap the name field again.

* Reproduction build:(Mozilla-Central)
  + Mercurial-Information
    - Gecko revision="416075f77249"
  + Git-information
    - Gaia revision="94c3dde50cb8da6e9d9ed137bfbf895f8699f8e7"(From Rudy's repository)
  + Gecko version: 26.0a1


Thanks!

Comment 1

[William Hsu [:whsu]]

Attachment: Cursor's focus

Comment 2

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Hi William,
   since bug 893560 landed, I can not reproduce this issue.
   Can you verify it again?
   Thanks.

Comment 3

[William Hsu [:whsu]]

Hi, Gary,

OK! I will use PVT build to verify it soon.
Thanks!

Comment 4

[William Hsu [:whsu]]

Hi, Gary and all,

I still can reproduce this case via the same test steps.
Do I misunderstanding anything?
Thank you.

* Test build:
 - Gaia:     9cb0bf07dd6b8c23ee4c4db3d866464077f81e45
 - Gecko:    afc0d277a978e95a9c74d1daa41af0bd15c4d6e6
 - BuildID   20130916060051
 - Version   26.0a1

Comment 6

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/12381

Since list_menu has been removed by Bug 912904, so I do same thing like Bug 911129 to prevent action menu take focus when keyboard shown.

please help to review this patch thanks.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 808997 [details]
pull request: https://github.com/mozilla-b2g/gaia/pull/12381

Remove console.log before merging. r=me

Comment 8

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Thanks a lots.

I've remove console.log.
https://github.com/mozilla-b2g/gaia/pull/12381/files

I will merge this patch later since I have no permission right now.

Comment 10

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

merged in gaia master
https://github.com/mozilla-b2g/gaia/commit/cec9deb74213abeaef2ab929d4c3be30749003d1
https://github.com/mozilla-b2g/gaia/commit/191a018ef457dd0faeaed9a29d1efa2f65acb1e7

Comment 11

[Ivan Tsay (:ITsay)]

Need the fix to be uplift to 1.2.

Comment 12

[William Hsu [:whsu]]

Hi, all,

I cannot reproduce this case on master branch but still can reproduce this case on V1.2 (aurora).
Please uplift this patch to V1.2 branch.
Many thanks.

* Test Build: (Mozilla-aurora-hamachi)
 - Gaia:     1e9470b9b6df630eddf1c4c8b25b3170ee786b0e
 - Gecko:    http://hg.mozilla.org/releases/mozilla-aurora/rev/48faa2668dd8
 - BuildID   20130929004004
 - Version   26.0a2
 ===> Result: Still can reproduce.

Comment 13

[James Lal [:lightsofapollo]]

Uplifted 191a018ef457dd0faeaed9a29d1efa2f65acb1e7 to:
v1.2: d7c7a266b9a69640b66ccc2f155aeb3ca422842b

Comment 14

[William Hsu [:whsu]]

Hi, all,

Thanks for all your help!
I cannot reproduce this bug on V1.2 branch.
Marked it as "VERIFIED"

* Test Build:
 - Gaia:     e378651483294c0e26c912b73ac6f6c906e553d3
 - Gecko:    http://hg.mozilla.org/releases/mozilla-aurora/rev/c8e97fd5b94d
 - BuildID   20131011004001
 - Version   26.0a2