[e.me][bug] Pre-installed apps don't show in relevant collections

RESOLVED FIXED

Status

Firefox OS
Gaia::Everything.me
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ranbena, Assigned: amirn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

When searching Evme, Pre-installed apps should appear for relevant search queries.

STR:
1. Search "Utilities"
2. Above the Cloud apps the following apps should appear (not in this order):
- Browser
- Settings
- Usage
- Calendar
- Clock
- Marketplace
(Reporter)

Updated

4 years ago
Assignee: nobody → ran
Blocks: 910302
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
pushed to new branch 911568-nativeinfo
https://github.com/EverythingMe/gaia/commit/4264d69877b99a3fe2bf6e03050a243f01b87179
Update: https://github.com/EverythingMe/gaia/commits/911568-nativeinfo
Three top commits:

Fixed DoATAPI retry after session init - the first API request is nativeInfo which required an API session init. When Session was inited, the previous request recalled.
https://github.com/EverythingMe/gaia/commit/caf1d1fb3c9210af1763222a5c1abd72926cd8aa

Fix installed apps in pre-installed Collections - a race condition prevented Collections from being updated when the queryIndex changed.
https://github.com/EverythingMe/gaia/commit/4264d69877b99a3fe2bf6e03050a243f01b87179

Fixed guid population - guid array was sent to API empty.
https://github.com/EverythingMe/gaia/commit/be620bce8a6511a0ac06b1736d04eaa386b56ea7
(Assignee)

Updated

4 years ago
Assignee: ran → amirn
(Assignee)

Comment 3

4 years ago
some of the work done will no be needed after rebasing to CCC
(Assignee)

Comment 4

4 years ago
branch rebased onto stg-pr, removed un-neccessary code
(Reporter)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 919555
(Assignee)

Updated

4 years ago
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
(Assignee)

Updated

4 years ago
Summary: [e.me][bug] Pre-installed apps don't show in relevant searches → [e.me][bug] Pre-installed apps don't show in relevant collections
(Assignee)

Comment 6

4 years ago
https://github.com/EverythingMe/gaia/commit/db0a32fe3f9894550e1280ff12ad6d9e002f55d3

* removed dead code from Evme.CollectionStorage - no longer maintains the list of collection id's (grid handles that)
* populate pre-installed collections by experienceId
(Assignee)

Updated

4 years ago
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Blocks: 921092
(Assignee)

Updated

4 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

4 years ago
Created attachment 811703 [details]
redirect to PR
Attachment #811703 - Flags: review?(crdlc)
(Assignee)

Updated

4 years ago
Attachment #811703 - Attachment description: 12530.html → redirect to PR
(Assignee)

Updated

4 years ago
Blocks: 921841
Comment on attachment 811703 [details]
redirect to PR

Please review because you know this code infinitely better than me
Attachment #811703 - Flags: review?(crdlc) → review?(ran)
Amir, after gaia-reset, click on "social" - you'll see the pre-installed social apps which suddenly switch to "music" apps.
I pushed a fix. Now "social" apps stay put.
(Reporter)

Updated

4 years ago
Attachment #811703 - Flags: review?(ran) → review+
(Assignee)

Comment 11

4 years ago
landed in master
https://github.com/mozilla-b2g/gaia/commit/d9f90004deb88002e0e83ebd40efc23d9688a836
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Duplicate of this bug: 920617
This PR also takes care of another bug in which the first Collection clicked would not return results.
(Reporter)

Updated

4 years ago
blocking-b2g: --- → koi?
removing koi? since e.me 1.2 features are delayed for future version
blocking-b2g: koi? → ---
You need to log in before you can comment on or make changes to this bug.