911568 - [e.me][bug] Pre-installed apps don't show in relevant collections

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

When searching Evme, Pre-installed apps should appear for relevant search queries.

STR:
1. Search "Utilities"
2. Above the Cloud apps the following apps should appear (not in this order):
- Browser
- Settings
- Usage
- Calendar
- Clock
- Marketplace

Comment 1

[Amir Nissim (:amirn)]

pushed to new branch 911568-nativeinfo
https://github.com/EverythingMe/gaia/commit/4264d69877b99a3fe2bf6e03050a243f01b87179

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Update: https://github.com/EverythingMe/gaia/commits/911568-nativeinfo
Three top commits:

Fixed DoATAPI retry after session init - the first API request is nativeInfo which required an API session init. When Session was inited, the previous request recalled.
https://github.com/EverythingMe/gaia/commit/caf1d1fb3c9210af1763222a5c1abd72926cd8aa

Fix installed apps in pre-installed Collections - a race condition prevented Collections from being updated when the queryIndex changed.
https://github.com/EverythingMe/gaia/commit/4264d69877b99a3fe2bf6e03050a243f01b87179

Fixed guid population - guid array was sent to API empty.
https://github.com/EverythingMe/gaia/commit/be620bce8a6511a0ac06b1736d04eaa386b56ea7

Comment 3

[Amir Nissim (:amirn)]

some of the work done will no be needed after rebasing to CCC

Comment 4

[Amir Nissim (:amirn)]

branch rebased onto stg-pr, removed un-neccessary code

Comment 6

[Amir Nissim (:amirn)]

https://github.com/EverythingMe/gaia/commit/db0a32fe3f9894550e1280ff12ad6d9e002f55d3

* removed dead code from Evme.CollectionStorage - no longer maintains the list of collection id's (grid handles that)
* populate pre-installed collections by experienceId

Comment 7

[Amir Nissim (:amirn)]

Attachment: redirect to PR

Comment 8

[Cristian Rodriguez (:crdlc)]

Comment on attachment 811703 [details]
redirect to PR

Please review because you know this code infinitely better than me

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

Amir, after gaia-reset, click on "social" - you'll see the pre-installed social apps which suddenly switch to "music" apps.

Comment 10

[Ran Ben Aharon [:ranbena] EverythingMe]

I pushed a fix. Now "social" apps stay put.

Comment 11

[Amir Nissim (:amirn)]

landed in master
https://github.com/mozilla-b2g/gaia/commit/d9f90004deb88002e0e83ebd40efc23d9688a836

Comment 13

[Ran Ben Aharon [:ranbena] EverythingMe]

This PR also takes care of another bug in which the first Collection clicked would not return results.

Comment 14

[Evyatar 'Tron' Amitay (everything.me)]

removing koi? since e.me 1.2 features are delayed for future version