912298 - Nightly crashes after being killed in the background

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

STR:
1) Open Nightly
2) Push home and make Nightly be background-killed (using oom-fennec or opening several other apps)
3) Open Nightly

09-03 17:26:48.323 29969 29969 E GeckoAppShell: >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
09-03 17:26:48.323 29969 29969 E GeckoAppShell: java.lang.ClassCastException: android.view.ViewStub cannot be cast to android.view.ViewGroup
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:901)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1088)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1070)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.support.v4.app.FragmentManagerImpl.dispatchActivityCreated(FragmentManager.java:1861)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.support.v4.app.FragmentActivity.onStart(FragmentActivity.java:547)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1163)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.app.Activity.performStart(Activity.java:5068)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2109)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2174)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.app.ActivityThread.access$700(ActivityThread.java:141)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1267)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.os.Handler.dispatchMessage(Handler.java:99)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.os.Looper.loop(Looper.java:137)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at android.app.ActivityThread.main(ActivityThread.java:5059)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at java.lang.reflect.Method.invokeNative(Native Method)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at java.lang.reflect.Method.invoke(Method.java:511)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:792)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:555)
09-03 17:26:48.323 29969 29969 E GeckoAppShell: 	at dalvik.system.NativeStart.main(Native Method)

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: HomePager's stub and view should not share the same id

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 799476 [details] [diff] [review]
HomePager's stub and view should not share the same id

Review of attachment 799476 [details] [diff] [review]:
-----------------------------------------------------------------

Is this trivial enough to just land today with my r+? I'd very much like to verify this fix in Nightly, not Aurora...

Comment 5

[Lucas Rocha (:lucasr)]

All green: https://tbpl.mozilla.org/?tree=Try&rev=65a454ecc39b
Pushed: https://hg.mozilla.org/integration/fx-team/rev/ead32b24b522

Comment 6

[Lucas Rocha (:lucasr)]

Comment on attachment 799476 [details] [diff] [review]
HomePager's stub and view should not share the same id

This is a kinda urgent fix. Pushed with rnewman's r+.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ead32b24b522

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

This hasn't appeared in a nightly yet, because of bug 913842.