Closed
Bug 912345
Opened 12 years ago
Closed 12 years ago
Fix up tryload.js
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: philor)
References
Details
(Keywords: trychooser)
Attachments
(5 files)
3.86 KB,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
1.12 KB,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
3.65 KB,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
2.53 KB,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
3.26 KB,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
First round:
* we aren't looking at Ubuntu for test load, so we're missing nearly all the Linux test load
* there's a ton of "call the same function three times with the same three arguments we just used" copy-paste for Linux build load, and there would be for test load except we're pretending that emulator tests (and asan-to-be, which is what started me on this) don't cause or consume any load
Attachment #799260 -
Flags: review?(emorley)
Assignee | ||
Comment 1•12 years ago
|
||
Cute how the build load is == linux, and the test load is == linux64, no?
Attachment #799276 -
Flags: review?(emorley)
Assignee | ||
Comment 2•12 years ago
|
||
At least things get slightly less confusing once "panda" isn't both a platform (that we no longer build) and also the test load thingy that always loses the Math.max race with tegra.
Attachment #799277 -
Flags: review?(emorley)
Assignee | ||
Comment 3•12 years ago
|
||
Can't fix Win64, since the data isn't there, bug 912350.
Assignee | ||
Comment 4•12 years ago
|
||
Imagine my horror when I saw that Mac wasn't working, and at first thought the "build_macos64x_gecko" was actually the name of the platform.
Attachment #799290 -
Flags: review?(emorley)
Assignee | ||
Comment 5•12 years ago
|
||
todo: add win2012x64, add win8 tests (though they probably never win the Math.max race).
Assignee | ||
Comment 6•12 years ago
|
||
And I think that's it for this bug.
Attachment #799943 -
Flags: review?(emorley)
Updated•12 years ago
|
Attachment #799260 -
Flags: review?(emorley) → review+
Updated•12 years ago
|
Attachment #799276 -
Flags: review?(emorley) → review+
Updated•12 years ago
|
Attachment #799277 -
Flags: review?(emorley) → review+
Updated•12 years ago
|
Attachment #799290 -
Flags: review?(emorley) → review+
Comment 7•12 years ago
|
||
Comment on attachment 799943 [details] [diff] [review]
[tools] Add Win64 and Win8 load
Review of attachment 799943 [details] [diff] [review]:
-----------------------------------------------------------------
Lgtm & works well locally :-)
Attachment #799943 -
Flags: review?(emorley) → review+
Comment 8•12 years ago
|
||
Thank you for doing these :-)
Assignee | ||
Comment 9•12 years ago
|
||
http://hg.mozilla.org/build/tools/rev/2c688386bfeb
http://hg.mozilla.org/build/tools/rev/034dd2344018
http://hg.mozilla.org/build/tools/rev/0db6d4d67897
http://hg.mozilla.org/build/tools/rev/0d3169cd7428
http://hg.mozilla.org/build/tools/rev/0f952a7d145e
And deployed.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•