913377 - Redesign of lockscreen - Gaia implementation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Joe Cheng [:jcheng] (please needinfo)]

break bug 887802 into 2 bugs - this is for lockscreen

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

This patch does these things:

1. Remove legacy designing and code and put the new appearance in
2. Monitor touch events to trigger sliding begin/end handler
3. Use three elements to represent the transformation of the slider

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 801328 [details]
Patch

Since Rob is in Oslo, I will show him new lockscreen implmentation and you can discuss on bugzilla first and meeting on Tusday.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: onehand.ogv

Add video to show pull to unlock with one hand

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: twohands.ogv

Add video to show pull to unlock with two hands.

Comment 5

[Rob MacDonald [:robmac]]

Hi Yuren and Greg...

Thanks for putting together these videos. Overall we're really happy with the work has been done so far. We do have some suggestions, though, on how it can be optimized, and I've quickly summarized these below in advance of today's meeting.

1) When the user taps on the handle and does not drag it, the handle should pulse instead of changing color. The color is introduced in the background only when the user starts moving the handle. This helps us with the incoming call scenario, below.

2) For the incoming call scenario, the same behaviour applies, however, if the user drags the handle to accept the call, the background shape changes to green. If the user drags the handle to decline the call, the background shape changes red in color.

We're also proposing that the icon for the action in the lock mechanism that is NOT selected fades or recedes slightly. This is something we can discuss with Eric and Przemek during our call. 

We look forward to the discussion!

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

I've finished the new design discussed at 2013/9/10, but the "glitch" problem comes back because it cannot be covered with the blue immediately anymore. Anyway I will record two new videos to demo how the new design looks like.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 801328 [details]
Patch

Overall looks GREAT!! Thanks for your hard work.

Please address the two issues on follow-up bugs.

Comment 8

[Anthony Ricaud (:rik)]

I'm really happy to see this new lockscreen. But I'm a bit sad to not see new tests for this :(

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

I've found there's already a unit test in 'system/test/unit', but it's totally irrelevant to the standard mode. The tests in the file focus on mobile operator information and emergency calls, and no unlocking tests.

If we put tests about the lockscreen in standard mode, it would focus on mimicking user's behavior to pull the slide and test if the screen got unlocked. This may need to use Marionette to complete it, but I can't figure out how to implenent it soon.

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

Follow up bug for writing test on bug 913377

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

Bug 916035 - Follow up bug for writing test on bug 913377

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/dad386333df555e48649de58b385c48465738c9b

Comment 13

[Eitan Isaacson [:eeejay]]

This patch left a lot of the old stuff in the markup, css and js. Specifically the 'triggered' class.

Comment 14

[Greg Weng [:snowmantw][:gweng][:λ]]

(In reply to Eitan Isaacson [:eeejay] from comment #13)
> This patch left a lot of the old stuff in the markup, css and js.
> Specifically the 'triggered' class.

Yeah, I didn't clear it up completely and refactor the code due to the lack of time. Keeping things work without any possible failure is the first rule in this version, and as what we've dicussed earlier, there would be a refactored version merged both incoming call and standard mode. However, I firstly must write some test cases for this verison rather than start the new one.

Comment 15

[Tony Chung [:tchung]]

Al, can you add moztrap tests for this feature?   We need these included for 1.2 homescreen testsuite.  Thanks.

Comment 16

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: LockScreen-1.2.ogv

Demo video of current lockscreen.

Comment 17

[Rob MacDonald [:robmac]]

Hi Greg...

Thanks for putting together the video. Overall it's coming together nicely but there remain a few items from last week. Specifically...

1) The camera and lock icons don't seem to increase brightness when placing a finger on the lock. I know we reviewed this last week so perhaps it's a limitation of the video. Are you able to confirm?

2) I sent you the graphics from Przemek for the slider handle. Let us know if you have any questions about this.

3) I know you've been working with Steve to get rid of the horizontal black bands but it seems we're not having much luck. Is this still in progress?

Thanks!
Rob

Comment 18

[Greg Weng [:snowmantw][:gweng][:λ]]

(In reply to Rob MacDonald [:robmac] from comment #17)
> Hi Greg...
> 
> Thanks for putting together the video. Overall it's coming together nicely
> but there remain a few items from last week. Specifically...
> 
> 1) The camera and lock icons don't seem to increase brightness when placing
> a finger on the lock. I know we reviewed this last week so perhaps it's a
> limitation of the video. Are you able to confirm?
> 
> 2) I sent you the graphics from Przemek for the slider handle. Let us know
> if you have any questions about this.
> 
> 3) I know you've been working with Steve to get rid of the horizontal black
> bands but it seems we're not having much luck. Is this still in progress?
> 
> Thanks!
> Rob

Hi Rob,

These days I'm trying to solve the horizontal lines and it got eased after Bug 921360, but finding a complete solution especially works for most common devices is still in the process at Bug 919410. I'll also send a patch to see if the icon effects become more obvious in Bug 921392, and fix the arrow & overflow blue area at Bug 921335. However, I'll hope these minor issues can be landed later, to let the Bug 919850 and Bug 919858 landed first, because the later two affects the whole lockscreen.

Comment 19

[Al Tsai [:atsai]]

There are already test cases in moztrap and don't need to add extra test cases for the case.