913418 - Opening image from film strip results in black screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Florin Strugariu [:Bebe]]

Attachment: logcat of the issue

STR:

1. Open camera app
2. Take photo
3. wait for film strip
4. tap to open the image

Expected:
4. the image is open and is visible

Actual:
4. A black screen is available

Reproducing this on:
Gecko  http://hg.mozilla.org/mozilla-central/rev/aa9ec17cf912
Gaia  41f9daeca07b230ca2e5f824ed80f7dcfbc93815
BuildID 20130905143608
Version 26.0a1

Screen shot:
http://imgur.com/ImjvpoR

Comment 1

[Florin Strugariu [:Bebe]]

this first failed in build:
#164 (Sep 5, 2013 5:57:25 AM) 
http://qa-selenium.mv.mozilla.com:8080/job/b2g.unagi.mozril.gaia.master.ui/164/

Comment 3

[Marcia Knous [:marcia]]

I actually found this bug when testing last evening using:

Gaia   b77dc7d399c14ac2bafe5c89566b292bc6772d32
SourceStamp df8f342e9a6b
BuildID 20130905185329
Version 26.0a1

But somehow I forgot to file it since the SM finished so late. So it was happening on the respun build that came out yesterday.

Comment 4

[Marcia Knous [:marcia]]

(In reply to Florin Strugariu [:Bebe] from comment #1)
> this first failed in build:
> #164 (Sep 5, 2013 5:57:25 AM) 
> http://qa-selenium.mv.mozilla.com:8080/job/b2g.unagi.mozril.gaia.master.ui/
> 164/

Which build in the pvt directory does this correlate to? Is it the same build as in Comment 3?

Comment 6

[Chris Kreinbring [:CKreinbring]]

Also seen when sending photos via Bluetooth.  The receiving user will find a blank black screen instead of the photo that was just received.

Comment 7

[Marcia Knous [:marcia]]

This passed the smoketest on 20130904040205. We didn't run the horked build (2013-09-05-04-02-01/)that came out yesterday, but this shows up in BuildID 20130905185329 which is the respin. So the regression is either the horked build or the build I cited in Comment 3.

Comment 8

[Marcia Knous [:marcia]]

Buri Regression Window:

Works:

Gaia   b6c5bf1d24230bfed4a8f680e625fa2175001f82
SourceStamp 7ff96bd19c1c
BuildID 20130904040205
Version 26.0a1

Busted:

Gaia   ec885264d885d877d68980c0227058231f18ad09
SourceStamp 77ed46bf4c1a
BuildID 20130905040201
Version 26.0a1

Comment 9

[Jason Smith [:jsmith]]

This was likely caused by bug 911669.

Comment 10

[John Hu [:johnhu][:johu][:醬糊小弟]]

Jason, 

I don't think it is caused by bug 911669. It only fixed the state of flash light.

If we look the logcat, we may find the following line[1]:
[JavaScript Error: "TypeError: self.orientation is undefined" {file: "app://camera.gaiamobile.org/shared/js/media/media_frame.js" line: 130}]

That prevent the computeFit and setPosition to run. So, the screen is all black.

It's for the bug 900425. Please also help to check it.

[1] https://github.com/mozilla-b2g/gaia/blob/ac2370485c61d7fe2ddd61ee75d990918443c905/shared/js/media/media_frame.js#L130

Comment 11

[John Hu [:johnhu][:johu][:醬糊小弟]]

BTW, the patch of bug 900425 is also landed at Sept 4th, 2013.

Comment 12

[John Hu [:johnhu][:johu][:醬糊小弟]]

Tom, 

Any suggestion about comment 10.

Comment 13

[Jason Smith [:jsmith]]

Sounds good. If you back out the commit from bug 900425, does it fix this bug? If so, can we back that out?

Comment 14

[John Hu [:johnhu][:johu][:醬糊小弟]]

Jason,

It fixed this bug, if we back out it. But there is another commit depends on it. Is it fine to back out the single one or need to back out all of them?? And it may not be hard to fix this bug.

If we update the code the latest, this bug is disappeared and another bug is appeared. I think it may be fixed by the patch of Bug 907965. But it introduces another one, bug 914068, reported by me, today.

I suggest that we wait for Tom to explain what's going on.

Comment 15

[Tom Herold]

I was able to locate the bug. I am working on a patch right now. Hopefully, I will have ready by tonight.

Comment 16

[John Hu [:johnhu][:johu][:醬糊小弟]]

Tom,

I think this one can be marked as won't fix. And the bug 914068 needs to be fixed by you. Because there is another patch for bug 907965 already changing it.

Comment 17

[Tom Herold]

Attachment: Link to Github pull request

Comment 18

[David Flanagan [:djf]]

Comment on attachment 802282 [details]
Link to Github pull request

r+ if you fix the nits on github.

Sorry I didn't catch this issue during the code review!

Comment 19

[David Flanagan [:djf]]

Landed to master: https://github.com/mozilla-b2g/gaia/commit/95ca5aa2d02b0c230633df5596fd7168de9c9cef

Comment 20

[Marcia Knous [:marcia]]

I don't see this happening on Buri device using:

Gaia   7b6147372cbf560744a02be50e0a862a825caef6
SourceStamp 63a505ec015c
BuildID 20130922004001
Version 26.0a2

Removing blocking nomination as this isn't an issue on the latest build.