913441 - Restore scrolling plugin temporarily

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Jeremie Patonnier :Jeremie]

What did you do?
================
1. Edit a page

What happened?
==============
The edit toolbar scroll with the whole page

What should have happened?
==========================
The edit toolbar should be stick to the top of the window and never scroll with the rest of the content

Is there anything else we should know?
======================================
This is a regression!

Comment 1

[Eric Shepherd [:sheppy]]

This really really needs to be fixed. It makes the editor extremely awkward bordering on impossible to use.

Comment 2

[David Walsh :davidwalsh]

I know we've spoken about this before, but what is the issue with using the "Maximize" button?

Comment 3

[Jean-Yves Perrier [:teoli]]

In maximize mode the page has a completely different width than the real one. Impossible to see the layout.

Comment 4

[John Karahalis [:openjck]]

One idea (and this is just an idea) comes to mind.

Right now, the editor has a dynamic height. It is always exactly as long as the article itself. What if we gave the editor a fixed height and a scrollbar instead? That way, the toolbar would always be on the screen, the scrolling behavior would be reasonable, and writers could still use the full-screen button for a full-screen experience.

Like this:
http://jsfiddle.net/cPpEK/embedded/result/

I know this would still not be ideal but it might be a nice stop-gap, solving /almost/ all problems, until we update the editor to look more like that of Google Docs as a long-term solution.

Comment 5

[Chris Mills [:cmills]]

That would work for me John.

Comment 6

[Jeremie Patonnier :Jeremie]

So do I, as long as we are avoiding double scrollbar in the page.

Comment 7

[John Karahalis [:openjck]]

This does not necessarily depend on bug 913565 -- we can correct this issue in the short-term while working on bug 913565 in the long-term.

Jeremie, can you please clarify what you mean by double scrolling? Would something like the following be undesirable?

http://jsfiddle.net/cPpEK/1/embedded/result/

Comment 8

[John Karahalis [:openjck]]

Actually, please ignore that link. Jeremie, would something like *this* be undesirable?

http://fiddle.jshell.net/cPpEK/1/show/light/

Comment 9

[Jeremie Patonnier :Jeremie]

Yes that exactly what I want to avoid (both links show some interesting mess with scrollbars)

Comment 10

[John Karahalis [:openjck]]

Therein lies the challenge. If the editing area were a small window, but the main scrollbar still controlled its contents, we would have the same problems we fixed in bug 780180.

We have two options for the size of the editor: it can either be small (as I show in my jsFiddle demo) or it can be big (as I propose in bug 913565). We also have two options for number of scrollbars: we can either have one scrollbar, or we can have two scrollbars.

Some combinations of these options work well, but some do not. A big editing area with one scrollbar works well (this is what Google Docs does). A small editing area with two scrollbars also works well (this is what MediaWiki does). But a small editing area with one scrollbar -- that's what caused the confusing and problematic behavior described in bug 780180.

Comment 11

[John Karahalis [:openjck]]

We are planning to temporarily re-enable the scrolling plugin. This will keep the editor buttons on the screen, but will also bring back the confusing and problematic scrolling behavior tracked in bug 780180.

There are three possible long-term solutions. All of these long-term solutions will keep the editor buttons while simultaneously providing sensible scrolling behavior. The three possibilities are:

1. Close this bug by making the editor a small box with a separate scrollbar.
2. Close bug 913565 by making the editor more like that of Google Docs.
3. Close this bug first (it's easy) and then close bug 913565 later as an even
   better solution.

Comment 12

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/1658fa4e5672746283eedbe1cc50fb8fc700d90d
fix bug 913441 - Put back the wiki edit scrolling behavior

https://github.com/mozilla/kuma/commit/cbb7a2572ac363d0b4c4d414065e94a6b147481f
Merge pull request #1350 from darkwing/sticky-header-913441

fix bug 913441 - Put back the wiki edit scrolling behavior

Comment 13

[John Karahalis [:openjck]]

I will open a separate bug for option 1 of comment 11, since that may be the best approach to solving the editor issues that cropped up in the redesign. Option 2 would take us far too long, and option 3 can be considered longer-term.