1040595 - English and translation text are not at the same height because of the CKEditor toolbar

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Localization, defect, P3)

Description

[Jean-Yves Perrier [:teoli]]

Attachment: A-B_C.jpg

This is a leftover bug 1032058.

Quoting Justin there:
"A) The main content body is not vertically aligned. "

Misalignment of both text make it harder to work. Dealing with the CKEditor toolbox will solve a good deal of it (not all as there may be misalignment due to different text size in paragraph, but this is a much more complex problem to deal with).

Comment 1

[[:Aleksej]]

Where was this fixed (see also bug 1048762)?

Comment 2

[David Walsh :davidwalsh]

Reopening as I cannot identify the date/commit it was fixed.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/b6ae7b1ec508731729e0a210e77e59202f604053
Bug 1040595: Add padding to top of English (#4528)

- add padding to the top of the English display matching approximate
  height of the toolbar on the translation side
- move `.text-content` to different element so headings identifying
  English and French translations match style

Comment 5

[Schalk Neethling [:espressive]]

Attachment: Screenshot 2018-10-15 at 18.46.43.png

Comment 6

[Schalk Neethling [:espressive]]

Attachment: Screenshot 2018-10-15 at 18.46.53.png

Comment 7

[Schalk Neethling [:espressive]]

This looks to be fixed ^^

Comment 8

[John Whitlock [:jwhitlock]]

Attachment: bug 1040595 - JS Array forEach translation.png

After the change, the start of content is aligned when translating: 

https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Objets_globaux/Array/forEach

It does not stay aligned as you scroll, but we need to update our document structure to know how to do that sort of alignment.