enable position:sticky in non-release builds (e.g. Nightly and Aurora)

RESOLVED FIXED in mozilla27

Status

()

defect
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: coyotebush, Assigned: coyotebush)

Tracking

({dev-doc-complete})

Trunk
mozilla27
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [DocArea=CSS])

Attachments

(1 attachment)

The initial implementation of sticky positioning in bug 886646 hides it behind the preference "layout.css.sticky.enabled". Once the implementation is more complete, this preference should be enabled by default.
Version: unspecified → Trunk
Depends on: 904197
It's been pointed out to me that we likely shouldn't enable the preference by default in release versions, at least, until the specification is better standardized. So maybe once those blocking bugs are fixed it should be enabled only #ifndef RELEASE_BUILD ?
That sounds reasonable. (That's what we did for @supports when its spec was under-development, in bug 814530. The patch here should probably look very much like the patch on that bug.)
One other interesting issue mentioned in https://code.google.com/p/chromium/issues/detail?id=145027 is whether there's something interesting to say or fix about nested position:sticky elements.
(In reply to David Baron [:dbaron] (needinfo? me) (busy through Sept. 14) from comment #3)
> nested position:sticky elements

work just fine in Gecko and WebKit. (Perhaps a sticky-top header inside a sticky-bottom section, though I'm not certain where that would realistically be useful.)
Predictably enough, this is the patch to do that.
Attachment #803981 - Flags: review?(dholbert)
Comment on attachment 803981 [details] [diff] [review]
Enable position:sticky on Nightly and Aurora.

r=me

Did you still want to wait for the blocking bugs to be fixed before landing this, per comment 1, or did you want to land this sooner?

(Seems like we might as well wait, since it looks like they're close to being fixed, but I'm open to just landing this, too.)
Attachment #803981 - Flags: review?(dholbert) → review+
Yeah, might as well wait for those.
Summary: enable position:sticky → enable position:sticky on Nightly/Aurora
A final try run to make sure this doesn't break anything else:
https://tbpl.mozilla.org/?tree=Try&rev=c29ac5d62b81
[needinfo=me to make sure this gets landed after the Try run completes.]
Flags: needinfo?(dholbert)
The bugs marked as blocking this have now landed, so I landed this:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/2d033c301dfd

(I also clarified the commit message slightly, to avoid giving the impression that this is enabling position:sticky in _current_ Aurora builds.)
Flags: needinfo?(dholbert) → in-testsuite-
Summary: enable position:sticky on Nightly/Aurora → enable position:sticky in non-release builds (e.g. Nightly and Aurora)
https://hg.mozilla.org/mozilla-central/rev/2d033c301dfd
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Whiteboard: [DocArea=CSS]
Depends on: 926155
Depends on: 1199991
You need to log in before you can comment on or make changes to this bug.