902992 - enable position:sticky in non-release builds (e.g. Nightly and Aurora)

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Corey Ford [:coyotebush]]

The initial implementation of sticky positioning in bug 886646 hides it behind the preference "layout.css.sticky.enabled". Once the implementation is more complete, this preference should be enabled by default.

Comment 1

[Corey Ford [:coyotebush]]

It's been pointed out to me that we likely shouldn't enable the preference by default in release versions, at least, until the specification is better standardized. So maybe once those blocking bugs are fixed it should be enabled only #ifndef RELEASE_BUILD ?

Comment 2

[Daniel Holbert [:dholbert]]

That sounds reasonable. (That's what we did for @supports when its spec was under-development, in bug 814530. The patch here should probably look very much like the patch on that bug.)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

One other interesting issue mentioned in https://code.google.com/p/chromium/issues/detail?id=145027 is whether there's something interesting to say or fix about nested position:sticky elements.

Comment 4

[Corey Ford [:coyotebush]]

(In reply to David Baron [:dbaron] (needinfo? me) (busy through Sept. 14) from comment #3)
> nested position:sticky elements

work just fine in Gecko and WebKit. (Perhaps a sticky-top header inside a sticky-bottom section, though I'm not certain where that would realistically be useful.)

Comment 5

[Corey Ford [:coyotebush]]

Attachment: Enable position:sticky on Nightly and Aurora.

Predictably enough, this is the patch to do that.

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 803981 [details] [diff] [review]
Enable position:sticky on Nightly and Aurora.

r=me

Did you still want to wait for the blocking bugs to be fixed before landing this, per comment 1, or did you want to land this sooner?

(Seems like we might as well wait, since it looks like they're close to being fixed, but I'm open to just landing this, too.)

Comment 7

[Corey Ford [:coyotebush]]

Yeah, might as well wait for those.

Comment 8

[Corey Ford [:coyotebush]]

A final try run to make sure this doesn't break anything else:
https://tbpl.mozilla.org/?tree=Try&rev=c29ac5d62b81

Comment 9

[Daniel Holbert [:dholbert]]

[needinfo=me to make sure this gets landed after the Try run completes.]

Comment 10

[Daniel Holbert [:dholbert]]

The bugs marked as blocking this have now landed, so I landed this:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/2d033c301dfd

(I also clarified the commit message slightly, to avoid giving the impression that this is enabling position:sticky in _current_ Aurora builds.)

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2d033c301dfd

Comment 12

[Jean-Yves Perrier [:teoli]]

The compat table of
https://developer.mozilla.org/en-US/docs/MDN/Contribute/Tools_with_restricted_access
has been updated.
https://developer.mozilla.org/en-US/Firefox/Releases/27#CSS , too.