Closed Bug 916661 (app-auth-dialog) Opened 6 years ago Closed 6 years ago

[Window Management] Refactor Authentication Dialog in AppWindow submodule

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alive, Assigned: gasolin)

References

Details

Attachments

(1 file)

See Modal Dialog rewrite work.
Also this blocks bug 913323 - Remove origin reference.
Assignee: nobody → gduan
Component: Gaia::System → Gaia::System::Window Mgmt
No longer blocks: task-manager
This would be fixed if bug 907013 lands.
Alias: app-auth-dialog
Assignee: gduan → alive
Assignee: alive → gasolin
Summary: [Window Management] Rework Authentication Dialog in AppWindow submodule → [Window Management] Refactor Authentication Dialog in AppWindow submodule
1. use 'render' instead of '_fetchElements' to align modal dialog
2. polish the template
Attachment #8347149 - Flags: review?(alive)
Comment on attachment 8347149 [details] [review]
pull request redirect to github

*dialog is inherited from baseUI.js
And that's why there's _fetchElements() but no render().
I don't understand what's the purpose of this patch.
Attachment #8347149 - Flags: review?(alive)
Comment on attachment 8347149 [details] [review]
pull request redirect to github

Use _fetchElements() instead and add jsdoc in BaseUI
Attachment #8347149 - Flags: review?(alive)
Comment on attachment 8347149 [details] [review]
pull request redirect to github

BTW neither this nor bug 916660 really fix the original issue. I wonder you should open polish bug...
Attachment #8347149 - Flags: review?(alive) → review+
Please file new bug for patch of this + patch of 916660. Leave this opened.
Blocks: 950583
merged to https://github.com/mozilla-b2g/gaia/commit/1a93d91d8ae4ec3295cee6ee382ed11ee1c9d2bf

let's add some clear purpose bug for remove modal_dialog.js and the `origin` reference
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.