916661 - (app-auth-dialog) [Window Management] Refactor Authentication Dialog in AppWindow submodule

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

See Modal Dialog rewrite work.
Also this blocks bug 913323 - Remove origin reference.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

This would be fixed if bug 907013 lands.

Comment 2

[[e-mail]]

Attachment: pull request redirect to github

1. use 'render' instead of '_fetchElements' to align modal dialog
2. polish the template

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8347149 [details] [review]
pull request redirect to github

*dialog is inherited from baseUI.js
And that's why there's _fetchElements() but no render().
I don't understand what's the purpose of this patch.

Comment 4

[[e-mail]]

Comment on attachment 8347149 [details] [review]
pull request redirect to github

Use _fetchElements() instead and add jsdoc in BaseUI

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8347149 [details] [review]
pull request redirect to github

BTW neither this nor bug 916660 really fix the original issue. I wonder you should open polish bug...

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Please file new bug for patch of this + patch of 916660. Leave this opened.

Comment 7

[[e-mail]]

merged to https://github.com/mozilla-b2g/gaia/commit/1a93d91d8ae4ec3295cee6ee382ed11ee1c9d2bf

let's add some clear purpose bug for remove modal_dialog.js and the `origin` reference