917776 - The Custom Menu should not be accessible while in edit mode

Status: RESOLVED DUPLICATE of bug 918007

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Adrian Tamas (:AdrianT)]

Attachment: screenshot

Aurora 26.0a2 2013-09-18
Samsung Galaxy Tab 2 (Android 4.1.1)

Steps to reproduce:
1) Load any website. For e.g. news.google.com
2) Tap on the url bar to open about:home
3) Tap on the url bar again to open edit mode
4) Tap on the Custom menu

Expected results:
The Custom menu is not opened

Actual results:
The Custom menu is opened. Also because of this bug 795437 is still reproducible. Fixing this should solve this issue when in about:home

Comment 1

[Aaron Train [:aaronmt]]

Dupe of bug 807186?

Comment 2

[Adrian Tamas (:AdrianT)]

(In reply to Aaron Train [:aaronmt] from comment #1)
> Dupe of bug 807186?

Probably not since this has to do with the rewrite of about:home. Also the Custom Menu issue is just one of the effects. I can also interact with the page loaded in the tab like sharing the link, saving as pdf etc and also opening new tabs from edit mode

Comment 3

[Lucas Rocha (:lucasr)]

Bug 918007 is another symptom of the same issue.

Comment 4

[Lucas Rocha (:lucasr)]

Taking this one as I'll be working on bug 918007 too.

Comment 5

[Ian Barlow (:ibarlow)]

How do we feel about disabling (greying out) other title bar controls when the URL bar is focused? Seems like a simpler way of avoiding some of these weird mixed states.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Ian Barlow (:ibarlow) from comment #5)
> How do we feel about disabling (greying out) other title bar controls when
> the URL bar is focused? Seems like a simpler way of avoiding some of these
> weird mixed states.

Or we could just hide them. Graying out could be too subtle.

Comment 7

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #6)
> (In reply to Ian Barlow (:ibarlow) from comment #5)
> > How do we feel about disabling (greying out) other title bar controls when
> > the URL bar is focused? Seems like a simpler way of avoiding some of these
> > weird mixed states.
> 
> Or we could just hide them. Graying out could be too subtle.

This might make the toolbar look kida broken. But I'll try this option too.

Comment 8

[Ian Barlow (:ibarlow)]

Lucas and I tried a greyed out icon version last week that worked quite nicely.