918270 - findbar.xml, line 263: this._browser.finder is undefined, Finder.jsm, line 19: docShell.getInterface is not a function

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Magnus Melin [:mkmelin]]

So since a few days back we get this

JavaScript error: chrome://global/content/bindings/findbar.xml, line 263: this._browser.finder is undefined
JavaScript error: resource://gre/modules/Finder.jsm, line 19: docShell.getInterface is not a function

Should be from bug 666816.
SeaMonkey fixed it in bug 916477. 

I don't know if it actually breaks something? The find bar seems to be working.

Comment 1

[Tom S [:evilpie]]

I don't see how the findbar could work without this, we abort in the middle of the initialization process. Why is there no finder property on the browser? Is this maybe yet an other <browser> implementation?

Comment 2

[:aceman]

But it really works (in the message pane, also when message is in separate window and also in the message source window). It seems to be the new findbar with the 2 arrow buttons attached to the inputbox, that fades in when invoked.

Comment 3

[Tom S [:evilpie]]

I guess you could search, but the findbar wouldn't show if something is found/not found.

Comment 4

[:aceman]

It highlights results fine.

Comment 5

[Tom S [:evilpie]]

Do you also see the red background in the search field if there is no match?

Comment 6

[Magnus Melin [:mkmelin]]

Yes, the background of the search field gets red if there's no match.

Comment 7

[:aceman]

Yes.

Comment 9

[ISHIKAWA, Chiaki]

I am still seeing this warning/error in the |make mozmill| test suite run of comm-central TB.
(I refreshed the source the day before.)

The bug is near the top of the most frequennt Javascript strict error/warning in the log:
The number at the beginning of the line is the frequency of appearances:

  55 JavaScript strict warning: chrome://messenger/content/tabmail.xml, line 352: reference to undefined property aTabType.panelId
     55 JavaScript strict warning: chrome://global/content/bindings/tree.xml, line 50: reference to undefined property this.treeBoxObject.columns
**   55 JavaScript strict warning: chrome://global/content/bindings/findbar.xml, line 262: reference to undefined property this._browser.finder
**   35 JavaScript error: chrome://global/content/bindings/findbar.xml, line 262: this._browser.finder is undefined
     12 JavaScript strict warning: chrome://messenger/content/newmailaccount/jquery.tmpl.js, line 123: reference to undefined property def[1]
     11 JavaScript strict warning: chrome://global/content/bindings/tree.xml, line 53: reference to undefined property this.treeBoxObject.view
      3 JavaScript strict warning: chrome://messenger/content/nsContextMenu.js, line 102: reference to undefined property this.onEditableArea
      1 JavaScript strict warning: resource:///modules/dbViewWrapper.js, line 1046: reference to undefined property this._underlyingFolders[0]


If Javascript interpreter says it is undefined, something spooky is going on,
and I hate to see a mail client going haywire because of the "browser" feature :-)
We can always use FF for browsing, no?

Comment 10

[Magnus Melin [:mkmelin]]

I tracked this down to coming from http://mxr.mozilla.org/comm-central/source/mail/components/im/content/chat-messenger-overlay.xul#241

... so convbrowser.xml needs fixing.

Comment 11

[Florian Quèze [:florian]]

Looks like we need to port https://hg.mozilla.org/mozilla-central/diff/295578d99074/toolkit/content/widgets/browser.xml

Comment 12

[Axel Grude [:realRaven]]

I have seen this problem on Tb beta 27.0 when I was using Source (HTML) view (from the Stationery Addon) and used "Find..." from the context menu.

Comment 13

[:aceman]

Somehow I do not see the message anymore in current trunk (previously I got it at each TB start).

Comment 14

[Patrick Cloke [:clokep]]

This was fixed by bug 959523 in https://hg.mozilla.org/comm-central/rev/95758315e5a1