91919 - Crash on CMS 4.2 cert server.

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P1)

Description

[John Unruh]

7/23 commerical branch build - all platforms.
1.) Visit the above in-house URL
2.) In the left column, click on "Driectory"
Crash on all platforms. Talkback ID:
http://cyclone/reports/SingleIncidentInfo.cfm?dynamicBBID=33235221

Comment 1

[John Unruh]

Adding crash keyword.
Mac Talkback ID : 
http://cyclone/reports/SingleIncidentInfo.cfm?dynamicBBID=33236291

Comment 2

[Paul Wyskoczka]

Adding nebeta1 keyword

Comment 3

[Javier Delgadillo]

This crash doesn't appear to be SSL related.  Can you access this same page via
a non-https URL and see if it crashes as well?

Incident ID 33236291
Stack Signature nsFixedSizeAllocator::AllocatorMakeBlock() 9731b744
Bug ID
Trigger Time 2001-07-23 09:58:49
User Comments
Build ID 2001072303
Product ID Netscape6.10
Platform ID MacOS
Stack Trace
nsFixedSizeAllocator::AllocatorMakeBlock() [nsFixedSizeAllocator.cp]
malloc() [nsAllocatorManager.cp]
calloc() [nsAllocatorManager.cp]
PR_Calloc() [prmem.c, line 48]
GlobalWindowImpl::SetTimeoutOrInterval() [nsGlobalWindow.cpp, line 3236]
GlobalWindowImpl::SetTimeout() [nsGlobalWindow.cpp, line 2084]
CODE.10
XPTC_InvokeByIndex() [xptcinvoke_mac.cpp, line 129]
XPCWrappedNative::CallMethod() [xpcwrappednative.cpp, line 1880]
XPC_WN_CallMethod() [xpcwrappednativejsops.cpp, line 1252]
js_Invoke() [jsinterp.c, line 801] 

Comment 4

[John Unruh]

Since this is a CMS 4.2 server, you cannot access it insecurely. Also, even 
right-clicking on the link causes a crash, if you can get that far.

Comment 5

[lchiang]

john, when was the last build this worked in?
This is a common cert server?

Comment 6

[John Unruh]

The last build where this worked was on 7/20.
The common file that appears in bot Mac and Windows talkback IDs seems to be 
nsGlobalWindow.cpp

Comment 7

[Stephane Saux]

->javi
P1
t->2.0
Javi, 

Comment 8

[lchiang]

cc: some folks who recently changed nsGlobalWindow.cpp for some ideas.

javi or junruh: Is this cert server a common one?   If so, this could be a
future topcrash bug.

Comment 9

[John Unruh]

The cert server is the latest Netscape Certificate Management System. 

Comment 10

[John Unruh]

The CMS 4.22 server also has an insecure port, and the branch build crashes 
there also - http://junruh.mcom.com:1024/
lchiang, can you reassign to the proper person?

Comment 11

[chris hofmann]

> The last build where this worked was on 7/20.
I can confirm that this works in my build from...
Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.2) Gecko/20010720 Netscape6/6.1

Comment 12

[lchiang]

John, can you see if the problem is there on the 21 or 22nd build? That'll help
narrow down so I can email folks who checked in on either 20th, 21, or 22.  Thanks

Comment 13

[John Unruh]

The crash was there on the build of the 21st. See my above comment "The last 
build where this worked was on 7/20.".

Comment 14

[chris hofmann]

Stop the presses!  Two regressions occurred on 7/20.  This is one of them.  It
might be worth investigating interaction with bug fix 55459.

Comment 15

[Javier Delgadillo]

Over to jst, he checked in code on the branch that may be causing this.

Comment 16

[Johnny Stenback (:jst)]

I highly doubt my changes caused this crash (but I could of course be wrong),
could someone try backing out jag's fix for bug 91788 and see if this crash goes
away? Jag, could you try? I'm updating my tree right now and I will try this
once I have a build unless someone beats me to it.

Comment 17

[Johnny Stenback (:jst)]

jag, see my last comment.

Comment 18

[jag (Peter Annema)]

Crashed with my patch backed out.

Comment 19

[selmer (gone)]

Johnny, any progress seeing if 55459 was the actual cause of this?

Comment 20

[Johnny Stenback (:jst)]

Attachment: Proposed fix

Comment 21

[jag (Peter Annema)]

I've tested this patch on this bug, bug 91950 and bug 55459 and they all work
fine now. jst's explanation of why that check needs to be removed makes sense.
r=jag fwiw.

Comment 22

[selmer (gone)]

Great Job!  Let's get this puppy checked in!!

Comment 23

[Blake Ross]

rs=blake

Comment 24

[Eric Pollmann]

r=pollmann, this looks like the right fix!

Comment 25

[Johnny Stenback (:jst)]

Fix checked in, marking fixed.

Comment 26

[John Unruh]

Verified on branch 7/24 commercial Win98, WinTN, Mac and Linux builds.

Comment 27

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Did this also fix bug 68488?

Comment 28

[David P. Drinan]

*** Bug 91567 has been marked as a duplicate of this bug. ***