Closed Bug 91950 Opened 24 years ago Closed 24 years ago

crash when Saving Image from displayed page

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
Windows 98
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: hamerly, Assigned: mjudge)

References

(
URL
)

Details

(Keywords: crash, Whiteboard: PDT+)

Attachments

(1 file)

Crash Stack (Talkback Info on Mac)
825 bytes, text/plain
Details
(1) Load web page with images (e.g. home.netscape.com) (2) Right-click over an image and select "Save Image", save to file Result: file saved successfully, but application crashes I have repro'd this bug with numerous web pages as well as standalone images in numerous format (.gif, .jpg, etc.).
worksforme with build 20010723.. (trunk) Reporter: Please include in all your bug reports your build ID !
I was able to reproduce this using 2001-07-22 commercial branch on Win98 and WinNT. I crash when I use the context menu to save an image ("Save Image (image name) ...") or when I use the context menu to open the image in a new browser window, and then use the file menu ("File | Save as ...") to save the image. Note that the image *is* saved successfully. Note also that I can embed the image in a new composer page, and save that composer page without crashing.
The Talkback incididents for my crashes are similar on Win98 and NT. Win98 (incidents 33244390 and 33244255): GlobalWindowImpl::DropTimeout [d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp, line 3568] nsGlobalWindow_RunTimeout [d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp, line 3717] nsTimer::Fire [d:\builds\seamonkey\mozilla\widget\timer\src\windows\nsTimer.cpp, line 196] FireTimeout [d:\builds\seamonkey\mozilla\widget\timer\src\windows\nsTimer.cpp, line 78] KERNEL32.DLL + 0x2317 (0xbff72317) FireTimeout [d:\builds\seamonkey\mozilla\widget\timer\src\windows\nsTimer.cpp, line 51] USER32.DLL + 0x3bb5 (0xbfc03bb5) 0x278c0003 0xfa76ff66 WinNT (incident 33244700) GlobalWindowImpl::DropTimeout [d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp, line 3568] nsGlobalWindow_RunTimeout [d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp, line 3717] nsTimer::Fire [d:\builds\seamonkey\mozilla\widget\timer\src\windows\nsTimer.cpp, line 196] FireTimeout [d:\builds\seamonkey\mozilla\widget\timer\src\windows\nsTimer.cpp, line 78] USER32.dll + 0x185c (0x77e7185c) nsAppShellService::Run [d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp, line 426] netscp6.exe + 0x16f0 (0x004016f0) netscp6.exe + 0x11b8 (0x004011b8) netscp6.exe + 0x3243 (0x00403243) KERNEL32.dll + 0x1ba06 (0x77f1ba06)
related to bug 79920 ? based on the stack -> Dom0
Component: Image Conversion Library → DOM Level 0
Keywords: crash
I'm seeing this crash on Mac, but only when I do something after the save, specifically, opening a Mail window for the time. I'll post a stack, if it's a different bug, I'll file mine seperately, but the steps to reproduce sound the same. Build: 2001-07-23-03-0.9.2 mac OS 9.1
Waterson - my crash's stack lies in your code, am I indeed seeing the same bug, just exhibiting different side-effects platform-wise?
Tested on the following: Win: 07_23_06_0.9.2 (Tested on Win98) Mac: 07_23_03_0.9.2 (Tested in Mac os 9) Linux: 07_23_04_0.9.2 Crashes on Win98. Cannot reproduce on Mac or Linux. Stack Trace: GlobalWindowImpl::DropTimeout [d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp, line 3568] nsGlobalWindow_RunTimeout [d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp, line 3717] nsTimer::Fire [d:\builds\seamonkey\mozilla\widget\timer\src\windows\nsTimer.cpp, line 196] nsTimerManager::FireNextReadyTimer [d:\builds\seamonkey\mozilla\widget\timer\src\windows\nsTimerManager.cpp, line 117] nsAppShell::Run [d:\builds\seamonkey\mozilla\widget\src\windows\nsAppShell.cpp, line 118] nsAppShellService::Run [d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp, line 426] NETSCP6.EXE + 0x16f0 (0x004016f0) NETSCP6.EXE + 0x11b8 (0x004011b8) NETSCP6.EXE + 0x3366 (0x00403366) KERNEL32.DLL + 0x1b537 (0xbff8b537) KERNEL32.DLL + 0x1b3e9 (0xbff8b3e9) KERNEL32.DLL + 0x19dac (0xbff89dac) Will test on Win2000 and WinNT and report results
FWIW - I sent myself an image as an email attachment. The image was a JPEG (the same JPEG that crashed the browser). I opened the email message, and right clicked on the image in the email attachment pane. I chose "Save As ..." from the menu, and successfully saved the image without crashing. I then went back to the email message, right-clicked on the attached image, and opened the image in a browser window. I then tried to save the image from the browser (using "File | Save as ... ") from the browser file menu. This time, I crashed.
PDT+ for quick investigation of problem. We'd like to see the patch before approving a checkin. Thanks!!!
Whiteboard: PDT+
Can someone try to see if this is ok on the 20th build (branch)? Thanks.
fyi: It works fine using 7-20 BRANCH builds. And I'm able to duplicate the crash using todays BRANCH builds on win 2K. Adding jst to cc list as the crash occurs in nsGlobalWindow.
Stop the presses! Two regressions occurred on 7/20. This is one of them. It might be worth investigating interaction with bug fix 55459.
Could someone who has a up-to-date branch tree try backing out jag's fix that went in for bug 91788 and see if this crash goes away? Jag, could you try?
changing qa contact to desale. I was able to reproduce crash on Mac as well as WinNT and Win2000 with 7/23 branch build.
QA Contact: tpreston → desale
Still crashing without my patch.
We need to try and fix this tonight, because it is getting reported in other dupes such as bug 91996.
Johnny, chofmann's post indicates this started crashing on 7/20. 91788 didn't get checked in until yesterday. Did anyone try backing out 55459?
This *should* be fixed with my checkin for bug 91919, but I was never able to reproduce this crash so I can't say for sure.
Just checked this bug with 2001-07-24 commercial branch on Win98, and it looks fixed to me! I tried saving an image from the context menu - image saved correctly and no crash. I then viewed an image (using context menu "View Image") then saved the image using Navigator file menu (File | Save as ...). The image saved correctly and no crash.
Marking fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verified with 2001-07-24-06 branch.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: