920414 - [User Story] Display a message at the end of a call (FFOS 1.3)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Wilfred Mathanaraj [:WDM]]

User story:

As a user I want to be informed with a simple screen when a call has ended.

Acceptance Criteria:

AC9.1 I want the call ended modal screen not to contain any detailed information than simple text saying "call ended".

AC9.2 I want this information to be displayed for 2 seconds after the call has ended.

AC9.3 when in a conference call I want only the message to display when last participant has left the call or in as the conf call owner, hang up the call.

Comment 2

[Al Tsai [:atsai]]

Steal the in-moztrap? flag and start to analysis the user story

Comment 3

[Al Tsai [:atsai]]

#10558, #10559

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

ni? jsavory on UX spec

Comment 5

[Jacqueline Savory [:jsavory] UX]

Attachment: Dialer_JS_131015.pdf

I've attached the most recent version of the wireframes for this story to the bug, please let me know if there are any questions.

Comment 6

[Al Tsai [:atsai]]

So, follow the design, will the contacts app use the same layout (Name + Portrait) to display?

Comment 7

[Paul Yang [:pyang] (away)]

Contact app & call log dialer app doesn't show picture in thread list view.  Please help to confirm if we add this design in v1.3

Comment 8

[Paul Yang [:pyang] (away)]

(In reply to Paul Yang [: pyang] from comment #7)
> Contact app & call log dialer app doesn't show picture in thread list view. 
> Please help to confirm if we add this design in v1.3

Just flash latest master and see it is there.

Comment 9

[Paul Yang [:pyang] (away)]

Clean ni? since issue solved

Comment 10

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Working on a WIP.
I'm not sure if showing "Call ended" directly (p.10) on hanging conference call is easy to implement.. since when ending conference call, the last two call remaining in conference is moved out to normal call on mozTelephony and therefore the dialer reacts against events and move these calls out too. I'm still investigating a good idea for this.

For p.9 and p.11 I have an initial version now.

Comment 11

[KM Lee [:rexboy] (inactivate after Sep. 22)]

For ending conference call in p.10, can we just show arbitrary one of those phones inside conference call rather than showing group? As mentioned in comment 10, the last call in conference call always come back to normal call before it's hanged up, so it would be much easier if we just keep the same state with it.

Jsavory may you give some input on this?

Comment 12

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: WIP Screenshot

WIP code:
https://github.com/rexboy7/gaia/commit/eea8f9ee373ef709d9484c7b927a56c43e7c9599

Comment 13

[Jacqueline Savory [:jsavory] UX]

I worry that if the user is suddenly brought from a group call to an ended single call, it may appear very confusing. This may cause the user to assume that they hung up on a individual who was calling them when they did not intend to. 

I feel that it would be a much better experience if the user can, in some manner, see that they have ended their conference call and not one with an individual. Is there any way to make this possible?

Comment 14

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Alright, I have a light on implementing it. Let me try on it.
I'll put an updated patch later. It may need some confirmation with reviewer though.

Comment 15

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

Finally arranged a patch here.
I may need some opinion since this patch changed behavior of CallScreen.SingleLine to make the 2-second lasting possible, see detail comments in Github.
Hello Etienne, would you mind reviewing this patch? 


I tested with some cases including
1. Hang-up single call
2. Hang-up single conference call
3. Hang-up double call
4. Hang-up conference call while there's another call is on hold
5. continuing 4, join the remaining call into conference call and hang up again
6. When incoming call arrives, choose hang-up active call

And they seems works well (as what I imagined). I can take some movie for its reaction if required.

Comment 16

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Oh, almost forgot to mention...
I've found a mozTelephony bug which affects the patch, opened in bug 936982.
It causes the last call exiting conference call goes back to connected status even it's already been hanging up.
I wrote some workaround in the patch for that.

Comment 17

[Etienne Segonzac (:etienne)]

Comment on attachment 830133 [details]
patch

Comments are on github, hope I covered everything.

Comment 18

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thanks for the detailed review, Etienne!

Finished most of them but the .duration position of isTimer of multi-call mode... I'll take care of it on Monday.

Comment 19

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 830133 [details]
patch

OK, changes are inside another commit.

Etienne may you take a look again?

Comment 20

[Etienne Segonzac (:etienne)]

Comment on attachment 830133 [details]
patch

Added a few comments on github but all test-related so we're very close to landing :)

Comment 21

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 830133 [details]
patch

Minor changes per discussion on github.

I'll squash all commits before landing. Thanks!

Comment 22

[Etienne Segonzac (:etienne)]

Comment on attachment 830133 [details]
patch

All good!

We'll probably want some special QA attention for this since it's a big change.

Comment 23

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thanks for all the helping Etienne!

landed in master. There are some rebase work to deconflict with patch of bug 923646 before merging.
https://github.com/mozilla-b2g/gaia/commit/e8fc65323606c4b0df848c23b13a483d0da37baf