921606 - Odd "New Messages" folder color on Aero

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Joe Sabash [:JoeS1]]

Recent theme changes resulted in this odd color display
See URL

Comment 1

[Josiah Bruner [:jsbruner]]

Attachment: Potential Fix

Not tested (Don't have a Windows machine), but this should fix the inconsistency.

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 811544 [details] [diff] [review]
Potential Fix

Review of attachment 811544 [details] [diff] [review]:
-----------------------------------------------------------------

The folder with new message uses now -moz-hyperlinktext but the server is still blue.

I propose you add this full block to folderPane-aero.css:

  treechildren::-moz-tree-cell-text(folderNameCol, biffState-NewMail, isServer-true),
  treechildren::-moz-tree-cell-text(folderNameCol, newMessages-true),
  treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true) {
    color: -moz-hyperlinktext;
  }

this would also make the reading easier.

Comment 3

[Josiah Bruner [:jsbruner]]

Attachment: Fix.

Oh yes. Good idea.

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 811555 [details] [diff] [review]
Fix.

Review of attachment 811555 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the nits addressed.

::: mail/themes/windows/mail/folderPane-aero.css
@@ +9,5 @@
> +  treechildren::-moz-tree-cell-text(folderNameCol, newMessages-true),
> +  treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true) {
> +    color: -moz-hyperlinktext;
> +  }
> +  

Trailing whitespace

@@ +15,5 @@
>    treechildren::-moz-tree-cell-text(folderNameCol, newMessages-true, selected),
>    treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true, selected) {
>      color: -moz-hyperlinktext;
>    }
>    

Trailing whitespace. Not introduced by you, but could you remove it too?

Comment 5

[Josiah Bruner [:jsbruner]]

Attachment: Fix. r=Paenglab

Done. Thanks Richard!

Comment 6

[Joe Sabash [:JoeS1]]

(In reply to Richard Marti [:Paenglab] from comment #2)

> The folder with new message uses now -moz-hyperlinktext but the server is
> still blue.

Yes, but what is funny about that text (using a dropper tool PSP 8) The characters seem to be fringed by a different shade of blue. IE RGB 131,134,248 Maybe my screenshot is a lossy image.

Comment 7

[Joe Sabash [:JoeS1]]

It might be my problem, but the latest patch doesn't apply for me on current trunk

Comment 8

[Josiah Bruner [:jsbruner]]

(In reply to Joe Sabash from comment #7)
> It might be my problem, but the latest patch doesn't apply for me on current
> trunk

Make sure you don't have the obsolete patch applied by accident. I just checked and it applies fine on trunk.

Comment 9

[Richard Marti (:Paenglab)]

It doesn't apply because you removed the whitespaces by hand. The second needs also patch commands to remove it.

Cleared the c-n.

Comment 10

[Josiah Bruner [:jsbruner]]

Attachment: Fix. r=Paenglab

*There* we go.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/3e749f598dd4