923449 - [User Story] Single variant: Network Display Indicator customization by SIM

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Marcelino Veiga Tuimil [:sonmarce]]

As an Operator I want to change Network Display Indicator icon depending on the country, so that they are adapted to local standards

Acceptance criteria:
* Network Display Indicator icon will be configured per each MCC/MNC after inserting a new SIM card
* For example, depending on the country, LTE could be displayed as LTE, 4G, ...
* These are all the current options:
 | Icon Type | Description      |
 | 4G        | 4G LTE & 4G CDMA |
 | H+        | 3.5G HSPA+       |
 | H         | 3.5G HSDPA       |
 | Ev        | 3G CDMA          |
 | 3G        | 3G UMTS          |
 | E         | EDGE             |
 | 2G        | GPRS             |
 | 1x        | 2G CDMA          |
* There will be default values for the case of no Network Display Indicator icon is configured for a MCC/MNC

Comment 1

[Marcelino Veiga Tuimil [:sonmarce]]

Updated following acceptance criteria:
* Network Display Indicator icon will be configured per each MCC/MNC after inserting a new SIM card for the first time
* There will be a default value for the case of no Network Display Indicator icon is configured for a MCC/MNC or no SIM card inserted
* Replacing or removing SIM card later on will imply no change in Network Display Indicator icon
* After a factory reset, Network Display Indicator icon will be configured the same process as a brand new device

Also started to use the new User Story field

Comment 2

[Carmen Jimenez Cabezas]

Attachment: Proposed patch v1

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8371538 [details] [review]
Proposed patch v1

looks ok

Comment 4

[rafael.marquez]

I'm reviewing all pending System US and I have a question about how I can check this US. Does anyone know, how can I force the signal 2g, 3g, 4g ... to verify the value?

Comment 5

[Beatriz Rodríguez [:brg]]

Settings -> cellular and data -> Network operator ->Network type

Comment 6

[rafael.marquez]

OK,Thanks Beatriz

Comment 7

[Carmen Jimenez Cabezas]

Travis is failing (https://travis-ci.org/mozilla-b2g/gaia/builds/18352975) but after double checking, this patch doesn't touch any of the files that the failing tests use. So I'm going to checkin this and open a follow up bug to fix the broken tests.

Comment 8

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/gaia/commit/3b0bc1c5dbd09cdb84dfa492b49dc3403b945020

Comment 9

[Carmen Jimenez Cabezas]

I'm very sorry. I've mixed up this bug with another one on which I already have Jordano's r+. Rollbacked the merge to wait for the r+.

Comment 10

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/gaia/commit/bace9272f686d2142ce5617fa8cbd2e6393f316b

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Do we have a new PR?

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8371538 [details] [review]
Proposed patch v1

I've been reviewing the (merged) PR and looks fine to me.

Adding the r+, if you need another PR please carry over the two reviews from Alive and myself.

Thanks for the work!

Comment 13

[Carmen Jimenez Cabezas]

Attachment: Proposed patch v2

Comment 14

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/gaia/commit/4f410b684d7768efbee0bf95af723c1f06c4be6c

Comment 15

[rafael.marquez]

Verified in master (1.4)branch. Good job. US without bugs.
The test will be sent to import them in moztrap

The acceptance criteria "Predictive text setting will be configured per each MCC/MNC after inserting a new SIM card for the first time" will be developed and tested in v1.5. After talking with the organization we have decided to close the US although this development is pending. A bug will be create