Closed Bug 923449 Opened 7 years ago Closed 6 years ago

[User Story] Single variant: Network Display Indicator customization by SIM

Categories

(Firefox OS Graveyard :: Gaia::System, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

VERIFIED FIXED
1.4 S1 (14feb)

People

(Reporter: sonmarce, Assigned: macajc)

References

Details

(Keywords: feature, Whiteboard: [ucid:System97, systemsfe][systemsfe])

User Story

As an Operator I want to change Network Display Indicator icon depending on the country, so that they are adapted to local standards

Acceptance criteria:
* Network Display Indicator icon will be configured per each MCC/MNC after inserting a new SIM card for the first time
* For example, depending on the country, LTE could be displayed as LTE, 4G, ...
* These are all the current options:
 | Icon Type | Description      |
 | 4G        | 4G LTE & 4G CDMA |
 | H+        | 3.5G HSPA+       |
 | H         | 3.5G HSDPA       |
 | Ev        | 3G CDMA          |
 | 3G        | 3G UMTS          |
 | E         | EDGE             |
 | 2G        | GPRS             |
 | 1x        | 2G CDMA          |
* There will be a default value for the case of no Network Display Indicator icon is configured for a MCC/MNC or no SIM card inserted
* Replacing or removing SIM card later on will imply no change in Network Display Indicator icon
* After a factory reset, Network Display Indicator icon will be configured the same way as a brand new device

Attachments

(1 file, 1 obsolete file)

46 bytes, text/x-github-pull-request
Details | Review
As an Operator I want to change Network Display Indicator icon depending on the country, so that they are adapted to local standards

Acceptance criteria:
* Network Display Indicator icon will be configured per each MCC/MNC after inserting a new SIM card
* For example, depending on the country, LTE could be displayed as LTE, 4G, ...
* These are all the current options:
 | Icon Type | Description      |
 | 4G        | 4G LTE & 4G CDMA |
 | H+        | 3.5G HSPA+       |
 | H         | 3.5G HSDPA       |
 | Ev        | 3G CDMA          |
 | 3G        | 3G UMTS          |
 | E         | EDGE             |
 | 2G        | GPRS             |
 | 1x        | 2G CDMA          |
* There will be default values for the case of no Network Display Indicator icon is configured for a MCC/MNC
Keywords: feature
Whiteboard: [systemsfe]
Priority: -- → P1
Whiteboard: [systemsfe] → [ucid:System97, systemsfe]
QA Contact: rafael.marquez
No longer blocks: 1.3-systems-fe
Assignee: nobody → cjc
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
Updated following acceptance criteria:
* Network Display Indicator icon will be configured per each MCC/MNC after inserting a new SIM card for the first time
* There will be a default value for the case of no Network Display Indicator icon is configured for a MCC/MNC or no SIM card inserted
* Replacing or removing SIM card later on will imply no change in Network Display Indicator icon
* After a factory reset, Network Display Indicator icon will be configured the same process as a brand new device

Also started to use the new User Story field
User Story: (updated)
User Story: (updated)
Flags: in-moztrap?(rafael.marquez)
Attached file Proposed patch v1 (obsolete) —
Attachment #8371538 - Flags: review?(francisco.jordano)
Attachment #8371538 - Flags: review?(alive)
Blocks: 952026
Comment on attachment 8371538 [details] [review]
Proposed patch v1

looks ok
Attachment #8371538 - Flags: review?(alive) → review+
Blocks: 969642
I'm reviewing all pending System US and I have a question about how I can check this US. Does anyone know, how can I force the signal 2g, 3g, 4g ... to verify the value?
Settings -> cellular and data -> Network operator ->Network type
OK,Thanks Beatriz
Whiteboard: [ucid:System97, systemsfe] → [ucid:System97, systemsfe][systemsfe]
Target Milestone: 1.3 C3/1.4 S3(31jan) → 1.4 S1 (14feb)
Travis is failing (https://travis-ci.org/mozilla-b2g/gaia/builds/18352975) but after double checking, this patch doesn't touch any of the files that the failing tests use. So I'm going to checkin this and open a follow up bug to fix the broken tests.
https://github.com/mozilla-b2g/gaia/commit/3b0bc1c5dbd09cdb84dfa492b49dc3403b945020
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
I'm very sorry. I've mixed up this bug with another one on which I already have Jordano's r+. Rollbacked the merge to wait for the r+.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Do we have a new PR?
Comment on attachment 8371538 [details] [review]
Proposed patch v1

I've been reviewing the (merged) PR and looks fine to me.

Adding the r+, if you need another PR please carry over the two reviews from Alive and myself.

Thanks for the work!
Attachment #8371538 - Flags: review?(francisco.jordano) → review+
Blocks: 970929
Attached file Proposed patch v2
Attachment #8371538 - Attachment is obsolete: true
https://github.com/mozilla-b2g/gaia/commit/4f410b684d7768efbee0bf95af723c1f06c4be6c
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Blocks: 975703
Blocks: 975989
Blocks: 976951
Verified in master (1.4)branch. Good job. US without bugs.
The test will be sent to import them in moztrap

The acceptance criteria "Predictive text setting will be configured per each MCC/MNC after inserting a new SIM card for the first time" will be developed and tested in v1.5. After talking with the organization we have decided to close the US although this development is pending. A bug will be create
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.