970929 - Customize network indicator by SIM displayed in Settings -> Cellular & Data -> Network operator -> Network Type

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Noemí Freire (:noemi)]

The list corresponding to the different network types, the specific text, appearing under Settings -> Cellular & Data -> Network operator -> Network type will be customized per operator (based on mcc/mnc). Please refer to Bug 923449.

Comment 1

[Noemí Freire (:noemi)]

nominating to 1.4? in order to have consistency on the Network mode shown across all the menus

Comment 2

[Ivan Tsay (:ITsay)]

Won't take any feature in this stage for v1.4. Please talk to product team for them to plan it in the next release.

Comment 3

[Beatriz Rodríguez [:brg]]

This is already in the backlog product for v1.4 as part of the feature: Single variant: Network Display Indicator customization by SIM (bug 923449), this bug covers one of the menus where this technology is displayed. We will implement it in v1.4 time to have the full feature properly set.

Comment 4

[Ivan Tsay (:ITsay)]

Hi Bruce,

Could you help to confirm if we want to support this feature in v1.4? Thanks!

Comment 5

[Bruce Huang [:bhuang] (inactive)]

(In reply to Beatriz Rodríguez [:brg] from comment #3)
> This is already in the backlog product for v1.4 as part of the feature:
> Single variant: Network Display Indicator customization by SIM (bug 923449),
> this bug covers one of the menus where this technology is displayed. We will
> implement it in v1.4 time to have the full feature properly set.

Hi Beatriz,
Do you mean that there are already resources working on this?

Comment 6

[Beatriz Rodríguez [:brg]]

(In reply to Bruce Huang [:bhuang] <[e-mail]> from comment #5)
> (In reply to Beatriz Rodríguez [:brg] from comment #3)
> > This is already in the backlog product for v1.4 as part of the feature:
> > Single variant: Network Display Indicator customization by SIM (bug 923449),
> > this bug covers one of the menus where this technology is displayed. We will
> > implement it in v1.4 time to have the full feature properly set.
> 
> Hi Beatriz,
> Do you mean that there are already resources working on this?
Hi Bruce, our plan is to let Carmen implement this work. She is busy now with other topics but hopefully she will take it in the next sprint.

Comment 8

[Carmen Jimenez Cabezas]

Attachment: Proposed patch v1

Comment 9

[Carmen Jimenez Cabezas]

This bug solution should behave similar to bug 969642. For this reason, the proposed patch follows the same philosophy

Comment 10

[Fabien Cazenave [:kaze]]

Comment on attachment 8380396 [details] [review]
Proposed patch v1

Looks good to me. Restarting Travis to get complete test results.

Comment 11

[Julien Wajsberg [:julienw]]

Kaze, Travis is green.

Comment 12

[Fabien Cazenave [:kaze]]

Comment on attachment 8380396 [details] [review]
Proposed patch v1

looks good to me, thanks!

Comment 13

[Kai-Chih Hu [:khu]]

(In reply to Fabien Cazenave [:kaze] from comment #12)
> Comment on attachment 8380396 [details] [review]
> Proposed patch v1
> 
> looks good to me, thanks!

Thanks, are we ready to land?

Comment 14

[Carmen Jimenez Cabezas]

(In reply to Kevin Hu [:khu] from comment #13)
> (In reply to Fabien Cazenave [:kaze] from comment #12)
> > Comment on attachment 8380396 [details] [review]
> > Proposed patch v1
> > 
> > looks good to me, thanks!
> 
> Thanks, are we ready to land?

Yes, we are. Thanks to all!!

Comment 15

[Anthony Ricaud (:rik)]

Carmen: Is it possible to write some tests for this? I know Settings doesn't have a lot of coverage but we should improve that.

Reviewers: Please always ask why patches don't include tests.

Comment 16

[Anthony Ricaud (:rik)]

Needinfo for comment 15.

Comment 17

[Carmen Jimenez Cabezas]

(In reply to Anthony Ricaud (:rik) from comment #15)
> Carmen: Is it possible to write some tests for this? I know Settings doesn't
> have a lot of coverage but we should improve that.
> 
> Reviewers: Please always ask why patches don't include tests.

Since the deadline is tomorrow, and as agreed between Noemi and Anthony Ricaud..., if you don't mind I'm going to create a followup bug to include the unit tests for this bug, and we can merge this one now. I'll finish the unit tests as soon as possible

Comment 18

[Anthony Ricaud (:rik)]

Yes, it's reasonable to postpone landing the tests to meet the deadline. But the test work should be prioritised to land soon after. Thanks.

Comment 19

[Carmen Jimenez Cabezas]

The followup bug 977675 has been created for this bug

Comment 20

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/gaia/commit/e141462fffe1759c5b4851ded06f130ae32fd88e