Closed Bug 924114 Opened 11 years ago Closed 11 years ago

Migrate homescreen tests to use app objects

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: moz.teodosia, Assigned: ana.nikolaeva)

References

Details

(Whiteboard: [gaia-ui-test])

Attachments

(2 files)

Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12806
358 bytes, text/html
zcampbell
: review+
bsilverberg
: review-
AndreiH
: review+
Details
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13325
358 bytes, text/html
Bebe
: review+
AndreiH
: review+
Details 
The tests here /tests/functional/homescreen/ can be migrated to use the homescreen app object.
Eg: The method in this tests:
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/test_homescreen_delete_app.py#L94 

can be removed and we can use the one in the homescreen app:
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/homescreen/app.py#L49
Whiteboard: [gaia-ui-test]
I can take this.
I've set you assigned to it Ana.

Ping us if you need any help/advice/etc.
Assignee: nobody → ana.nikolaeva
Pointer to Github pull-request
Attachment #816377 - Flags: review?(zcampbell)
Attachment #816377 - Flags: review?(moz.teodosia)
My comments are in the PR
Comment on attachment 816377 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12806

Great job anah! Just a few comments in the pull request that need to be addressed.
Attachment #816377 - Flags: review-
Comment on attachment 816377 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12806

The pull lgtm
Attachment #816377 - Flags: review+
Attachment #816377 - Flags: review?(zcampbell)
Attachment #816377 - Flags: review?(moz.teodosia)
Attachment #816377 - Flags: review+
https://github.com/mozilla-b2g/gaia/commit/217b848c61c512719b05bc6c0591741b624a8666
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Does this also need to be added to the aurora branch?
Yes, we need this on aurora too. I've added bug 932279 for this.
Comment on attachment 826436 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13325

Uplifting to v1.2
Attachment #826436 - Flags: review?(zcampbell)
Attachment #826436 - Flags: review?(trifandreialin)
Attachment #826436 - Flags: review?(moz.teodosia)
Attachment #826436 - Flags: review?(florin.strugariu)
Attachment #826436 - Flags: review?(andrei.hutusoru)
Blocks: 934130
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 826436 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13325

This lgtm , runs great!
Attachment #826436 - Flags: review?(andrei.hutusoru) → review+
Attachment #826436 - Flags: review?(zcampbell)
Attachment #826436 - Flags: review?(trifandreialin)
Attachment #826436 - Flags: review?(moz.teodosia)
Attachment #826436 - Flags: review?(florin.strugariu)
Attachment #826436 - Flags: review+
https://github.com/mozilla-b2g/gaia/commit/0c9a07a6b524c17fdee96537d9add293257ba8c1
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: