Rewrite ConverterInputStream so that it avoids a copy

RESOLVED INCOMPLETE

Status

()

defect
P3
normal
RESOLVED INCOMPLETE
18 years ago
5 years ago

People

(Reporter: dougt, Unassigned)

Tracking

({perf})

Trunk
Future
x86
Windows 2000
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Reporter

Description

18 years ago
Currently ConverterInputStream uses two buffers - one for the single byte data
from the nsIInputStream, and another for the double byte data that it converts.
 We can write right input stream so that it calls ReadSegments on the incoming
inputstream.

This depends on Partial Reads.
Reporter

Updated

18 years ago
Blocks: 7251

Updated

18 years ago
Keywords: perf
Reporter

Updated

18 years ago
Blocks: 92479
Reporter

Updated

18 years ago
Target Milestone: --- → mozilla0.9.4
Reporter

Updated

18 years ago
Depends on: 93055
No longer blocks: 7251

Updated

18 years ago
Blocks: 7251
Reporter

Updated

18 years ago
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Reporter

Updated

18 years ago
Target Milestone: mozilla0.9.5 → mozilla1.0
Reporter

Updated

18 years ago
Blocks: 98275
Reporter

Comment 1

18 years ago
to darin.  This should be changed along with the changes to support partial
reads
Assignee: dougt → darin

Comment 2

18 years ago
i don't think this depends on partial reads.  it should possible to rewrite the
ConverterInputStream to not require mByteData.  instead, as dougt said, it could
call ReadSegments on mInput and convert each segment in the nsWriteSegmentFun
callback.  we'd thus eliminate one buffer copy.
Status: NEW → ASSIGNED
No longer depends on: 93055
Priority: -- → P3
Target Milestone: mozilla1.0 → mozilla0.9.9

Comment 3

18 years ago
not critical for mozilla 1.0
Target Milestone: mozilla0.9.9 → mozilla1.0.1

Updated

17 years ago
Target Milestone: mozilla1.0.1 → ---

Comment 4

17 years ago
mass futuring of untargeted bugs
Target Milestone: --- → Future
Assignee: darin → nobody
Status: ASSIGNED → NEW
QA Contact: scc → xpcom
Does this bug still need a solution? Or can it be marked as fixed?

Updated

8 years ago
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.