Closed Bug 92477 Opened 23 years ago Closed 13 years ago

Rewrite ConverterInputStream so that it avoids a copy

Categories

(Core :: XPCOM, defect, P3)

Product:
Core
Component:
XPCOM
Platform:
x86
Windows 2000
Type:
defect

Tracking

()

Status:
RESOLVED INCOMPLETE
Milestone:
Future

People

(Reporter: dougt, Unassigned)

References

Details

(Keywords: perf) 

Currently ConverterInputStream uses two buffers - one for the single byte data
from the nsIInputStream, and another for the double byte data that it converts.
 We can write right input stream so that it calls ReadSegments on the incoming
inputstream.

This depends on Partial Reads.
Blocks: 7251
Keywords: perf
Blocks: 92479
Target Milestone: --- → mozilla0.9.4
Depends on: 93055
No longer blocks: 7251
Blocks: 7251
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Target Milestone: mozilla0.9.5 → mozilla1.0
Blocks: 98275
to darin.  This should be changed along with the changes to support partial
reads
Assignee: dougt → darin
i don't think this depends on partial reads.  it should possible to rewrite the
ConverterInputStream to not require mByteData.  instead, as dougt said, it could
call ReadSegments on mInput and convert each segment in the nsWriteSegmentFun
callback.  we'd thus eliminate one buffer copy.
Status: NEW → ASSIGNED
No longer depends on: 93055
Priority: -- → P3
Target Milestone: mozilla1.0 → mozilla0.9.9
not critical for mozilla 1.0
Target Milestone: mozilla0.9.9 → mozilla1.0.1
Target Milestone: mozilla1.0.1 → ---
mass futuring of untargeted bugs
Target Milestone: --- → Future
Assignee: darin → nobody
Status: ASSIGNED → NEW
QA Contact: scc → xpcom
Does this bug still need a solution? Or can it be marked as fixed?
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.