Keep Shumway in m-c only

VERIFIED FIXED in Firefox 27

Status

Firefox Graveyard
Shumway
VERIFIED FIXED
4 years ago
a year ago

People

(Reporter: elan, Assigned: yury)

Tracking

27 Branch
Firefox 27
Dependency tree / graph

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
We have legal clearance for Nightly only at this point so Shumway and associated source code should not be uplifted/merged past m-c.
Yury said he was taking this. I think what we need is a configure flag for MOZ_SHUMWAY and have that default based on NIGHTLY_BUILD.
Assignee: nobody → ydelendik
tracking-firefox27: --- → ?
(Assignee)

Updated

4 years ago
Blocks: 904346
(Assignee)

Updated

4 years ago
Blocks: 923596
We should avoid the configure flag if possible - just add some ifdefs where needed.
(Assignee)

Comment 3

4 years ago
Created attachment 820088 [details] [diff] [review]
Enable Shumway only for Nightly builds

Basically adds ifdef/endif conditions for https://bug904346.bugzilla.mozilla.org/attachment.cgi?id=812358 . Choosing the reviewer based on bug 904346.
Attachment #820088 - Flags: review?(gps)

Updated

4 years ago
status-firefox27: --- → affected
tracking-firefox27: ? → +

Comment 4

4 years ago
Comment on attachment 820088 [details] [diff] [review]
Enable Shumway only for Nightly builds

Review of attachment 820088 [details] [diff] [review]:
-----------------------------------------------------------------

The manual nsinstall use is considered bad practice (use INSTALL_TARGETS instead). But I let it slide before on grounds of precedence. Build group will clean this all up eventually.
Attachment #820088 - Flags: review?(gps) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed

Comment 5

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/bbe26a0b5ce3
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/bbe26a0b5ce3
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox27: affected → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]

Updated

4 years ago
Keywords: verifyme
Aurora (Fx27) build from 20131101 does not contain Shumway.
Status: RESOLVED → VERIFIED
status-firefox27: fixed → verified
Keywords: verifyme
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.