Closed Bug 926988 Opened 6 years ago Closed 6 years ago

Keep Shumway in m-c only

Categories

(Firefox Graveyard :: Shumway, defect)

27 Branch
defect
Not set

Tracking

(firefox27+ verified)

VERIFIED FIXED
Firefox 27
Tracking Status
firefox27 + verified

People

(Reporter: elan, Assigned: yury)

References

Details

Attachments

(1 file)

We have legal clearance for Nightly only at this point so Shumway and associated source code should not be uplifted/merged past m-c.
Yury said he was taking this. I think what we need is a configure flag for MOZ_SHUMWAY and have that default based on NIGHTLY_BUILD.
Assignee: nobody → ydelendik
Blocks: shumway
Blocks: 923596
We should avoid the configure flag if possible - just add some ifdefs where needed.
Basically adds ifdef/endif conditions for https://bug904346.bugzilla.mozilla.org/attachment.cgi?id=812358 . Choosing the reviewer based on bug 904346.
Attachment #820088 - Flags: review?(gps)
Comment on attachment 820088 [details] [diff] [review]
Enable Shumway only for Nightly builds

Review of attachment 820088 [details] [diff] [review]:
-----------------------------------------------------------------

The manual nsinstall use is considered bad practice (use INSTALL_TARGETS instead). But I let it slide before on grounds of precedence. Build group will clean this all up eventually.
Attachment #820088 - Flags: review?(gps) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bbe26a0b5ce3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Keywords: verifyme
Aurora (Fx27) build from 20131101 does not contain Shumway.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.