926988 - Keep Shumway in m-c only

Status: VERIFIED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Erin Lancaster [:elan]]

We have legal clearance for Nightly only at this point so Shumway and associated source code should not be uplifted/merged past m-c.

Comment 1

[Benjamin Smedberg]

Yury said he was taking this. I think what we need is a configure flag for MOZ_SHUMWAY and have that default based on NIGHTLY_BUILD.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

We should avoid the configure flag if possible - just add some ifdefs where needed.

Comment 3

[Yury Delendik (:yury)]

Attachment: Enable Shumway only for Nightly builds

Basically adds ifdef/endif conditions for https://bug904346.bugzilla.mozilla.org/attachment.cgi?id=812358 . Choosing the reviewer based on bug 904346.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 820088 [details] [diff] [review]
Enable Shumway only for Nightly builds

Review of attachment 820088 [details] [diff] [review]:
-----------------------------------------------------------------

The manual nsinstall use is considered bad practice (use INSTALL_TARGETS instead). But I let it slide before on grounds of precedence. Build group will clean this all up eventually.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/fx-team/rev/bbe26a0b5ce3

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bbe26a0b5ce3

Comment 7

[Tracy Walker [:tracy]]

Aurora (Fx27) build from 20131101 does not contain Shumway.