Closed
Bug 958497
Opened 12 years ago
Closed 12 years ago
Use the correct character type in th_char.h depending on the language to use
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
802 bytes,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #957356 +++
th_char.h is included in both C and C++ code. We would like to restrict the char16_t type to C++ code only, and this is a place in our code base which we seem to be unintentionally using it in C code.
Since there is no good type which we can currently use for both C and C++, let's do this ugly hack of using uint16_t in C which is binary compatible. The reason we cannot use wchar_t here is that in mingw, wchar_t is 4 bytes, which is not binary compatible with char16_t.
Attachment #8358366 -
Flags: review?(smontagu)
|
||
Updated•12 years ago
|
Attachment #8358366 -
Flags: review?(smontagu) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
||
Comment 2•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
|
||
Updated•12 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•