928890 - contacts facebook import broken by webidl change

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

E/GeckoConsole( 2808): [JavaScript Error: "TypeError: 'additionalName' member of ContactProperties can't be converted to a sequence." {file: "app://communications.gaiamobile.org/contacts/js/fb/fb_contact.js" line: 135}]

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Hmm, fb_contact.js wants to set the mozContacts.updated field, but that is read-only in webidl world.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Pull request at https://github.com/mozilla-b2g/gaia/pull/12974

This pull request makes contact properties array where appropriate.  It also no longer uses mozContact for the prototype of the merged object.

This was causing problems when trying to set the updated and published fields.  Using null for the prototype seems to work in my tests, but we need to carefully review this.

Jose, what do you think?

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Also, this depends on the fix in bug 928875 to pass the mozContact object correctly to mozContacts.save().

Comment 4

[Jose Manuel Cantera]

Hi Ben,

It is apparently ok but I would like to do additional testing with FB linking. As now the Contacts App is unstable that will be done tomorrow once I can create a contact :)

Tomorrow the review will be finished!

thanks!

Comment 5

[Jose Manuel Cantera]

Comment on attachment 819689 [details]
Pull request at https://github.com/mozilla-b2g/gaia/pull/12974

basic testing performed and working

thanks, Ben

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Thanks Jose!  Merged:

  https://github.com/mozilla-b2g/gaia/commit/e37ae7e657de942c66fccaf9e6a5f953880cb575