Closed Bug 929043 Opened 9 years ago Closed 9 years ago

[Contacts] Contacts .remove function used broken due to webidl

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: arcturus, Unassigned)

References

Details

(Whiteboard: [c= p=1 s= u=])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #928875 +++

It looks like webidl also broke then merge:

E/GeckoConsole(  417): [JavaScript Error: "TypeError: Argument 1 of ContactManager.remove does not implement interface mozContact." {file: "app://communications.gaiamobile.org/contacts/js/contacts_merger.js" line: 213}]
No longer blocks: 928890
No longer blocks: 850430
No longer depends on: 928875
See Also: → 928954
Use this but to fix all the instances of the .remove problem with the webidl drama
Summary: [Contacts] Merge contacts from sim broken due to webidl → [Contacts] Contacts .remove function used broken due to webidl
Attached file Pointer to PR 12985
Attachment #819862 - Flags: review?(bkelly)
Blocks: 850430
Comment on attachment 819862 [details]
Pointer to PR 12985

I think we might be make more mozContact objects than necessary now, but those does seem safest given that we have those weird, merged FB contacts floating around.

Thanks!  r=me
Attachment #819862 - Flags: review?(bkelly) → review+
No longer blocks: 929071
Depends on: 929071
Landed:

https://github.com/mozilla-b2g/gaia/commit/e3323f920a0a40f5efb386e4a3e48ba8c7de3a81
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to Phil Ringnalda (:philor) from comment #5)
> Test bustage
> (https://tbpl.mozilla.org/php/getParsedLog.php?id=29460457&tree=B2g-Inbound),
> could you please revert that?

That's strange - the patch here is supposed to fix that regression.

Ben?
Flags: needinfo?(bkelly)
oh and another thing - reverting the patch here won't do any help. The test will likely fail without the patch anyways. We probably should disable the test and figure out why it's failing.
Oh, I probably got thrown off by the way b2g-inbound builds whichever pushes it feels like, and then runs tests on whichever of those it feels like, when it gets busy. Odds are what I meant was that bug 929078 jumped the gun and reenabled a failing test.
Okay. Let's get this backed out then.
Flags: needinfo?(bkelly)
Talked with lightsofapollo in IRC - We think we should xfail the test and let bkelly investigate this. We're puzzled by the results in comment 9.
I disabled the test here: https://github.com/mozilla-b2g/gaia/commit/6b4f0746b30a8685600435ea96808fc4e1671473

This is only for TBPL- I am suspicious of the failures here being a real functional problem rather then just a test error.
needinfo on Ben to investigate the test being disabled
Flags: needinfo?(bkelly)
Depends on: 929287
It appears you cannot initialize a mozContact with an existing mozContact.  Patches being investigated in bug 929287.
Flags: needinfo?(bkelly)
You need to log in before you can comment on or make changes to this bug.