Closed Bug 929315 Opened 11 years ago Closed 11 years ago

[HW test] geolocation needs permission

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.3+)

Status:
RESOLVED FIXED
Milestone:
1.3 Sprint 5 - 11/22
Project Flags:
blocking-b2g 1.3+

People

(Reporter: tjao, Assigned: tjao)

References

Details

(Whiteboard: [ft:system-platform])

Attachments

(1 file, 1 obsolete file)

https://github.com/mozilla-b2g/gaia/pull/13278
46 bytes, text/x-github-pull-request
gasolin
: review+
Details | Review 
There're some bugs in UItest (not gaia-ui-test.)

Geolocation
Needs permission.

Orientation
Missing button causes JS stop working. Modified to switch-case to solve it.

Multiactivities
The function is never called.

Recording
Lack of JS file. Change this test to GetUserMedia test

Path fix
Because I modified the folder structure, paths should be fix.

Dual alerts bug
I found that if you are in an window.alert screen and asynchronously triggers (probably using settimeout) another alert. The following settimeout calls will fail. So I modified such codes to console.log since these alert are used for debugging.
Assignee: nobody → tjao
Blocks: 913385
No longer blocks: 913385
Blocks: eng-mode
Blocks: 925673
Target Milestone: --- → 1.3 Sprint 5 - 11/22
blocking-b2g: --- → 1.3+
Whiteboard: [ft:system-platform]

        Attachment #823198 -
        Flags: review?(ehung)

    
    

    
  
Also fixed bug in keyboard test
Summary: [HW test] geolocation, orientation, multiactivities, recording, paths, dual alerts fix → [HW test] several bugs fix

    
    

    
  
Evelyn suggested me to separate this bug into much smaller bugs. Please refer to bug 883714 for more information. This one will become gelocation fix.
Summary: [HW test] several bugs fix → [HW test] geolocation needs permission

    
    

    
  
Comment on attachment 823198 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13126

cancel the review flag first since you will also need to separate your PR to three parts.

        Attachment #823198 -
        Flags: review?(ehung)

    
    

    
  


  

        Attachment #823198 -
        Attachment is obsolete: true

        Attachment #825737 -
        Flags: review?(flin)

    
  

        Attachment #825737 -
        Flags: review?(flin) → review+

    
    

    
  
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/39d41749bbdb410d79f865a571cba5da903681b0

thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: