913385 - Hardware testing app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Tom Jao [:mbrsl]]

This app should integrates several hardware tests like:
LCD colors, Vibrator, Physical buttons, Touch screen and etc.
Please check https://etherpad.mozilla.org/gaia-manual-test-items for the complete list.

The current implementation is based on the UITest in gaia/test_apps.

Comment 1

[Tom Jao [:mbrsl]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/11989

Comment 2

[Evelyn Hung]

Thanks for the patch, but sorry I don't have time to review it this week. Since it's not an urgent patch, I will review it next week.

Comment 3

[Evelyn Hung]

Comment on attachment 800702 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/11989

r=me, please follow our coding convention. Fix the following problems and r? me again. Thanks.
* no inline style
* gjslint
* add bug number on fail cases.

Comment 4

[Evelyn Hung]

Tom, you need to flag review again after your update.

Comment 5

[Evelyn Hung]

Comment on attachment 800702 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/11989

r=me, there are a lot details we can polish for this test app, but I think the patch is huge so I'd like to have some follow-up bugs. Good job, thanks for your excellent work.

Comment 6

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/5cbabfd0447bae12d87fd5e520e245943f847c7e

Congrats Tom!

Though the uitest still fail, hope you can help to fix/mentor those issues seems you are quite familiar with uitest now :)

Comment 7

[Anthony Ricaud (:rik)]

I had to back this out since it introduced a regression in a UI test.

https://github.com/mozilla-b2g/gaia/commit/c4d56c6eeb8f2aeef7f71975683c9aca11bb17b4

You can see the output at https://travis-ci.org/mozilla-b2g/gaia/jobs/12864230#L1774

Comment 8

[Anthony Ricaud (:rik)]

It also broke test_number_keyboard.py https://travis-ci.org/mozilla-b2g/gaia/jobs/12864230#L1736

Comment 9

[Tom Jao [:mbrsl]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/13024

Comment 10

[Tom Jao [:mbrsl]]

Thanks for the comments. Because of the change of the layout, some test cases failed. So I modified the test cases to fit the new layout.

There's something weird about test_number_keyboard.py. This test failed in my local test (it's stuck when clicking on number field, keyboard not showing up) but passed on Travis. I'm still testing it.

Comment 11

[Zac C (:zac)]

Comment on attachment 820919 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13024

Test changes look OK. just waiting on a Green on Travis now :)

Comment 12

[Evelyn Hung]

re-land to gaia master: https://github.com/mozilla-b2g/gaia/commit/1229ba24a5477a1ae0655b04bcae779bf3166a17

Comment 13

[Tom Jao [:mbrsl]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/13129

Comment 14

[Evelyn Hung]

reopen since there is some problem on attachment 820919 [details] [review]

Comment 15

[Evelyn Hung]

Comment on attachment 823235 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13129

follow up patch for fixing a small issues in attachment 820919 [details] [review].

Comment 16

[Evelyn Hung]

(In reply to Evelyn Hung [:evelyn] from comment #15)
> Comment on attachment 823235 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/13129
> 
> follow up patch for fixing a small issues in attachment 820919 [details] [review].

land to gaia master: https://github.com/mozilla-b2g/gaia/commit/31c260b5c853fe78d6bf44c6aeec52a651c3f025

Comment 17

[Sotaro Ikeda [:sotaro]]

This bug's change made some tests in 'UI test' do not work. like 'Inser fake contacts'. Paths to files under ./data/ were not updated. By locally update the some paths, I confirmed 'Inser fake contacts' became work again.

Comment 18

[Tom Jao [:mbrsl]]

Thanks for the comment. That's right, and I filed it as bug 931727. Because this patch is rather big (sorry my fault.) We decided to land it first and followed with several smaller bug fixes. Other bugs to be fix can be found in the dependency of bug 883714.