930064 - Menu Panel has different style than other panels

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Stephen Horlander [:shorlander]]

Attachment: Menu Panel border/shadow comparison

The border and shadow on the Menu Panel looks different from our other panels. Looks like a style is getting dropped/overridden somewhere.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

This is Mac only, I can't reproduce it on Windows.

Comment 2

[Mike de Boer [:mikedeboer]]

Looks like a different border color is causing it; the drop shadow gradient starts at a different, lighter color, which makes it appear different.

Comment 3

[Tim Nguyen :ntim]

Happens on Windows too, the box-shadow is missing from the menu panel (but is visible on other panels).

Comment 5

[Thomas Stache]

So is this an OS X or OS X/Windows bug? I was about to file a bug for the missing Windows (7?) drop shadow, but see this was already duped here once.

Comment 6

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to Thomas Stache from comment #5)
> So is this an OS X or OS X/Windows bug? I was about to file a bug for the
> missing Windows (7?) drop shadow, but see this was already duped here once.

You're right, there is that issue on Windows as well, but it is not the same as the one discussed here. I prematurely duped bug 964315 to this one, but I'll reopen it now as it is a different (and Windows-specific) issue.

Comment 7

[Matthew N. [:MattN]]

(In reply to Stephen Horlander [:shorlander] from comment #0)
> Created attachment 821078 [details]
> Menu Panel border/shadow comparison

This should be fixed by bug 964315. FTR, compare the arrows on the panels in the screenshot to clearly see the issue.

Comment 8

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

As for the border style:
I think we should make the other panels match the menu here. It looks much lighter and less boxy.
Stephen, what do you think?

Comment 9

[Tim Nguyen :ntim]

(In reply to Philipp Sackl [:phlsa] from comment #8)
> As for the border style:
> I think we should make the other panels match the menu here. It looks much
> lighter and less boxy.
> Stephen, what do you think?

The goal is to make it look like this : https://people.mozilla.org/~shorlander/files/australis-design-specs/australis-design-specs-osx.html

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

This should be fixed now that bug 964315 has landed. Stephen, can you confirm that it is fixed on OSX?

Philipp, it would be better to track that in a different bug with more details and specifications of what you think should be changed.

Comment 11

[Stephen Horlander [:shorlander]]

(In reply to Jared Wein [:jaws] from comment #10)
> This should be fixed now that bug 964315 has landed. Stephen, can you
> confirm that it is fixed on OSX?
> 
> Philipp, it would be better to track that in a different bug with more
> details and specifications of what you think should be changed.

Yes, this fixes this specific issue.

Comment 12

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Turns out shorlander is already fixing the issues I was thinking of in bug 968595 :)

Comment 13

[:Gijs (he/him)]

Both bug 964315 and bug 968595 have been uplifted, so marking this fixed on 29 as well as 30.