Closed Bug 930064 Opened 11 years ago Closed 10 years ago

Menu Panel has different style than other panels

Categories

(Firefox :: Toolbars and Customization, defect)

All
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 30
Tracking Status
firefox29 --- fixed
firefox30 --- fixed

People

(Reporter: shorlander, Assigned: shorlander)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P3-])

Attachments

(1 file)

The border and shadow on the Menu Panel looks different from our other panels. Looks like a style is getting dropped/overridden somewhere.
Attachment #821078 - Attachment description: panel-bug.png → Menu Panel border/shadow comparison
This is Mac only, I can't reproduce it on Windows.
Blocks: australis-cust
No longer blocks: australis
Looks like a different border color is causing it; the drop shadow gradient starts at a different, lighter color, which makes it appear different.
Blocks: 925284
Whiteboard: [Australis:M?] → [Australis:P3][Australis:M?]
Whiteboard: [Australis:P3][Australis:M?] → [Australis:P4]
Happens on Windows too, the box-shadow is missing from the menu panel (but is visible on other panels).
Whiteboard: [Australis:P4] → [Australis:P3]
Depends on: 968595
So is this an OS X or OS X/Windows bug? I was about to file a bug for the missing Windows (7?) drop shadow, but see this was already duped here once.
Flags: needinfo?(philipp)
(In reply to Thomas Stache from comment #5)
> So is this an OS X or OS X/Windows bug? I was about to file a bug for the
> missing Windows (7?) drop shadow, but see this was already duped here once.

You're right, there is that issue on Windows as well, but it is not the same as the one discussed here. I prematurely duped bug 964315 to this one, but I'll reopen it now as it is a different (and Windows-specific) issue.
Flags: needinfo?(philipp)
Whiteboard: [Australis:P3] → [Australis:P3-]
(In reply to Stephen Horlander [:shorlander] from comment #0)
> Created attachment 821078 [details]
> Menu Panel border/shadow comparison

This should be fixed by bug 964315. FTR, compare the arrows on the panels in the screenshot to clearly see the issue.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
As for the border style:
I think we should make the other panels match the menu here. It looks much lighter and less boxy.
Stephen, what do you think?
Flags: needinfo?(shorlander)
(In reply to Philipp Sackl [:phlsa] from comment #8)
> As for the border style:
> I think we should make the other panels match the menu here. It looks much
> lighter and less boxy.
> Stephen, what do you think?

The goal is to make it look like this : https://people.mozilla.org/~shorlander/files/australis-design-specs/australis-design-specs-osx.html
This should be fixed now that bug 964315 has landed. Stephen, can you confirm that it is fixed on OSX?

Philipp, it would be better to track that in a different bug with more details and specifications of what you think should be changed.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to Jared Wein [:jaws] from comment #10)
> This should be fixed now that bug 964315 has landed. Stephen, can you
> confirm that it is fixed on OSX?
> 
> Philipp, it would be better to track that in a different bug with more
> details and specifications of what you think should be changed.

Yes, this fixes this specific issue.
Flags: needinfo?(shorlander)
Status: RESOLVED → VERIFIED
Turns out shorlander is already fixing the issues I was thinking of in bug 968595 :)
Assignee: jaws → shorlander
Target Milestone: --- → Firefox 30
Both bug 964315 and bug 968595 have been uplifted, so marking this fixed on 29 as well as 30.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: