964315 - The panel menu doesn't have a drop shadow on Windows

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

All panels (e.g. Bookmarks, Downloads, History) have a nice and subtle drop shadow in Australis. The panel menu is the only one that hasn't.

Comment 2

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Un-duping this one because it is actually a different issue on a different platform.

Comment 3

[Thomas Stache]

Thx for the clarification!

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8372752 [details] [diff] [review]
Patch

OK, after thorough investigation it seems like this fixes bug 930064 too.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/a51b82553a27

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/a51b82553a27

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8372752 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 877684
User impact if declined: missing shadow on the menu panel
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): none
String or IDL/UUID changes made by this patch: none

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fb518025b00c

Comment 11

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.3; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0
Mozilla/5.0 (Windows NT 6.3; rv:30.0) Gecko/20100101 Firefox/30.0

Verified as fixed on latest Aurora (build ID: 20140320004001) and Firefox 29 beta 1 (build ID: 20140318013849).