Closed
Bug 930386
Opened 11 years ago
Closed 11 years ago
[music] Music icon no longer shows up in "now playing" notification
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Firefox OS Graveyard
Gaia::Music
Tracking
(b2g-v1.2 fixed, b2g-v1.3 fixed)
RESOLVED
FIXED
People
(Reporter: squib, Assigned: squib)
References
Details
(Keywords: regression)
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
dkuo
:
review+
bajaj
:
approval-gaia-v1.2+
|
Details | Review |
Bug 922462 changed the path for the music icon that we send to the now playing notification. Let's fix this. Note that my patch here is keeping things simple for now; I plan on reworking this code anyway in bug 929416, so this code will probably vanish in a puff of smoke soon anyway.
Attachment #821477 -
Flags: review?(dkuo)
Comment 1•11 years ago
|
||
Comment on attachment 821477 [details] [review]
Fix this
It's a simple and trivial patch, r+, thanks Jim!
Attachment #821477 -
Flags: review?(dkuo) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•11 years ago
|
||
Adding regression keyword. I don't think we need to uplift this (yet), since the bug that regressed this isn't uplifted either.
Keywords: regression
Comment 4•11 years ago
|
||
Comment on attachment 821477 [details] [review]
Fix this
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment] followup bugs
[Bug caused by] (feature/regressing bug #): Bug 922462
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:
Attachment #821477 -
Flags: approval-gaia-v1.2?
Comment 5•11 years ago
|
||
Please help by provide info on [User impact] if declined
Flags: needinfo?(gasolin)
Assignee | ||
Comment 6•11 years ago
|
||
Do we need approval? This bug doesn't need uplifting, since bug 922462 isn't uplifted either (at least, I don't think it is). Should I not be using the "regression" keyword when there's a regression that's only on the master branch?
In any case...
[Approval Request Comment] followup bugs
[Bug caused by] (feature/regressing bug #): Bug 922462
[User impact] if declined: No icon will show up next to the "now playing" info in the notification tray when listening to music.
[Testing completed]: Manually tested by looking at the icon. :)
[Risk to taking this patch] (and alternatives if risky): Effectively no risk; it's a one-line change to point update the path of an image.
[String changes made]: None
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(gasolin)
Comment 7•11 years ago
|
||
Comment on attachment 821477 [details] [review]
Fix this
approving, given the low risk and its a fallout form 922462
Attachment #821477 -
Flags: approval-gaia-v1.2? → approval-gaia-v1.2+
Comment 8•11 years ago
|
||
Uplifted f60d7a3a7b61e736702d495a4b1e94ff98c1d3e0 to:
v1.2: 8f1e7c2bf8bb7dbe7d3c375f918f55876a3c67b7
status-b2g-v1.2:
--- → fixed
Comment 9•11 years ago
|
||
Uplifted f60d7a3a7b61e736702d495a4b1e94ff98c1d3e0 to:
v1.3 already had this commit
status-b2g-v1.3:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•