930386 - [music] Music icon no longer shows up in "now playing" notification

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Jim Porter (:squib)]

Attachment: Fix this

Bug 922462 changed the path for the music icon that we send to the now playing notification. Let's fix this. Note that my patch here is keeping things simple for now; I plan on reworking this code anyway in bug 929416, so this code will probably vanish in a puff of smoke soon anyway.

Comment 1

[Dominic Kuo [:dkuo]]

Comment on attachment 821477 [details] [review]
Fix this

It's a simple and trivial patch, r+, thanks Jim!

Comment 2

[Jim Porter (:squib)]

Landed: https://github.com/mozilla-b2g/gaia/commit/f60d7a3a7b61e736702d495a4b1e94ff98c1d3e0

Comment 3

[Jim Porter (:squib)]

Adding regression keyword. I don't think we need to uplift this (yet), since the bug that regressed this isn't uplifted either.

Comment 4

[[e-mail]]

Comment on attachment 821477 [details] [review]
Fix this

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment] followup bugs
[Bug caused by] (feature/regressing bug #): Bug 922462
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 5

[Preeti Raghunath(:Preeti)]

Please help by provide info on [User impact] if declined

Comment 6

[Jim Porter (:squib)]

Do we need approval? This bug doesn't need uplifting, since bug 922462 isn't uplifted either (at least, I don't think it is). Should I not be using the "regression" keyword when there's a regression that's only on the master branch?

In any case...

[Approval Request Comment] followup bugs
[Bug caused by] (feature/regressing bug #): Bug 922462
[User impact] if declined: No icon will show up next to the "now playing" info in the notification tray when listening to music.
[Testing completed]: Manually tested by looking at the icon. :)
[Risk to taking this patch] (and alternatives if risky): Effectively no risk; it's a one-line change to point update the path of an image.
[String changes made]: None

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 821477 [details] [review]
Fix this

approving, given the low risk and its a fallout form 922462

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted f60d7a3a7b61e736702d495a4b1e94ff98c1d3e0 to:
v1.2: 8f1e7c2bf8bb7dbe7d3c375f918f55876a3c67b7

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted f60d7a3a7b61e736702d495a4b1e94ff98c1d3e0 to:
v1.3 already had this commit