922462 - [Flatfish] Define various size of icons in manifest instead of use buildscript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[[e-mail]]

Current we use GAIA_DEV_PIXELS_PER_PX=1.5 to customize resources. To get better icon quality for homescreen.

We should define various size of icons in manifest instead of use buildscript.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Christian,

Could you help to review this patch?
Thanks.

Comment 2

[Cristian Rodriguez (:crdlc)]

The code of home was reviewed and you have two comments

Comment 3

[Cristian Rodriguez (:crdlc)]

BTW my name is Cristian jijijiji

Comment 4

[[e-mail]]

George, please check shared/resources/branding/official/90/Browser.png , I think subfolder under official/unofficial might not work

Since our buildscript (gaia/build/webapp-optimize.js / gaia/build/webapp-zip.js) may not accept subfolders

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 812545 [details]
PR to master

Talked to George offline. Please flag me and :crdlc for review when you fixed the patch.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 812545 [details]
PR to master

Thanks Tim and Critian to address my pbs.

Patch is updated, please kindly check again.

Comment 7

[Cristian Rodriguez (:crdlc)]

Comment on attachment 812545 [details]
PR to master

I have one comment about the name of the variable in homescreen part. It looks good, thx

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 812545 [details]
PR to master

Thank you!

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks Tim and Cristian!

Merge into master,
https://github.com/mozilla-b2g/gaia/commit/3c3eda6d93d7329f437b71d03c3d28353f1f3d4c

Comment 10

[Cristian Rodriguez (:crdlc)]

Please back out, try to do 'make reset-gaia'. I think it was introduced here, am I wrong?

run-js-command  webapp-zip
Exception: Error: Using inexistent shared resource: branding/Browser.png from: system.gaiamobile.org

execute/</<@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/evyatar/workspace/gaia/build/webapp-zip.js:443
execute/<@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/evyatar/workspace/gaia/build/webapp-zip.js:431
makeWebappsObject/<.forEach/<@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/evyatar/workspace/gaia/build/utils.js:179
makeWebappsObject/<.forEach@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/evyatar/workspace/gaia/build/utils.js:121
execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/evyatar/workspace/gaia/build/webapp-zip.js:245

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Yes, I'll fix that and push again later.

Backout from master,

https://github.com/mozilla-b2g/gaia/commit/1c2a4942f39c056868d4247c21ddae8e53d0d660

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi,

this patch has 
1. updated the prefer size of tablet to 100px (actual display size is 100px) and 
2. fixed bg-overlay's height to correct size on tablet.
3. Browser.png to Browser_60.png

Comment 13

[Cristian Rodriguez (:crdlc)]

Comment on attachment 813063 [details]
PR to master

ok, thx

Comment 14

[James Lal [:lightsofapollo]]

Remember to watch the status _before_ landing we still need to do this manually but in the future it will be impossible to land in situations like this.

Comment 15

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks for Tim and Cristian's reviewing and James' reminding!

Merge into master,
https://github.com/mozilla-b2g/gaia/commit/55831f0c53a01c446211819298a1ba7f29dcc786

Comment 16

[(Inactive after June) George Duan [:gduan] [:喬智]]

The icon will become bigger than before now,
because below code ( bug 866174 https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/window_manager.js#L1176 ) will always display the largest one.

Comment 17

[Jason Smith [:jsmith]]

This caused a placeholder icon to appear for the clock instead of an actual icon on the 1.3 build right now. We need to either back this out to resolve bug 923672 or patch bug 923672 before uplifting this.

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 55831f0c53a01c446211819298a1ba7f29dcc786 to:
v1.2: 6edf487b98ddefe7ed71cde4a05e54d103fbc46c