930858 - [Flatfish][homescreen][1.2] fix search_page enabled customization

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

current search_page enabled customization are broken due to new e.me integration to start screen

expect:

can disable search bar via customization

--

Originally https://bugzilla.mozilla.org/show_bug.cgi?id=920445 focus on fixing this problem and it is fixed and landed in master now. Due to some decision change, its depended bug will not be landed in v1.2. 

In this way, I open a new bug focusing on fixing 1.2 branch for this issue.

Comment 1

[Jason Smith [:jsmith]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=920445#c8 for rationale.

Comment 2

[[e-mail]]

ej, please take bug 921327 e.me related change in concern https://github.com/mozilla-b2g/gaia/pull/12635/files

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: Pointer to Github pull request 13209

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 824483 [details] [review]
Pointer to Github pull request 13209

Hi Cristian, this is v1.2 change based on https://bugzilla.mozilla.org/show_bug.cgi?id=920445. 

After discussing with Fred, because v1.2 has no collection design and I think there is no need to check the collection in applications-data.js. 

All this bug fix do is disable everything.me in flatfish (from distribution_tablet/homescreens.json) and keep the flexibility for the future if we want to do something after enabling it. 

What do you think :) ?

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 824483 [details] [review]
Pointer to Github pull request 13209

You have my comments and feedback on Github, ask again for review when they are addressed. Thanks a lot

Comment 6

[[e-mail]]

Francis, should we keep working on this 1.2 specific patch?

Comment 7

[Francis Lee [:frlee]]

this bug depends on release version. if we go for v1.3, this bug will be invalid.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Just confirmed with Fred, after discussion, flatfish will use v1.3 directly and it means this v1.2 branch specific fix will be invalid.