Closed
Bug 931404
Opened 12 years ago
Closed 12 years ago
Move LOCAL_INCLUDES to moz.build in content/
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
24.61 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #822871 -
Flags: review?(gps)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 822871 [details] [diff] [review]
Patch v1
Review of attachment 822871 [details] [diff] [review]:
-----------------------------------------------------------------
This patch taught me to pay more attention to Makefile changes under content/media :)
Attachment #822871 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Comment 4•12 years ago
|
||
It causes a regression - Bug 941595 - firefox can't be be build with system cairo.
We need to add the MOZ_CAIRO_BUILD to CXXFLAGS but the Makefile.in has been removed.
|
|
||
Comment 5•12 years ago
|
||
To be clear it's content/events/src/Makefile.in which needs the cairo build flags.
|
||
Updated•12 years ago
|
Whiteboard: [qa-]
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•