Move LOCAL_INCLUDES to moz.build in content/

RESOLVED FIXED in mozilla28

Status

RESOLVED FIXED
5 years ago
6 months ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

unspecified
mozilla28
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 822871 [details] [diff] [review]
Patch v1
Attachment #822871 - Flags: review?(gps)

Comment 2

5 years ago
Comment on attachment 822871 [details] [diff] [review]
Patch v1

Review of attachment 822871 [details] [diff] [review]:
-----------------------------------------------------------------

This patch taught me to pay more attention to Makefile changes under content/media :)
Attachment #822871 - Flags: review?(gps) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/b95200e5f556
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
It causes a regression - Bug 941595 - firefox can't be be build with system cairo.

We need to add the MOZ_CAIRO_BUILD to CXXFLAGS but the Makefile.in has been removed.
To be clear it's content/events/src/Makefile.in which needs the cairo build flags.
(Assignee)

Updated

5 years ago
Depends on: 941595
No longer depends on: 941595

Updated

5 years ago
Whiteboard: [qa-]

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.